[Bug 11746] New: Add edit item links to record details page
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 Bug ID: 11746 Summary: Add edit item links to record details page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl In order to edit a specific item right now, one must select the edit pulldown, then choose edit items, the click the edit link for the particular item the librarian wishes to edit. It would be much more convenient to have an edit link for each specific item in the items table on the record details page. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25204 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25204&action=edit Bug 11746 - Add edit item links to record details page In order to edit a specific item right now, one must select the edit pulldown, then choose edit items, the click the edit link for the particular item the librarian wishes to edit. It would be much more convenient to have an edit link for each specific item in the items table on the record details page. Test Plan: 1) Apply this patch 2) View the record details for a record with items 3) Click the edit link for a particular item 4) Note that you are taken immediately to the item editor for this particular item -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Hi Kyle I would also like a more direct way to edit the item. I am not sure if this new Edit column not deviates from the current design with the check buttons for delete or batch modify, and the link on barcode. But it works.. Will leave this problem to the QAer on duty :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25204|0 |1 is obsolete| | --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 25206 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25206&action=edit Bug 11746 - Add edit item links to record details page In order to edit a specific item right now, one must select the edit pulldown, then choose edit items, the click the edit link for the particular item the librarian wishes to edit. It would be much more convenient to have an edit link for each specific item in the items table on the record details page. Test Plan: 1) Apply this patch 2) View the record details for a record with items 3) Click the edit link for a particular item 4) Note that you are taken immediately to the item editor for this particular item Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- The edit link should not be shown to users who don't have permission to edit. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25222 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25222&action=edit Bug 11746 [QA Followup] - Add edit item links to record details page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Owen Leonard from comment #4)
The edit link should not be shown to users who don't have permission to edit.
Wow, I can't believe I forgot to check permissions! Followup submitted! Kyle -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 Havilah Lyon <havilah@aflibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |havilah@aflibrary.org --- Comment #7 from Havilah Lyon <havilah@aflibrary.org> --- Tested it and it works as described. Great job, Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25225&action=edit Bug 11746 [QA Followup 2] - Disable sorting on Edit column -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 Melissa Lefebvre <melissa@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25206|0 |1 is obsolete| | --- Comment #9 from Melissa Lefebvre <melissa@bywatersolutions.com> --- Created attachment 25226 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25226&action=edit Bug 11746 - Add edit item links to record details page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 Melissa Lefebvre <melissa@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25222|0 |1 is obsolete| | --- Comment #10 from Melissa Lefebvre <melissa@bywatersolutions.com> --- Created attachment 25227 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25227&action=edit Bug 11746 [QA Followup] - Add edit item links to record details page -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 Melissa Lefebvre <melissa@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25225|0 |1 is obsolete| | --- Comment #11 from Melissa Lefebvre <melissa@bywatersolutions.com> --- Created attachment 25228 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25228&action=edit Bug 11746 [QA Followup 2] - Disable sorting on Edit column -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@biblibre.co | |m --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- I got a JS error on goind on catalogue/detail.pl DataTables warning (table id = 'DataTables_Table_0'): Requested unknown parameter '9' from the data source for row 0 If there is no course reserve, there are no 10 columns. Marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 25579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25579&action=edit Bug 11746 [QA Followup 3] -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25226|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25607&action=edit Bug 11746 - Add edit item links to record details page In order to edit a specific item right now, one must select the edit pulldown, then choose edit items, the click the edit link for the particular item the librarian wishes to edit. It would be much more convenient to have an edit link for each specific item in the items table on the record details page. Test Plan: 1) Apply this patch 2) View the record details for a record with items 3) Click the edit link for a particular item 4) Note that you are taken immediately to the item editor for this particular item Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Havilah Lyon <havilah@aflibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25227|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25608&action=edit Bug 11746 [QA Followup] - Add edit item links to record details page Signed-off-by: Havilah Lyon <havilah@aflibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25228|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25609&action=edit Bug 11746 [QA Followup 2] - Disable sorting on Edit column Signed-off-by: Havilah Lyon <havilah@aflibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 --- Comment #17 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 25610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25610&action=edit Bug 11746 [QA Followup 3] Fix Javascript error DataTables warning (table id = 'DataTables_Table_0'): Requested unknown parameter '9' from the data source for row 0 Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #25579|0 |1 is obsolete| | CC| |gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Kyle! However, I am declining to push the second and third follow-ups, as they are not comprehensive enough -- if a staff user lacks permission to edit items, and spine label printing is off, and there are no analytics, the last column that would be made non-sortable would be an item information column. Leaving the edit column sortable for now is the lesser evil. I will open a new bug for setting up an actions column in the holdings table. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 --- Comment #19 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Galen Charlton from comment #18)
I will open a new bug for setting up an actions column in the holdings table.
Bug 11851. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #20 from Christopher Brannon <cbrannon@cdalibrary.org> --- *** Bug 11840 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolyn.somers@biblibre.co | |m --- Comment #21 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.08 (Like in master, concerns only the 2 first patches) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11746 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org