[Bug 12666] New: Offline Circulation has poor HTML
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12666 Bug ID: 12666 Summary: Offline Circulation has poor HTML Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: mtompset@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com While attempting to generate a test plan for a patch for bug 10446 related to offline circulation, I noticed the HTML was poor. This cleans it up. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12666 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12666 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 30238 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30238&action=edit Bug 12666 - Fix poor HTML from circ/offline.tt In koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt - Cleaned up the HTML's missing </div>'s - Corrected the autobuffer attribute to the newer preload one - Added into empty title, since it will get replaced TEST PLAN --------- 1) Run the circ/offline.pl page source through an HTML validator -- should get a few warnings 2) Apply patch 3) Recheck page source (confirm your page isn't cached!) -- should be clean -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12666 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mtompset@hotmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12666 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12666 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30238|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 30465 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30465&action=edit [SIGNED-OFF] Bug 12666 - Fix poor HTML from circ/offline.tt In koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt - Cleaned up the HTML's missing </div>'s - Corrected the autobuffer attribute to the newer preload one - Added into empty title, since it will get replaced TEST PLAN --------- 1) Run the circ/offline.pl page source through an HTML validator -- should get a few warnings 2) Apply patch 3) Recheck page source (confirm your page isn't cached!) -- should be clean Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12666 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12666 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30465|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30495 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30495&action=edit [PASSED QA] Bug 12666 - Fix poor HTML from circ/offline.tt In koha-tmpl/intranet-tmpl/prog/en/modules/circ/offline.tt - Cleaned up the HTML's missing </div>'s - Corrected the autobuffer attribute to the newer preload one - Added into empty title, since it will get replaced TEST PLAN --------- 1) Run the circ/offline.pl page source through an HTML validator -- should get a few warnings 2) Apply patch 3) Recheck page source (confirm your page isn't cached!) -- should be clean Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Improves HTML validity, no regressions found. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12666 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12666 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org