https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41478 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |richard.bridgen@nhs.net -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41478 --- Comment #2 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 190623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190623&action=edit Bug 41478: Refactor: Readability + Never nester 1) Install the following dummy backend plugin: https://github.com/openfifth/koha-ill-backend-plugin/releases/tag/v2.0.8 2) Sys prefs preparation: Enable ILLModule, ILLOpacUnauthenticatedRequest and check PluginBackend on AutoILLBackendPriority 3) Logout, create a new Unauthenticated ILL request on the OPAC, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=create&backend=Standard 4) Fill in the mandatory top fields (first name, last name, email address and library) 5) Pick 'Book' for type and enter 'green' in title. This will cause the dummy plugin to be available in the AutoILL logic. 6) At the bottom of the form, on the "Verification" captcha, purposely input a wrong captcha e.g. '123' 7) Click 'Create'. Notice an odd looking form is presented, this is the dummy backend form, but it should present the 'Standard' form when using AutoILLBackendPriority as that was also the form we were presented with originally. This happens because currently it's the backend that delegates back to Koha what template to render. When using AutoILLBackendPriority, however, Koha should handle this template delegation instead and present the Standard form. 8) Apply patches. Repeat test plan. Notice that now on step 7 you get the correct form, and error message (coming from Standard, as expected when using AutoILLBackendPriority). 9) Input the correct captcha this time 10) Confirm the created request landed in the PluginBackend backend. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41478 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190623|0 |1 is obsolete| | --- Comment #4 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 190891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190891&action=edit Bug 41478: Refactor: Readability + Never nester 1) Install the following dummy backend plugin: https://github.com/openfifth/koha-ill-backend-plugin/releases/tag/v2.0.9 2) Sys prefs preparation: Enable ILLModule, ILLOpacUnauthenticatedRequest and check PluginBackend on AutoILLBackendPriority 3) Logout, create a new Unauthenticated ILL request on the OPAC, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=create&backend=Standard 4) Fill in the mandatory top fields (first name, last name, email address and library) 5) Pick 'Book' for type and enter 'green' in title. This will cause the dummy plugin to be available in the AutoILL logic. 6) At the bottom of the form, on the "Verification" captcha, purposely input a wrong captcha e.g. '123' 7) Click 'Create'. Notice an odd looking form is presented, this is the dummy backend form, but it should present the 'Standard' form when using AutoILLBackendPriority as that was also the form we were presented with originally. This happens because currently it's the backend that delegates back to Koha what template to render. When using AutoILLBackendPriority, however, Koha should handle this template delegation instead and present the Standard form. 8) Apply patches. Repeat test plan. Notice that now on step 7 you get the correct form, and error message (coming from Standard, as expected when using AutoILLBackendPriority). 9) Input the correct captcha this time 10) Confirm the created request landed in the PluginBackend backend. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41478 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41478 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190891|0 |1 is obsolete| | --- Comment #6 from David Nind <david@davidnind.com> --- Created attachment 190948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=190948&action=edit Bug 41478: Refactor: Readability + Never nester 1) Install the following dummy backend plugin: https://github.com/openfifth/koha-ill-backend-plugin/releases/tag/v2.0.9 2) Sys prefs preparation: Enable ILLModule, ILLOpacUnauthenticatedRequest and check PluginBackend on AutoILLBackendPriority 3) Logout, create a new Unauthenticated ILL request on the OPAC, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=create&backend=Standard 4) Fill in the mandatory top fields (first name, last name, email address and library) 5) Pick 'Book' for type and enter 'green' in title. This will cause the dummy plugin to be available in the AutoILL logic. 6) At the bottom of the form, on the "Verification" captcha, purposely input a wrong captcha e.g. '123' 7) Click 'Create'. Notice an odd looking form is presented, this is the dummy backend form, but it should present the 'Standard' form when using AutoILLBackendPriority as that was also the form we were presented with originally. This happens because currently it's the backend that delegates back to Koha what template to render. When using AutoILLBackendPriority, however, Koha should handle this template delegation instead and present the Standard form. 8) Apply patches. Repeat test plan. Notice that now on step 7 you get the correct form, and error message (coming from Standard, as expected when using AutoILLBackendPriority). 9) Input the correct captcha this time 10) Confirm the created request landed in the PluginBackend backend. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41478 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m --- Comment #7 from Lisette Scheer <lisette@bywatersolutions.com> --- Worked as expected and all tests passed. The plugin sets all to type journal article, but it appears to be part of the plugin, just testing notes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41478 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #190948|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41478 --- Comment #9 from Lisette Scheer <lisette@bywatersolutions.com> --- Created attachment 192153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=192153&action=edit Bug 41478: Refactor: Readability + Never nester 1) Install the following dummy backend plugin: https://github.com/openfifth/koha-ill-backend-plugin/releases/tag/v2.0.9 2) Sys prefs preparation: Enable ILLModule, ILLOpacUnauthenticatedRequest and check PluginBackend on AutoILLBackendPriority 3) Logout, create a new Unauthenticated ILL request on the OPAC, visit: <opac_url>/cgi-bin/koha/opac-illrequests.pl?op=create&backend=Standard 4) Fill in the mandatory top fields (first name, last name, email address and library) 5) Pick 'Book' for type and enter 'green' in title. This will cause the dummy plugin to be available in the AutoILL logic. 6) At the bottom of the form, on the "Verification" captcha, purposely input a wrong captcha e.g. '123' 7) Click 'Create'. Notice an odd looking form is presented, this is the dummy backend form, but it should present the 'Standard' form when using AutoILLBackendPriority as that was also the form we were presented with originally. This happens because currently it's the backend that delegates back to Koha what template to render. When using AutoILLBackendPriority, however, Koha should handle this template delegation instead and present the Standard form. 8) Apply patches. Repeat test plan. Notice that now on step 7 you get the correct form, and error message (coming from Standard, as expected when using AutoILLBackendPriority). 9) Input the correct captcha this time 10) Confirm the created request landed in the PluginBackend backend. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41478 --- Comment #10 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 26.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41478 --- Comment #11 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- Thanks all, pushed to 25.11.x -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41478 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|26.05.00,25.11.03 |26.05.00,25.11.03,25.05.09 released in| | Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41478 Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting CC| |baptiste.wojtkowski@biblibr | |e.com --- Comment #13 from Baptiste Wojtkowski (bwoj) <baptiste.wojtkowski@biblibre.com> --- The functionnality has been introduced in 25.05, won't be backported -- You are receiving this mail because: You are watching all bug changes.