[Bug 15068] New: Get rid of warnings in members/summary-print.pl
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068 Bug ID: 15068 Summary: Get rid of warnings in members/summary-print.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org Printing a summary from a member's detail page can result in a lot of warnings like: - use of uninitialized value in sprintf at /usr/share/kohaclone/members/summary-print.pl line 47 - Use of uninitialized value $roadtype in concatenation (.) or string at /usr/share/kohaclone/members/summary-print.pl line 61 - Use of uninitialized value in addition (+) at /usr/share/kohaclone/members/summary-print.pl line 87 - Argument "2015-11-03 23:59:00" isn't numeric in numeric comparison (<=>) at /usr/share/kohaclone/members/summary-print.pl line 103 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 44062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44062&action=edit Bug 15068 - Get rid of warnings in members/summary-print.pl This patch removes warnings when printing a summary from a member's detail page, like: - use of uninitialized value in sprintf at /usr/share/kohaclone/members/summary-print.pl line 47 - Use of uninitialized value $roadtype in concatenation (.) or string at /usr/share/kohaclone/members/summary-print.pl line 61 - Use of uninitialized value in addition (+) at /usr/share/kohaclone/members/summary-print.pl line 87 - Argument "2015-11-03 23:59:00" isn't numeric in numeric comparison (<=>) at /usr/share/kohaclone/members/summary-print.pl line 103 To test: - Apply patch - Go to a detail page with a member who has a lot of fines - Print summary - Verify that warnings like the ones above do no longer appear. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14483 Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|gmcharlt@gmail.com |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia@hotmail.com --- Comment #2 from Marc Véron <veron@veron.ch> --- *** Bug 14483 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Marc Véron from comment #1)
- Use of uninitialized value in addition (+) at /usr/share/kohaclone/members/summary-print.pl line 87
- Argument "2015-11-03 23:59:00" isn't numeric in numeric comparison (<=>) at /usr/share/kohaclone/members/summary-print.pl line 103
...
- Go to a detail page with a member who has a lot of fines ... And items checked out, potentially overdue.
Triggering 47 and 61 is easy with the sample data after creating some fines on a user. Having difficulty triggering 87, which I feel will also trigger 103, if I have something checked out, but working on multiple bugs at once is hard. :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068 --- Comment #4 from Marc Véron <veron@veron.ch> --- (In reply to M. Tompsett from comment #3)
(In reply to Marc Véron from comment #1)
- Use of uninitialized value in addition (+) at /usr/share/kohaclone/members/summary-print.pl line 87
- Argument "2015-11-03 23:59:00" isn't numeric in numeric comparison (<=>) at /usr/share/kohaclone/members/summary-print.pl line 103
...
- Go to a detail page with a member who has a lot of fines ... And items checked out, potentially overdue.
Triggering 47 and 61 is easy with the sample data after creating some fines on a user. Having difficulty triggering 87, which I feel will also trigger 103, if I have something checked out, but working on multiple bugs at once is hard. :)
- 87 is due to items with no replacementprice (NULL in db) - 103 triggers with multiple checkouts with due dates -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44062|0 |1 is obsolete| | --- Comment #5 from Frédéric Demians <frederic@tamil.fr> --- Created attachment 44322 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44322&action=edit Bug 15068 - Get rid of warnings in members/summary-print.pl This patch removes warnings when printing a summary from a member's detail page, like: - use of uninitialized value in sprintf at /usr/share/kohaclone/members/summary-print.pl line 47 - Use of uninitialized value $roadtype in concatenation (.) or string at /usr/share/kohaclone/members/summary-print.pl line 61 - Use of uninitialized value in addition (+) at /usr/share/kohaclone/members/summary-print.pl line 87 - Argument "2015-11-03 23:59:00" isn't numeric in numeric comparison (<=>) at /usr/share/kohaclone/members/summary-print.pl line 103 To test: - Apply patch - Go to a detail page with a member who has a lot of fines - Print summary - Verify that warnings like the ones above do no longer appear. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Have been able to see those warnings in Apache log file, and notice their disappearance after applying this patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #44322|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 44350 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44350&action=edit [PASSED QA] Bug 15068 - Get rid of warnings in members/summary-print.pl This patch removes warnings when printing a summary from a member's detail page, like: - use of uninitialized value in sprintf at /usr/share/kohaclone/members/summary-print.pl line 47 - Use of uninitialized value $roadtype in concatenation (.) or string at /usr/share/kohaclone/members/summary-print.pl line 61 - Use of uninitialized value in addition (+) at /usr/share/kohaclone/members/summary-print.pl line 87 - Argument "2015-11-03 23:59:00" isn't numeric in numeric comparison (<=>) at /usr/share/kohaclone/members/summary-print.pl line 103 To test: - Apply patch - Go to a detail page with a member who has a lot of fines - Print summary - Verify that warnings like the ones above do no longer appear. Signed-off-by: Frederic Demians <f.demians@tamil.fr> Have been able to see those warnings in Apache log file, and notice their disappearance after applying this patch. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Marc! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #8 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15068 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz Status|Pushed to Master |Pushed to Stable --- Comment #9 from Liz Rea <liz@catalyst.net.nz> --- Pushed to 3.18.13, and released. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org