[Bug 12574] New: BiblioDefaultView doesn't affect XSLT results view
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12574 Bug ID: 12574 Summary: BiblioDefaultView doesn't affect XSLT results view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org The OPAC XSLT results view needs to be updated to use the BiblioDefaultView system preference. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12574 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12574 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 29684 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29684&action=edit Bug 12574 - BiblioDefaultView doesn't affect XSLT results view The OPAC's XSLT results view does not respect the choice set in the BiblioDefaultView system preference. This patch adds a check of the preference to the OPAC's results view for MARC21. To test you must have the OPAC configured to use the XSLT view for search results. Perform any search and test the link to a title's detail page. Switching the values of the BiblioDefaultView should be correctly reflected in the search results links. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12574 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12561 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12574 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |cbrannon@cdalibrary.org --- Comment #2 from Christopher Brannon <cbrannon@cdalibrary.org> --- Owen, Unless there is some aspect of this feature I am not setting right or that doesn't work in sandbox, I am not seeing any difference with the patch applied. I set OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to default, and see that those are working. I have set BiblioDefaultView to "in their MARC form.", but it still defaults to normal view. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12574 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Could someone take another look at this? It works for me and I'm not sure what might be going wrong. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12574 --- Comment #4 from Christopher Brannon <cbrannon@cdalibrary.org> --- Owen, On the chance that I did something wrong in my testing, I tested again. Here is what I found: I found that I was refreshing my search after changing settings, and realized that the view was coded in the URL, so I wasn't going to see any changes. My fault. With today's test, I set OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to default, and see that those are working. I have set BiblioDefaultView to "in their MARC form.", an it works. This is just off a fresh installed master and without your patch installed. Please confirm the problem exists in master. Christopher -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12574 --- Comment #5 from Christopher Brannon <cbrannon@cdalibrary.org> --- Owen, Just tested again on a testbox, and I still see the master honoring the BiblioDefaultView setting, even when OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to default. Is it the results page or the details display that you are having an issue on? Does the bug affect only one or both? Christopher -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12574 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12574 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Christopher Brannon from comment #5)
Is it the results page or the details display that you are having an issue on? Does the bug affect only one or both?
The BiblioDefaultView preference has no affect on the detail display. The preference only affects *which* dteail display you'll get when you click a link to a title. The OPACXSLTDetailsDisplay is irrelevant here. The only page which requires testing is the OPAC's search results page. Are you saying that: - in master - with OPACXSLTResultsDisplay set to "default" - with BiblioDefaultView set to "in their MARC form" ...clicking on a title in OPAC search results takes you to opac-MARCdetail.pl? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12574 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12574 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29684|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 31330 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31330&action=edit [SIGNED OFF] Bug 12574 - BiblioDefaultView doesn't affect XSLT results view The OPAC's XSLT results view does not respect the choice set in the BiblioDefaultView system preference. This patch adds a check of the preference to the OPAC's results view for MARC21. To test you must have the OPAC configured to use the XSLT view for search results. Perform any search and test the link to a title's detail page. Switching the values of the BiblioDefaultView should be correctly reflected in the search results links. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Worked for me, search results did not respect setting before patch and did after applying -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12574 --- Comment #8 from Christopher Brannon <cbrannon@cdalibrary.org> ---
Are you saying that:
- in master - with OPACXSLTResultsDisplay set to "default" - with BiblioDefaultView set to "in their MARC form"
...clicking on a title in OPAC search results takes you to opac-MARCdetail.pl?
Yes. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12574 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12574 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31330|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 31448 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31448&action=edit [PASSED QA] Bug 12574 - BiblioDefaultView doesn't affect XSLT results view The OPAC's XSLT results view does not respect the choice set in the BiblioDefaultView system preference. This patch adds a check of the preference to the OPAC's results view for MARC21. To test you must have the OPAC configured to use the XSLT view for search results. Perform any search and test the link to a title's detail page. Switching the values of the BiblioDefaultView should be correctly reflected in the search results links. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described for XSLT view in OPAC. Notes: - maybe we should change the pref text from 'simple form' to 'normal view'. - the patch doesn't include changes to the title link generated from an 880 field - so those links will still lead to the wrong view. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12574 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Some notes: - maybe we should change the pref text from 'simple form' to 'normal view'. - the patch doesn't include changes to the title link generated from an 880 field - so those links will still lead to the wrong view. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12574 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12901 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12574 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12574 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14259 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org