[Bug 35936] New: Cannot save existing report with incorrect AV category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35936 Bug ID: 35936 Summary: Cannot save existing report with incorrect AV category Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Reports Assignee: jonathan.druart+koha@gmail.com Reporter: jonathan.druart+koha@gmail.com QA Contact: testopia@bugs.koha-community.org Depends on: 33966 When an existing report is saved and an incorrect AV category is selected, the UI is asking "do you want to save anyway", but the "Update SQL" button leads to a blank page and the report is not saved. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33966 [Bug 33966] "Update and run SQL" for non-English templates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35936 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 161626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=161626&action=edit Bug 35936: Fix saving existing report with incorrect AV category When an existing report is saved and an incorrect AV category is selected, the UI is asking "do you want to save anyway", but the "Update SQL" button leads to a blank page and the report is not saved. On bug 33966 the value is been adjust to 'update_sql' but this incorrect was left. To test you need to use the browser inspector to adjust the value of the selected option. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35936 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Passed QA --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Trivial, skipping SO and QA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35936 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is some small stuff adding up here, please follow-up! 1) sysprefs.sql FAIL installer/data/mysql/mandatory/sysprefs.sql FAIL sysprefs_order Not blocker: Sysprefs ShowBarcodeOnPatronRecord is bad placed (see bug 10610) Please fix, but also take a look at the SQL. I believe options and value are switched in sysprefs.sql: INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `type` ) VALUES ('ShowBarcodeOnPatronRecord','|0|Code39|COOP2of5|EAN13|EAN8|IATA2of5|Industrial2of5|ITF|Matrix2of5|NW7|QRcode|UPCA|UPCE','0','Show a patron\'s carnumber as a barcode on the patron record','Choice'), 2) .pref + - "Show a " + - pref: ShowBarcodeOnPatronRecord + default: no + choices: + 0: "Don't show" + Code39: "Code39" + COOP2of5: "COOP2of5" + EAN13: "EAN13" + EAN8: "EAN8" + IATA2of5: "IATA2of5" + Industrial2of5: "Industrial2of5" + ITF: "ITF" + Matrix2of5: "Matrix2of5" + NW7: "NW7" + QRcode: "QRcode" + UPCA: "UPCA" + UPCE: "UPCE" + - " barcode of the patron's card number in the sidebar of patron-related pages." The sentence here doesn't work: Show a [Don't show] barcode... Show a [QRcode] barcode... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35936 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sorry, wrong bug! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35936 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35936 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35936 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.03 released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35936 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org