[Bug 12581] New: /svc/bib endpoint has encoding issues when updating a record
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12581 Bug ID: 12581 Summary: /svc/bib endpoint has encoding issues when updating a record Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs@lists.koha-community.org Reporter: boutrosboutrosboutros@gmail.com QA Contact: testopia@bugs.koha-community.org Updating a record by sending a POST request with the MARCXML data Koha's /svc/bib endpoint can result in mangled characters in the saved record. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12581 --- Comment #1 from Petter Goksøyr Åsen <boutrosboutrosboutros@gmail.com> --- Created attachment 29732 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29732&action=edit Bug 12581 - Fix encoding issues in /svc/bib endpoint Updating a record by sending a POST request with the MARCXML data Koha's /svc/bib endpoint can result in mangled characters in the saved record. By contrast, the /svc/new_bib endpoint, for creating a new record, correctly fixes theese encoding issues. This patch replicates the fix from svc/new_bib to svc/bib. Test plan * Update a record by sending MARCXML to the /svc/bib endpoint. The record should contain non-latin characters, for example æ,ø, å. * Observe that the returned response, and the record in the database has mangled characters. * Apply the patch * Repeat the first step * Observe that the record now is free from encoding errors. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12581 Petter Goksøyr Åsen <boutrosboutrosboutros@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12581 Petter Goksøyr Åsen <boutrosboutrosboutros@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12581 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29732|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 30612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30612&action=edit Bug 12581 - Fix encoding issues in /svc/bib endpoint Updating a record by sending a POST request with the MARCXML data Koha's /svc/bib endpoint can result in mangled characters in the saved record. By contrast, the /svc/new_bib endpoint, for creating a new record, correctly fixes theese encoding issues. This patch replicates the fix from svc/new_bib to svc/bib. Test plan * Update a record by sending MARCXML to the /svc/bib endpoint. The record should contain non-latin characters, for example æ,ø, å. * Observe that the returned response, and the record in the database has mangled characters. * Apply the patch * Repeat the first step * Observe that the record now is free from encoding errors. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12581 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |chris@bigballofwax.co.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am making my first steps with the svc API and I managed to update a record using: curl 'http://localhost:8080/cgi-bin/koha/svc/bib/30' --cookie /tmp/svc.cookies --header "Content-type: text/xml" --data @/home/katrin/Downloads/bib-30.marcxml But I can't reproduce the encoding problem :( I tried with a record containing the characters listed in the patch and Arabic. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Some additional information: - I had downloaded the record from my Koha database. - I changed it in an editor, the changes were reflected in what I saw on command line and in Koha after the update. - All diacritics showed up correctly at all times. Could you please try again if the problem is still there for you and provide me with a test plan and an example record? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12581 Petter Goksøyr Åsen <boutrosboutrosboutros@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply --- Comment #5 from Petter Goksøyr Åsen <boutrosboutrosboutros@gmail.com> --- Hi Katrin, Thanks for QA! You're right. Somehow, it now mysteriously works for me too on master. I can't understand why. It must have been something weird with my environment, or else some changes in master which now resolved the issue. Either way, I'm happy to close this. The less code the better:) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12581 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WORKSFORME --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Petter, thx for retesting! Just changing the status a bit to imply that this patch isn't needed for now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org