[Bug 32244] New: We need to add vue (and cypress possibly) to the about page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 Bug ID: 32244 Summary: We need to add vue (and cypress possibly) to the about page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Depends on: 32030 Now we've introduced Vue in to our software stack, we need to add it to our `About > Licenses` page. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32030 [Bug 32030] Electronic resource management (ERM) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This will clearly be a string change... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jake.deery@ptfs-europe.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com, tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 Aman <amanpilgrim@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 --- Comment #2 from Aman <amanpilgrim@catalyst.net.nz> --- Created attachment 184267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184267&action=edit Bug 32244: Add vue to the about page To Test: 1. Apply the patch 2. Within staff client, click More > About > Licences tab 3. Scroll to the bottom to see Vue library url, version and licencing information -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 Aman <amanpilgrim@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |amanpilgrim@catalyst.net.nz |ity.org | CC| |amanpilgrim@catalyst.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 184279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184279&action=edit Bug 32244: Add Vue license information to the about page This patch updates the license page with information about Vue. Test plan: 1. Apply the patch. 2. In the staff interface, go to More > About > Licenses. 3. Scroll down to Vue and note the library name and licensing information. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 184280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184280&action=edit Bug 32244: Add Cypress license information to the about page This patch updates the license page with information about Cypress. Test plan: 1. Apply the patch. 2. In the staff interface, go to More > About > Licenses. 3. Scroll to Cypress and note the library name and licensing information. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Attachment #184267|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|We need to add vue (and |Add Vue and Cypress to the |cypress possibly) to the |About > Licenses page |about page | Text to go in the| |This adds Cypress and Vue release notes| |to the About Koha > | |Licenses page. --- Comment #5 from David Nind <david@davidnind.com> --- Thanks for the patch Aman! I've also added a patch for Cypress (I didn't include the version number), and amended the commit messages so that are consistent. I'm not sure about the license version for Vue - in the current main, node_modules/view/package.json says 3.5.13, rather than 3.5.4. I've also added a release note. David Nind -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #6 from Aleisha Amohia <aleisha@catalyst.net.nz> --- (In reply to David Nind from comment #5)
Thanks for the patch Aman!
I've also added a patch for Cypress (I didn't include the version number), and amended the commit messages so that are consistent.
Thanks!
I'm not sure about the license version for Vue - in the current main, node_modules/view/package.json says 3.5.13, rather than 3.5.4.
We got this from package.json under 'dependencies': "vue": "^3.5.4", But can see now the different version in node_modules/vue/package.json { "name": "vue", "version": "3.5.13", } Is there any guidance on which we should use?
I've also added a release note.
David Nind
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Aleisha Amohia from comment #6)
(In reply to David Nind from comment #5)
I'm not sure about the license version for Vue - in the current main, node_modules/view/package.json says 3.5.13, rather than 3.5.4.
We got this from package.json under 'dependencies':
"vue": "^3.5.4",
But can see now the different version in node_modules/vue/package.json
{ "name": "vue", "version": "3.5.13", }
Is there any guidance on which we should use?
^3.5.4 means minimum 3.5.4. Then 3.5.13 is the version we are using, which will certainly change soon. You should not use the exact version but "VueJS 3" instead I would say. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 --- Comment #8 from David Nind <david@davidnind.com> --- Created attachment 184499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184499&action=edit Bug 32244: (follow-up) Update Vue.js version and terminology Update to show license version as v3, instead of the specific minor and point release. Update license to use US American spelling. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |40468 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40468 [Bug 40468] Terminology on the About > Licenses page - use US American spelling for license -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add Vue and Cypress to the |Add Vue and Cypress to the |About > Licenses page |About Koha > Licenses page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184279|0 |1 is obsolete| | --- Comment #9 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 184900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184900&action=edit Bug 32244: Add Vue license information to the about page This patch updates the license page with information about Vue. Test plan: 1. Apply the patch. 2. In the staff interface, go to More > About > Licenses. 3. Scroll down to Vue and note the library name and licensing information. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184280|0 |1 is obsolete| | --- Comment #10 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 184901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184901&action=edit Bug 32244: Add Cypress license information to the about page This patch updates the license page with information about Cypress. Test plan: 1. Apply the patch. 2. In the staff interface, go to More > About > Licenses. 3. Scroll to Cypress and note the library name and licensing information. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184499|0 |1 is obsolete| | --- Comment #11 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 184902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184902&action=edit Bug 32244: (follow-up) Update Vue.js version and terminology Update to show license version as v3, instead of the specific minor and point release. Update license to use US American spelling. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 --- Comment #12 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 184904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184904&action=edit Bug 32244: (QA follow-up) Fixed html formatting and added link for Cypress -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |blawlor@clamsnet.org |y.org | CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 --- Comment #14 from David Nind <david@davidnind.com> --- Thanks Brendan for the QA follow-up! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 --- Comment #15 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #16 from Fridolin Somers <fridolin.somers@biblibre.com> --- Does not apply easy on 24.11.x, lets skip -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32244 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED --- Comment #17 from David Nind <david@davidnind.com> --- No changes to the manual required. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org