http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 --- Comment #4 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 33918 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33918 Bug 1985 - Email notification of new OPAC comments Review of attachment 33918: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=1985&attachment=33918) ----------------------------------------------------------------- ::: C4/Review.pm @@ +81,4 @@

(?,?,?,0,now())"; my $sth = $dbh->prepare($query); $sth->execute( $borrowernumber, $biblionumber, $review); +

I hope this isn't white space. Please consider: git config --global core.whitespace trailing-space,space-before-tab git config --global apply.whitespace fix @@ +203,5 @@

+ my $borrowernumber = shift; + + my $moderatorEmail = C4::Context->preference('CommentModeratorsEmail'); + if (not($moderatorEmail)) { + return undef;

I think this will fail the koha qa tests. No need to be explicit with the undef; -- You are receiving this mail because: You are watching all bug changes.