[Bug 31627] New: Add ability to embed the letter id in outgoing email notices
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Bug ID: 31627 Summary: Add ability to embed the letter id in outgoing email notices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org It can be useful to know exactly what template was used to generate a notice. To further this end, it would be useful be able to send the letter id as part of any emails sent out if there is a letter template associated with the message. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31626 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31626 [Bug 31626] Add letter id to the message queue table -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 140998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140998&action=edit Bug 31627: Add ability to embed the letter id in outgoing email notices It can be useful to know exactly what template was used to generate a notice. To further this end, it would be useful be able to send the letter id as part of any emails sent out if there is a letter template associated with the message. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Enable SendLetterIdInEmailNotices 4) Generate an email notice like a checkout notice 5) Note your email has the letter id at the bottom! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewfh@dubcolib.org --- Comment #2 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Either this isn't working or I'm not understanding the intent. Should I be seeing the letter_code appended to the content of the notice? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- In the database you've called the system preference 'SendLetterIdInEmailNotices'. But when you check in in C4/Letters.pm it is looking for 'SendLetterIdNotices'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 --- Comment #4 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Lucas Gass from comment #3)
In the database you've called the system preference 'SendLetterIdInEmailNotices'.
But when you check in in C4/Letters.pm it is looking for 'SendLetterIdNotices'.
Good catch Lucas! I'll get that fixed asap. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #140998|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 141025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=141025&action=edit Bug 31627: Add ability to embed the letter id in outgoing email notices It can be useful to know exactly what template was used to generate a notice. To further this end, it would be useful be able to send the letter id as part of any emails sent out if there is a letter template associated with the message. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Enable SendLetterIdInEmailNotices 4) Generate an email notice like a checkout notice 5) Note your email has the letter id at the bottom! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | Summary|Add ability to embed the |Add ability to embed the |letter id in outgoing email |letter ID in outgoing email |notices |notices --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Please don't forget to set Assignee, thx! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david@davidnind.com --- Comment #7 from David Nind <david@davidnind.com> --- Can't apply the patch: ... Applying: Bug 31627: Add ability to embed the letter id in outgoing email notices error: sha1 information is lacking or useless (C4/Letters.pm). error: could not build fake ancestor Patch failed at 0001 Bug 31627: Add ability to embed the letter id in outgoing email notices .. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #141025|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142826&action=edit Bug 31627: Add ability to embed the letter id in outgoing email notices It can be useful to know exactly what template was used to generate a notice. To further this end, it would be useful be able to send the letter id as part of any emails sent out if there is a letter template associated with the message. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Enable SendLetterIdInEmailNotices 4) Generate an email notice like a checkout notice 5) Note your email has the letter id at the bottom! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 --- Comment #9 from David Nind <david@davidnind.com> --- I'm not seeing the letter id in the message - either in the preview of the notice (Patron account > Notices) or in the message_queue. Am I missing something from my setup? Initially, I thought the letter id would show up in the preview for patron's notices. Here is what I did when testing using koha-testing-docker (KTD): 1. Applied the patch 2. Ran updatedatabase 3. Ran flush_memcached and restart_all 4. Enable SendLetterIdInEmailNotices 5. Setup so email could be sent in KTD using Gmail [1] 6. Added Gmail address to patron 7. Set up the patron messaging preferences so that the email option is selected for item check-in and item checkout 8. Checked out an item to the patron 9. Preview of notice is available under Patron account > Notices - no letter id/or code 10. Checked what was in the database: select * from message_queue; 11. Processed the message queue: misc/cronjobs/process_message_queue.pl -v 12. No letter id in message received in mny inbox [1] To setup KTD so that an email message can be sent using Gmail, add this to /etc/koha/sites/kohadev/koha-conf.xml (where an app password is created for a Gmail account and GMAILEMAILADDRESS and APPPASSWORD replaced as appropriate): <smtp_server> <host>smtp.gmail.com</host> <port>587</port> <timeout>5</timeout> <ssl_mode>STARTTLS</ssl_mode> <user_name>GMAILEMAILADDRESS</user_name> <password>APPPASSWORD</password> <debug>1</debug> </smtp_server> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I wonder if it would be nice to have a way to make this invisible at least in HTML notices. Something like <div style="display:none">ID</div> ? This line looks like it would allow to do just that: if ($is_html) { + $content .= "<br/>$message->{letter_id}" if $message->{id} && C4::Context->preference('SendLetterIdInEmailNotices'); At the moment there is no way libraries could change how this appears in the notices and it might raise questions about the 'number' appearing at the end of the message. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #10)
I wonder if it would be nice to have a way to make this invisible at least in HTML notices. Something like <div style="display:none">ID</div> ?
This line looks like it would allow to do just that: if ($is_html) { + $content .= "<br/>$message->{letter_id}" if $message->{id} && C4::Context->preference('SendLetterIdInEmailNotices');
At the moment there is no way libraries could change how this appears in the notices and it might raise questions about the 'number' appearing at the end of the message.
Sounds good! I'll post a followup for that! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 143022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143022&action=edit Bug 31627: (followup) Hide id for HTML messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- I've tried this in KTD and on a sandbox and am not seeing a letter id added to notices as they're generated. Should it be present as soon as the notice is generated? Or does it get added when the notice is sent? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #13)
I've tried this in KTD and on a sandbox and am not seeing a letter id added to notices as they're generated. Should it be present as soon as the notice is generated? Or does it get added when the notice is sent?
It is not present in the generated notice, only in the outgoing email. This is necessary due to the way some notices are built. To test this you'll need to send an actual email and look the email contents. If the email is HTML based, you'll need to look at the HTML source. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Bug 31627 depends on bug 31626, which changed state. Bug 31626 Summary: Add letter ID to the message queue table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31626 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142826|0 |1 is obsolete| | --- Comment #15 from Sam Lau <samalau@gmail.com> --- Created attachment 151536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151536&action=edit Bug 31627: Add ability to embed the letter id in outgoing email notices It can be useful to know exactly what template was used to generate a notice. To further this end, it would be useful be able to send the letter id as part of any emails sent out if there is a letter template associated with the message. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Enable SendLetterIdInEmailNotices 4) Generate an email notice like a checkout notice 5) Note your email has the letter id at the bottom! Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Sam Lau <samalau@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143022|0 |1 is obsolete| | --- Comment #16 from Sam Lau <samalau@gmail.com> --- Created attachment 151537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=151537&action=edit Bug 31627: (followup) Hide id for HTML messages Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #17 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- WARN C4/Letters.pm OK critic OK forbidden patterns OK git manipulation OK pod OK pod coverage SKIP spelling WARN tidiness The file is less tidy than before (bad/messy lines before: 394, now: 396) OK valid WARN installer/data/mysql/atomicupdate/bug_31627.pl OK critic OK file permissions OK forbidden patterns OK git manipulation OK pod SKIP spelling WARN tidiness The file is less tidy than before (bad/messy lines before: 0, now: 5) OK valid OK installer/data/mysql/mandatory/sysprefs.sql OK git manipulation OK semicolon OK sysprefs_order Processing additional checks * Commit title does not contain 'follow-up' correctly spelt - 17c2012171 Will have a look, dont worry -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #18 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- The HTML solution is fine. But we do not have a counterpart for the plain text notice. It is a bit weird to do this. And referring to 'it is useful to know' from the description, it might be useful for QA to know what the use case is here exactly before getting this further. Please clarify a bit more. Changing status for feedback. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 155364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=155364&action=edit Bug 31627: (follow-up) Hide id for HTML messages Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151537|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'd actually be tempted to put this in the email headers somehow instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #151536|0 |1 is obsolete| | Attachment #155364|0 |1 is obsolete| | --- Comment #21 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 166374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166374&action=edit Bug 31627: Add ability to embed the letter id in outgoing email notices It can be useful to know exactly what template was used to generate a notice. To further this end, it would be useful be able to send the letter id as part of any emails sent out if there is a letter template associated with the message. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Enable SendLetterIdInEmailNotices 4) Generate an email notice like a checkout notice 5) Note your email has the letter id at the bottom! Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 166375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166375&action=edit Bug 31627: (follow-up) Hide id for HTML messages Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 166376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166376&action=edit Bug 31627: Send id in an email header -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 --- Comment #24 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #20)
I'd actually be tempted to put this in the email headers somehow instead.
Done! Should we remove the syspref altogether with this change? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 --- Comment #25 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 166377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166377&action=edit Bug 31627: Send message id in email header as well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 166378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166378&action=edit Bug 31627: Remove new syspref SendLetterIdInEmailNotices -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166374|0 |1 is obsolete| | Attachment #166375|0 |1 is obsolete| | Attachment #166376|0 |1 is obsolete| | Attachment #166377|0 |1 is obsolete| | Attachment #166378|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 166379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166379&action=edit Bug 31627: Add ability to embed the letter id in outgoing email notices It can be useful to know exactly what template was used to generate a notice. To further this end, it would be useful be able to send the letter id as part of any emails sent out if there is a letter template associated with the message. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Generate an email notice like a checkout notice 4) Inspect the email headers, note the new X-Koha-Letter-Id and X-Koha-Message-Id headers! Signed-off-by: Sam Lau <samalau@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|m.de.rooy@rijksmuseum.nl |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #166379|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166399&action=edit Bug 31627: Add ability to embed the letter id in outgoing email notices It can be useful to know exactly what template was used to generate a notice. To further this end, it would be useful be able to send the letter id as part of any emails sent out if there is a letter template associated with the message. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Generate an email notice like a checkout notice 4) Inspect the email headers, note the new X-Koha-Template-Id and X-Koha-Message-Id headers! Signed-off-by: Sam Lau <samalau@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166400&action=edit Bug 31627: (QA follow-up) Catch more locations This patch moves the header set into Koha::Email->create and passes the template_id in a few additional locations to ensure we catch more cases. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 166401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=166401&action=edit Bug 31627: (QA follow-up) Tidy test block -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 --- Comment #31 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The use case is that it makes it significantly simpler to trace mail output issues for staff.. you can now inspect the message headers and find the template used to generate the notice or the message in the message queue. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Updated -Id to -ID in a follow-up! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds two release notes| |new email headers to notice | |sent by Koha. | | | |`X-Koha-Template-ID` to | |contain the ID of the | |template used to generate | |the notice and | |`X-Koha-Message-ID` to | |contain the ID of the | |specific message as defined | |by Koha. | | | |This allows staff | |to easily trace issues with | |message content back to | |their source. Headers are | |not displayed to end users | |by default, but are easily | |accessible to support | |staff. | | | |**Sponsored by** | |*ByWater Solutions* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds two |This enhancement adds two release notes|new email headers to notice |new email headers to |sent by Koha. |notices sent by Koha. | | |`X-Koha-Template-ID` to |`X-Koha-Template-ID` to |contain the ID of the |contain the ID of the |template used to generate |template used to generate |the notice and |the notice, and |`X-Koha-Message-ID` to |`X-Koha-Message-ID` to |contain the ID of the |contain the ID of the |specific message as defined |specific message as defined |by Koha. |by Koha. | | |This allows staff |This allows staff |to easily trace issues with |to easily trace issues with |message content back to |message content back to |their source. Headers are |their source. Headers are |not displayed to end users |not displayed to end users |by default, but are easily |by default, but are easily |accessible to support |accessible to support |staff. |staff. | | |**Sponsored by** |**Sponsored by** |*ByWater Solutions* |*ByWater Solutions* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Philip Orr <philip.orr@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |philip.orr@lmscloud.de Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #34 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31627 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org