[Bug 18213] New: Add language facets to Elasticsearch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Bug ID: 18213 Summary: Add language facets to Elasticsearch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt@gmail.com Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|gmcharlt@gmail.com |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18235 CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Would be good to make it on top of bug 18235. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Depends on| |18235 Status|NEW |Needs Signoff Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 [Bug 18235] Elastic search - Configurable facets -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 64798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64798&action=edit Bug 18213 - Add language facets to Elasticsearch This patch add language as a facet to ES results - it adds a new template plugin for languages to get the appropriate description given an iso 639-2 code To test: 1 - Make sure you have records with differing languages (in the MARC21 008 field characters 35-37 or UNIMARC 101a) 2 - Apply patch 3 - Reload Elasticsearch settings: http://localhost:8081/cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1 4 - Reindex your records 5 - Search for a phrase that will return results in several languages 6 - Verify you see factes correctly labelled for 'Language' 7 - Verify the facets work 8 - Verify both opac and staff results 9 - prove t/db_dependent/Languages.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 64841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64841&action=edit Bug 18213 - DB Update (facet order) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 64905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64905&action=edit Bug 18213 - Add Template plugin and fix for C4/Languages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com QA Contact|testopia@bugs.koha-communit | |y.org | Component|Searching |Searching - Elasticsearch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 David Bourgault <david.bourgault@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |david.bourgault@inlibro.com --- Comment #5 from David Bourgault <david.bourgault@inlibro.com> --- Does not apply. fatal: sha1 information is lacking or useless (Koha/SearchEngine/Elasticsearch.pm). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64798|0 |1 is obsolete| | Attachment #64841|0 |1 is obsolete| | Attachment #64905|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 68944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68944&action=edit Bug 18213 - Add language facets to Elasticsearch This patch add language as a facet to ES results - it adds a new template plugin for languages to get the appropriate description given an iso 639-2 code To test: 1 - Make sure you have records with differing languages (in the MARC21 008 field characters 35-37 or UNIMARC 101a) 2 - Apply patch 3 - Reload Elasticsearch settings: http://localhost:8081/cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1 4 - Reindex your records 5 - Search for a phrase that will return results in several languages 6 - Verify you see factes correctly labelled for 'Language' 7 - Verify the facets work 8 - Verify both opac and staff results 9 - prove t/db_dependent/Languages.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 --- Comment #7 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 68945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68945&action=edit Bug 18213 - DB Update (facet order) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 68946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68946&action=edit Bug 18213 - Add Template plugin and fix for C4/Languages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.legrand@bulac.fr Status|Needs Signoff |Patch doesn't apply --- Comment #9 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- I don't dare to rebase it myself ^^ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68944|0 |1 is obsolete| | Attachment #68945|0 |1 is obsolete| | Attachment #68946|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72940&action=edit Bug 18213 - Add language facets to Elasticsearch This patch add language as a facet to ES results - it adds a new template plugin for languages to get the appropriate description given an iso 639-2 code To test: 1 - Make sure you have records with differing languages (in the MARC21 008 field characters 35-37 or UNIMARC 101a) 2 - Apply patch 3 - Reload Elasticsearch settings: http://localhost:8081/cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1 4 - Reindex your records 5 - Search for a phrase that will return results in several languages 6 - Verify you see factes correctly labelled for 'Language' 7 - Verify the facets work 8 - Verify both opac and staff results 9 - prove t/db_dependent/Languages.t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72941&action=edit Bug 18213 - DB Update (facet order) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72942&action=edit Bug 18213 - Add Template plugin and fix for C4/Languages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 72943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72943&action=edit Bug 18213: (follow-up) Correctly sort facets Previously we sorted alphabetically - that works for 1-9. With a 10th facet category we should sort numerically -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72940|0 |1 is obsolete| | --- Comment #14 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 73008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73008&action=edit Bug 18213 - Add language facets to Elasticsearch This patch add language as a facet to ES results - it adds a new template plugin for languages to get the appropriate description given an iso 639-2 code To test: 1 - Make sure you have records with differing languages (in the MARC21 008 field characters 35-37 or UNIMARC 101a) 2 - Apply patch 3 - Reload Elasticsearch settings: http://localhost:8081/cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1 4 - Reindex your records 5 - Search for a phrase that will return results in several languages 6 - Verify you see factes correctly labelled for 'Language' 7 - Verify the facets work 8 - Verify both opac and staff results 9 - prove t/db_dependent/Languages.t Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72941|0 |1 is obsolete| | --- Comment #15 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 73009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73009&action=edit Bug 18213 - DB Update (facet order) Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72942|0 |1 is obsolete| | --- Comment #16 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 73010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73010&action=edit Bug 18213 - Add Template plugin and fix for C4/Languages Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72943|0 |1 is obsolete| | --- Comment #17 from Nicolas Legrand <nicolas.legrand@bulac.fr> --- Created attachment 73011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73011&action=edit Bug 18213: (follow-up) Correctly sort facets Previously we sorted alphabetically - that works for 1-9. With a 10th facet category we should sort numerically Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73008|0 |1 is obsolete| | --- Comment #18 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 75971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75971&action=edit Bug 18213 - Add language facets to Elasticsearch This patch add language as a facet to ES results - it adds a new template plugin for languages to get the appropriate description given an iso 639-2 code To test: 1 - Make sure you have records with differing languages (in the MARC21 008 field characters 35-37 or UNIMARC 101a) 2 - Apply patch 3 - Reload Elasticsearch settings: http://localhost:8081/cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1 4 - Reindex your records 5 - Search for a phrase that will return results in several languages 6 - Verify you see factes correctly labelled for 'Language' 7 - Verify the facets work 8 - Verify both opac and staff results 9 - prove t/db_dependent/Languages.t Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73009|0 |1 is obsolete| | --- Comment #19 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 75972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75972&action=edit Bug 18213 - DB Update (facet order) Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73010|0 |1 is obsolete| | --- Comment #20 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 75973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75973&action=edit Bug 18213 - Add Template plugin and fix for C4/Languages Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73011|0 |1 is obsolete| | --- Comment #21 from Alex Arnaud <alex.arnaud@biblibre.com> --- Created attachment 75974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75974&action=edit Bug 18213: (follow-up) Correctly sort facets Previously we sorted alphabetically - that works for 1-9. With a 10th facet category we should sort numerically Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Alex Arnaud <alex.arnaud@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |alex.arnaud@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com Status|BLOCKED |Signed Off --- Comment #22 from Josef Moravec <josef.moravec@gmail.com> --- dependency bug 18235 passed qa, setting this back to signed off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75971|0 |1 is obsolete| | Attachment #75972|0 |1 is obsolete| | Attachment #75973|0 |1 is obsolete| | Attachment #75974|0 |1 is obsolete| | --- Comment #23 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85998&action=edit Bug 18213: Add language facets to Elasticsearch This patch add language as a facet to ES results - it adds a new template plugin for languages to get the appropriate description given an iso 639-2 code To test: 1 - Make sure you have records with differing languages (in the MARC21 008 field characters 35-37 or UNIMARC 101a) 2 - Apply patch 3 - Reload Elasticsearch settings: http://localhost:8081/cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1 4 - Reindex your records 5 - Search for a phrase that will return results in several languages 6 - Verify you see factes correctly labelled for 'Language' 7 - Verify the facets work 8 - Verify both opac and staff results 9 - prove t/db_dependent/Languages.t Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 --- Comment #24 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 85999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85999&action=edit Bug 18213: DB Update (facet order) Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 --- Comment #25 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86000&action=edit Bug 18213: Add Template plugin and fix for C4/Languages Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 --- Comment #26 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86001&action=edit Bug 18213: (follow-up) Correctly sort facets Previously we sorted alphabetically - that works for 1-9. With a 10th facet category we should sort numerically Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr> Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22449 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22449 [Bug 22449] Improve Elastic search facet setting UI -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #27 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Bug 18213 depends on bug 18235, which changed state. Bug 18235 Summary: Elastic search - Configurable facets https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #29 from Frédéric Demians <frederic@tamil.fr> --- There is somehow a regression with ES language facets compared to Zebra facets. Zebra language facet is decoded from LANG authorized values list. ES language facet (thanks to this patch) is decoded from language_* tables. But there are more languages defined in LANG authorized values list: all old languages for example, like grc = Ancient Greek (to 1453). Solution : add missing languages to language_* tables. But is it the purpose of those tables which are designed to allow Koha interface translation rather than storing MARC biblio records usable languages? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Frédéric Demians from comment #29)
There is somehow a regression with ES language facets compared to Zebra facets. Zebra language facet is decoded from LANG authorized values list. ES language facet (thanks to this patch) is decoded from language_* tables. But there are more languages defined in LANG authorized values list: all old languages for example, like grc = Ancient Greek (to 1453).
Solution : add missing languages to language_* tables. But is it the purpose of those tables which are designed to allow Koha interface translation rather than storing MARC biblio records usable languages?
Afaik they are used to build the list of languages on advanced search and also the language options when you have different langaugaes installed. The big win of the tables currently is that they are transalatable/offer the language name in the language of the language (hope that makes sense). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- That said - are you sure the langauge facet is in standard Koha for Zebra? I don't see a definition for it in getfacets. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 M <schodkowy.omegi-0r@icloud.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36437 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org