[Bug 30107] New: When editing a desk, the currently logged in library is selected
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107 Bug ID: 30107 Summary: When editing a desk, the currently logged in library is selected Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com Instead of showing the library the desk was added to, on editing a desk, it always shows the library the user is currently logged in as preselected. Requires UseCirculationDesks to be activated. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 130699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=130699&action=edit Bug 30107: When editing desks default to the branch the desk belongs to TO test: 1. Turn on UseCirculationDesks 2. Add some desks via Administration > Circulation desks, make several and have them belong to different libraries. 3. Go edit some of those desks and notice the Library: dropdown always defaults to the users logged in branch 4. Apply patch 5. Try editing desk again, now the dropdown should default the library that the desk belongs to. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch CC| |lucas@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | Text to go in the| |Corrects a problem on the release notes| |Circulation desk page where | |the default library was | |always being set to the | |logged in location instead | |of the location of the | |desk. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Corrects a problem on the |Corrects a problem on the release notes|Circulation desk page where |Circulation desk page where |the default library was |the default library was |always being set to the |always being set to the |logged in location instead |logged in library instead |of the location of the |of the library of the desk. |desk. | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Lucas, thx for picking this one up! I believe there is a small regression with the fix: When you are adding a desk, preselecting the current library makes sense, but now the empty option is preselected. Is there a chance we could distinguish between adding and editing as we do for other forms? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #130699|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 131529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131529&action=edit Bug 30107: When editing desks default to the branch the desk belongs to TO test: 1. Turn on UseCirculationDesks 2. Add some desks via Administration > Circulation desks, make several and have them belong to different libraries. 3. Go edit some of those desks and notice the Library: dropdown always defaults to the users logged in branch 4. Apply patch 5. Try editing desk again, now the dropdown should default the library that the desk belongs to. 6. Try making a new desk and make sure it defaults to the logged in branch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131529|0 |1 is obsolete| | --- Comment #4 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 132331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132331&action=edit Bug 30107: When editing desks default to the branch the desk belongs to TO test: 1. Turn on UseCirculationDesks 2. Add some desks via Administration > Circulation desks, make several and have them belong to different libraries. 3. Go edit some of those desks and notice the Library: dropdown always defaults to the users logged in branch 4. Apply patch 5. Try editing desk again, now the dropdown should default the library that the desk belongs to. 6. Try making a new desk and make sure it defaults to the logged in branch Signed-off-by: Séverine Queune <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr --- Comment #5 from Séverine Queune <severine.queune@bulac.fr> --- Seems ok for me : I didn't notice the regression Katrin talked about. Thanks Lucas ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think it was fixed in the lastest version of the patch - will double-check in QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Corrects a problem on the |Corrects a problem on the release notes|Circulation desk page where |circulation desk page where |the default library was |the default library was |always being set to the |always being set to the |logged in library instead |logged in library instead |of the library of the desk. |of the library of the desk. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Corrects a problem on the |Corrects a problem on the release notes|circulation desk page where |adminitration page for |the default library was |circulation desks where the |always being set to the |default library was always |logged in library instead |being set to the logged in |of the library of the desk. |library instead of the | |library of the desk. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Corrects a problem on the |Corrects a problem on the release notes|adminitration page for |administration page for |circulation desks where the |circulation desks where the |default library was always |default library was always |being set to the logged in |being set to the logged in |library instead of the |library instead of the |library of the desk. |library of the desk. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #132331|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 132371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=132371&action=edit Bug 30107: When editing desks default to the branch the desk belongs to TO test: 1. Turn on UseCirculationDesks 2. Add some desks via Administration > Circulation desks, make several and have them belong to different libraries. 3. Go edit some of those desks and notice the Library: dropdown always defaults to the users logged in branch 4. Apply patch 5. Try editing desk again, now the dropdown should default the library that the desk belongs to. 6. Try making a new desk and make sure it defaults to the logged in branch Signed-off-by: Séverine Queune <severine.queune@bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107 --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |kyle@bywatersolutions.com Version(s)|22.05.00 |22.05.00,21.11.05 released in| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to 21.11.x for 21.11.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30107 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org