https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19056 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17728 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17728 [Bug 17728] Move C4::Reserves code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19056 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 65604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65604&action=edit Bug 19056: Replace C4::Reserves::GetReserveCount with Koha::Patron->holds->count This subroutine is only used once and can easily be replaced with Koha::Patron->holds->count Test plan: - Set maxreserves=5 - Place 3 holds for a given patron - Place again 3 holds for this patron 3+3 > 5 => The holds must not be placed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19056 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19057 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19057 [Bug 19057] Move C4::Reserves::GetReserve to the Koha namespace -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19056 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19056 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65617|0 |1 is obsolete| | --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 66696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66696&action=edit Bug 19056: Replace C4::Reserves::GetReserveCount with Koha::Patron->holds->count This subroutine is only used once and can easily be replaced with Koha::Patron->holds->count Test plan: - Set maxreserves=5 - Place 3 holds for a given patron - Place again 3 holds for this patron 3+3 > 5 => The holds must not be placed Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19056 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19056 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Fridolin SOMERS from comment #5)

Isn't this enhancement ?

Changed to enhancement. -- You are receiving this mail because: You are watching all bug changes.