https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28705 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Marcel, can you explain how you expect it to work? Articles aren't checked out/don't need to be returned usually I think. Or maybe I missed an alternative workflow? Here it's usually used with copies that are kept by the patron. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28705 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122840&action=edit Bug 28705: Renew should look at current article requests This development is controlled by the new preference called CheckArticleRequestsOnRenewal. Test plan: [1] Run Circulation.t [2] Run the new test has_pending_article_requests.t [3] Enable preference [4] Issue some item, allow it to be renewed now [5] Add an article request for that specific item [6] Verify that you cannot renew this item now [7] Cancel the former article request [8] Add an article request for same biblio on biblio level [9] If there are still available items, you should be able to renew. But if not, you should not ;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28705 --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #4)

hold while the item is article requested or damaged etc.

To clarify: while the item is article requested or the biblio is article requested without available items (because at least one is onloan, and others are damaged, waiting etc.) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28705 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #6)

Silly question, do we highlight there's an article request pending at check-in already.. if not I could see that being nicely folded in here too.. I would be helpful to have such cases flagged at return so the item can be put to one side to process the article request.

Generally, though, this seems like a nice feature.

Thanks for your feedback. The check-in case is yet another one to take care of. The problem is that article request originally has been developed without considering the need of integration with Circulation. I would prefer to keep this report now at its current size. When checking in, we touch the point of comparing the priority of holds and article requests. Which one should go first? The oldest one? This problem is not yet actual here. In the code we just look first at holds to see if renewal is possible. If there are no holds, we check article requests. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28705 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #122840|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 123190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123190&action=edit Bug 28705: Renew should look at current article requests This development is controlled by the new preference called CheckArticleRequestsOnRenewal. Test plan: [1] Run Circulation.t [2] Run the new test has_current_article_requests.t [3] Enable preference [4] Issue some item, allow it to be renewed now [5] Add an article request for that specific item [6] Verify that you cannot renew this item now [7] Cancel the former article request [8] Add an article request for same biblio on biblio level [9] If there are still available items, you should be able to renew. But if not, you should not ;) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28705 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Article requests: Renew |Renewal should look at |should look at current |current article requests |requests | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28705 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #123190|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 128061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128061&action=edit Bug 28705: Renew should look at current article requests This development is controlled by the new preference called CheckArticleRequestsOnRenewal. Test plan: [1] Run Circulation.t [2] Run the new test has_current_article_requests.t [3] Enable preference [4] Issue some item, allow it to be renewed now [5] Add an article request for that specific item [6] Verify that you cannot renew this item now [7] Cancel the former article request [8] Add an article request for same biblio on biblio level [9] If there are still available items, you should be able to renew. But if not, you should not ;) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28705 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #12 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Works as described so signing off.. Putting my QA hat on, I think I'd prefer to not re-use the reserved flag but rather add our own case for article requests.. that way we have more flexibility later on in the flow to show specific messages etc. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28705 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Failed QA |RESOLVED -- You are receiving this mail because: You are watching all bug changes.