https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33399 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 149112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=149112&action=edit Bug 33399: [WIP] Improve checks of other items to determine if valid recall This patch employs the following checks to determine if it is valid for a patron to place a recall: - that we don't include items already allocated to a hold (i.e. hold 'is found') when counting for recallable items - that we don't include items that aren't allowed to be recalled (based on the recallsallowed circulation rule) when counting for recallable items Test plan coming -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33399 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #149112|0 |1 is obsolete| | --- Comment #2 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 157008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157008&action=edit Bug 33399: Improve checks of other items to determine if valid recall This patch employs the following checks to determine if it is valid for a patron to place a recall: - that we don't include items already allocated to a hold (i.e. hold 'is found') when counting for recallable items - that we don't include items that aren't allowed to be recalled (based on the recallsallowed circulation rule) when counting for recallable items To test: 1. Enable the UseRecalls system preference and configure the relevant recalls circulation and fines rules. Set 'on shelf recalls allowed' to all which means all recallable items must be unavailable in order to place recalls. 2. Create a biblio (Biblio A) with 2 items (Item A and Item B). Items A and B should have different item types. 3. Check out Item A to another patron (Patron B) 4. Log into the OPAC as Patron A in a second tab 5. Search for Biblio A and try to recall. You should be blocked because Item B could still be checked out so can't be recalled 6. Place a hold on Item B for a third patron (Patron C) 7. Check in Item B so that you're prompted about the hold, confirm the hold as waiting for Patron C 8. Go back to your OPAC tab as Patron A and try to recall. You should be blocked again because Koha thinks Item B is still available --> BUG 9. Cancel the hold on Item B 10. Go to your circulation rules and create a new rule specifically for the Item B itemtype. Set 'recalls allowed' to 0 for this item type. 'Recalls allowed' for the Item A itemtype should still be more than 0. 11. Go back to your OPAC tab as Patron A and try to recall. You should be blocked again because Koha thinks Item B can be recalled still --> BUG Apply patch and restart services. 12. Run through test plan again from steps 4 to 11. Instead of being blocked, you should be able to place your recall in both cases, because Koha will no longer recognise those items as recallable. Sponsored-by: Auckland University of Technology -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33399 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Circulation| |recalls function| | -- You are receiving this mail because: You are watching all bug changes.