[Bug 15680] New: Fresh install of Koha cannot find any dependencies
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15680 Bug ID: 15680 Summary: Fresh install of Koha cannot find any dependencies Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org It seems that on master, after clearing my database, one can no longer perform a fresh install. Koha seems to fail to find any of the installed Perl modules it depends on. This happens on master. The latest 3.22 finds the dependencies without a problem. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15680 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6679 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6679 [Bug 6679] Fixing code so it passes basic Perl::Critic tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15680 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15680 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 47352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47352&action=edit Bug 15680 - Fresh install of Koha cannot find any dependencies Fixing the evals in PerlModules.pm to pass perl critic has caused a regression. If appears that using a block eval will not work here, at least not in its current form. Test Plan: 1) Delete your database 2) Run the web installer 3) Note Koha says your dependencies need installed 4) Apply this patch 5) Refresh the page 6) Koha should see your dependencies are installed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15680 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Kyle, I reproduce the issue, and the patch fixes it. The weird thing is that the script now passes perlcritic (changes in perlcritic?) I'd suggest to revert 0e356b214eb049a446a8d089d579775aa49287d7 instead of create a new patch, to make the git log explicit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15680 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15680 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #2)
Kyle, I reproduce the issue, and the patch fixes it. The weird thing is that the script now passes perlcritic (changes in perlcritic?) I'd suggest to revert 0e356b214eb049a446a8d089d579775aa49287d7 instead of create a new patch, to make the git log explicit.
That is most odd! I'll take care of that reversion! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15680 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs Signoff |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15680 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #4 from Julian Maurice <julian.maurice@biblibre.com> --- This is needed on 3.22.x too, since bug 6679 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15680 --- Comment #5 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.3 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15680 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #6 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.9. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org