[Bug 37363] New: Booking dates should respect closed days
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37363 Bug ID: 37363 Summary: Booking dates should respect closed days Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com The bookings datepicker is not aware of open/closed days at present and as such a booking may be made that would expect fulfilment or return on a closed day. We should update the flatpickr to disable such dates for direct selection, but allow spanning them. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37363 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37363 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |martin.renvoize@ptfs-europe |ity.org |.com --- Comment #1 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Flatpickr doesn't appear to support this spanning functionality natively.. there are a few idea's here though: https://github.com/flatpickr/flatpickr/issues/955 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37363 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|29002 |34440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440 [Bug 34440] Add warm-up and cool-down periods to bookings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37363 --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This works from onDayCreate: ``` // Make closed days unclickable (while keeping them part of the range) if (date.getDay() === 0 || date.getDay() === 6) { dayElem.classList.add("closed-day"); // Remove the click event to disable the day dayElem.addEventListener('click', function(event) { event.stopImmediatePropagation(); }, true); } ``` I'll submit the patch once I've finished work on bug 34440 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37363 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37363 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36383 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36383 [Bug 36383] Add option to set open booking days -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37363 --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 169687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169687&action=edit Bug 37363: Initial work on supporting closed days This is just a proof of concept at this point.. we need api's for fetching regular and irregular closed days before we can fully impliment the functionality. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37363 Marie <marie.hedbom@musikverket.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie.hedbom@musikverket.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37363 Aude Charillon <aude.charillon@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@ptfs-europe. | |com --- Comment #4 from Aude Charillon <aude.charillon@ptfs-europe.com> --- This is of interest to a library we work with: they use the Tools > Calendar to mark closed days and would like to see those closed days greyed out when placing bookings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37363 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The main blocker here is the lack of API's for fetching calendar open/closed days. We need to work on that first and also consider how opening hours and days work together. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37363 Koha collecto <koha@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha@collecto.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37363 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|34440 |37354 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34440 [Bug 34440] Add warm-up and cool-down periods to bookings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37354 [Bug 37354] Bookings should respect circulation rules for max loan periods -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37363 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37363 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37363 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|37354 |41129 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37354 [Bug 37354] Bookings should respect circulation rules for max loan periods https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41129 [Bug 41129] Migrate place_booking.js to a Vue island. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37363 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |BLOCKED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37363 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.derscheid@lmscloud.de --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Hi there, I have a hacky fix for this in my refactor on Bug 41129. For the closed days, I added a wip api endpoint to expose them to both the staff interface and the OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37363 Irene Tortorella <i.tortorella@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |i.tortorella@arts.ac.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37363 --- Comment #7 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Now that Bug 41129's Vue rewrite has nearly landed and has initial closed-day awareness in the staff booking calendar (closed days are shown clearly and can't be picked as a start date), I think this bug still needs to cover a few things as configurable, per-library decisions rather than fixed behaviour: 1. Closed days shown clearly on the calendar - done as part of 41129. 2. A booking can't start on a closed day - done as part of 41129. 3. Lead/trail periods are currently always a fixed number of calendar days, closed days included. Libraries should be able to choose whether closed days count toward that total (inclusive) or are skipped over it (exclusive, effectively extending the buffer). 4. A booking's end date can currently always land on a closed day (41129 allows this by design, since some libraries offer a book-drop/return service even while closed). A library without one needs to be able to forbid it. Suggest exposing (3) and (4) as new options alongside bookings_lead_period / bookings_trail_period on the circulation rule, scoped the same way (item type / patron category / branch), since this is inherently a per-library policy rather than a global one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37363 --- Comment #8 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Makes sense. Configurability is needed here, as you said. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org