[Bug 12332] New: pay.pl and purchase-suggestions.pl tabs do not show selected
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332 Bug ID: 12332 Summary: pay.pl and purchase-suggestions.pl tabs do not show selected Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: cbrannon@cdalibrary.org QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com If you go into a patron account and click on the fines or purchase selections tabs, it does not show that this tab is selected, like all the other tabs do. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332 --- Comment #1 from Viktor Sarge <viktor.sarge@regionhalland.se> --- Created attachment 28865 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28865&action=edit 12332 Fix for tab "Purchase suggestions" not lighting up This patch changes the file purchase-suggestions.pl with "suggestionsview => 1" for the template parameter. In circ-menu.inc i changed the condition from "suggestions" to "suggestionsview" since it seemed to conflict with the existing variable suggestions (and in that case only highlighting the tab when there were suggestions). Please note that I fixed the troubles with the tab "Fines" in a separate patch 9245. Test plan: 1) Verify that "Purchase suggestions" does not light up as it should when clicked. 2) Install the patch. 3) Verify that the tab "Purchase suggestions" now actually light up when clicked. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332 Viktor Sarge <viktor.sarge@regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |viktor.sarge@regionhalland. | |se -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332 --- Comment #2 from Christopher Brannon <cbrannon@cdalibrary.org> --- I tested patch in sandbox 7. It works, but the sandbox won't let me sign off on it. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332 --- Comment #3 from Christopher Brannon <cbrannon@cdalibrary.org> --- Sandbox gives me the following message on either patch when I try to sign off on them: It seems you don't have applied a patch, so you cannot sign it off. If you applied patches from the right report, check the commit message of the last patch. It should start with "Bug XXXXX", if not, please inform the author of the patch. I don't know what a commit message is or where to find it. Christopher -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28865|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28920 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28920&action=edit Bug 12332: Fix for tab "Purchase suggestions" not lighting up This patch changes the file purchase-suggestions.pl with "suggestionsview => 1" for the template parameter. In circ-menu.inc i changed the condition from "suggestions" to "suggestionsview" since it seemed to conflict with the existing variable suggestions (and in that case only highlighting the tab when there were suggestions). Please note that I fixed the troubles with the tab "Fines" in a separate patch 9245. Test plan: 1) Verify that "Purchase suggestions" does not light up as it should when clicked. 2) Install the patch. 3) Verify that the tab "Purchase suggestions" now actually light up when clicked. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332 sandboxes@biblibre.com <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes@biblibre.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Viktor, Please start the commit message of your patches by "Bug XXXXX". Otherwise the sandboxes cannot signoff them. I fixed this one and added the Christopher's signoff. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332 --- Comment #6 from Viktor Sarge <viktor.sarge@regionhalland.se> --- (In reply to Jonathan Druart from comment #5)
Viktor, Please start the commit message of your patches by "Bug XXXXX". Otherwise the sandboxes cannot signoff them.
I fixed this one and added the Christopher's signoff.
Thank you for helping out Jonathan and for testing Christopher! I do have things to learn with Git and I'm glad that someone caught that I misformated the commit message before I made more patches. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9261 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28920|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 28947 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28947&action=edit Bug 12332: Fix for tab "Purchase suggestions" not lighting up This patch changes the file purchase-suggestions.pl with "suggestionsview => 1" for the template parameter. In circ-menu.inc i changed the condition from "suggestions" to "suggestionsview" since it seemed to conflict with the existing variable suggestions (and in that case only highlighting the tab when there were suggestions). Please note that I fixed the troubles with the tab "Fines" in a separate patch 9245. Test plan: 1) Verify that "Purchase suggestions" does not light up as it should when clicked. 2) Install the patch. 3) Verify that the tab "Purchase suggestions" now actually light up when clicked. Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|pay.pl and |purchase-suggestions.pl |purchase-suggestions.pl |tabs do not show selected |tabs do not show selected | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Bug 12447 created for the pay.pl (Fines) tab. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12447 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12332 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com Version|unspecified |master --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Viktor! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org