[Bug 18160] New: Error when OverDriveCirculation not enabled
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18160 Bug ID: 18160 Summary: Error when OverDriveCirculation not enabled Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org There is an "Internal server error" inserted into the summary tab of a patron's account when OverDriveCirculation is not enabled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18160 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18160 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 60588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60588&action=edit Bug 18160 - Error when OverDriveCirculation not enabled This patch only executes OverDrive circulation JS if OverDriveCirculation pref is enabled To test: 1 - Disable OverDriveCirculation 2 - Log in to opac and view summary tab 3 - Note 'Internal server error' 4 - Apply patch 5 - Repeat and note error is not present -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18160 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Depends on| |16034 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 [Bug 16034] Integration with OverDrive Patron API -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18160 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18160 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60588|0 |1 is obsolete| | --- Comment #2 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 60589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60589&action=edit [SIGNED-OFF] Bug 18160 - Error when OverDriveCirculation not enabled This patch only executes OverDrive circulation JS if OverDriveCirculation pref is enabled To test: 1 - Disable OverDriveCirculation 2 - Log in to opac and view summary tab 3 - Note 'Internal server error' 4 - Apply patch 5 - Repeat and note error is not present Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18160 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60589|0 |1 is obsolete| | --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 60590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60590&action=edit [SIGNED-OFF] Bug 18160 - Error when OverDriveCirculation not enabled This patch only executes OverDrive circulation JS if OverDriveCirculation pref is enabled To test: 1 - Disable OverDriveCirculation 2 - Log in to opac and view summary tab 3 - Note 'Internal server error' 4 - Apply patch 5 - Repeat and note error is not present Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18160 --- Comment #4 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- I did not get an error, but still, fix stands, Overdrive login link should not be shown if Overdrive is not enabled. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18160 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Srdjan Jankovic from comment #4)
I did not get an error, but still, fix stands, Overdrive login link should not be shown if Overdrive is not enabled.
I did get an error, and this corrects it for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18160 --- Comment #6 from M. Tompsett <mtompset@hotmail.com> --- It should be noted that I did not have any overdrive system preferences even filled in. I suspect that enabling and disabling would make no difference if you had valid values set up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18160 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I still get Could not compile /home/vagrant/kohaclone/opac/svc/overdrive: Can't locate WebService/ILS/OverDrive/Patron.pm in the logs, why does it not appear in the dependency list? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18160 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Why is OverDriveCirculation pass to the template when we should use the TT plugin? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18160 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18160 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Failing QA because it seems that overdrive.js should not be included if pref is off (ie. shift the IF one line above). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18160 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18160 --- Comment #10 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Jonathan Druart from comment #7)
I still get
Could not compile /home/vagrant/kohaclone/opac/svc/overdrive: Can't locate WebService/ILS/OverDrive/Patron.pm
in the logs, why does it not appear in the dependency list?
Perhaps a follow up is needed to bug 16034? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18160 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18160 --- Comment #11 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 60622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60622&action=edit Bug 18160: Follow up tweak if condition Based on comment #9, moved if condition. Based on comment #8, tweaked condition to grab preference. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18160 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18160 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60590|0 |1 is obsolete| | Attachment #60622|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60718&action=edit Bug 18160 - Error when OverDriveCirculation not enabled This patch only executes OverDrive circulation JS if OverDriveCirculation pref is enabled To test: 1 - Disable OverDriveCirculation 2 - Log in to opac and view summary tab 3 - Note 'Internal server error' 4 - Apply patch 5 - Repeat and note error is not present Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18160 --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 60719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60719&action=edit Bug 18160: Follow up tweak if condition Based on comment #9, moved if condition. Based on comment #8, tweaked condition to grab preference. Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18160 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18160 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Nick, Mark! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18160 Bug 18160 depends on bug 16034, which changed state. Bug 16034 Summary: Integration with OverDrive Patron API https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16034 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18160 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Depends on bug 16034 which is not in 16.11.x. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org