http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13159 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34187 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34187&action=edit Bug 13411 - Koha's SIP server returns not ok for checking in items that are not checked out If an item is not checked out when a checkin via SIP2 is attempted, Koha's SIP server sends back an "ok" of 0, and the AF message "Item not checked out". I am not entirely sure this is good and correct behavior by the SIP2 protocol. In particular, this will cause SIP2 book sorting devices to fail on all items that are not checked out, causing them all to be put into the "special handling" been that should be reserved for things like items checked in at the wrong library and items on hold. Test Plan: 1) Apply the patch for bug 13159 so you can use the new enhanced SIP2 command line emulator 2) Use a command similar to the following to check in an item: sip_cli_emulator.pl -a localhost -su <sip user> -sp <sip password> -l <instituation id> --item <barcode> -m checkin 3) Note the 3rd character is 0, and there is an AF field saying the item is not checked out 4) Apply this patch 5) Restart the SIP server 6) Repeat steps 2-3, note that nothing has changed 7) In the SIP config file, Add the parameter checked_in_ok="1" to the SIP account you are using. 8) Restart the SIP server 9) Repeat steps 2-3, note that this time the 4rd character is 1, and you do not recieve the item not checked out message. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 --- Comment #3 from Colin Campbell <colin.campbell@ptfs-europe.com> --- I think this works ok for the self check but it would be good if it logged something in this case as we might need to track odd behaviour (e.g. bug 11039 ) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth@kul.oslo.k | |ommune.no --- Comment #5 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Not able to confirm expected behaviour. checkin of item checked out works ok: Trying 'checkin' SEND: 09Y201515 115144201515 115144APCPL|AOCPL|AB123456|ACautopass|BIN| READ: 101YNN20150205 115144AOCPL|AB123456|AQCPL|AJEn tittel|AA2| but checkin of not checked out item returns error: Trying 'checkin' SEND: 09Y201515 115147201515 115147APCPL|AOCPL|AB123456|ACautopass|BIN| Use of uninitialized value $data in concatenation (.) or string at ./sip_cli_emulator.pl line 270, <GEN0> chunk 1. READ: command used: perl -I. ./sip_cli_emulator.pl -l CPL -su autouser -sp autopass --port=6001 --address=localhost --item 123456 -m checkin --patron 2 output from SIPServer log: Use of uninitialized value $id in string ne at C4/SIP/ILS.pm line 84. Use of uninitialized value $_[1] in sprintf at /usr/lib/perl/5.14/Sys/Syslog.pm line 368. Use of uninitialized value in negation (-) at /usr/lib/perl5/DateTime.pm line 1764. DBD::mysql::st execute failed: called with 1 bind variables when 0 are needed at C4/Members.pm line 596. Can't use an undefined value as an ARRAY reference at /usr/lib/perl5/DBI.pm line 2054. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35667|0 |1 is obsolete| | --- Comment #7 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 35669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35669&action=edit Bug 13411 - Koha's SIP server returns not ok for checking in items that are not checked out If an item is not checked out when a checkin via SIP2 is attempted, Koha's SIP server sends back an "ok" of 0, and the AF message "Item not checked out". I am not entirely sure this is good and correct behavior by the SIP2 protocol. In particular, this will cause SIP2 book sorting devices to fail on all items that are not checked out, causing them all to be put into the "special handling" been that should be reserved for things like items checked in at the wrong library and items on hold. Test Plan: 1) Apply the patch for bug 13159 so you can use the new enhanced SIP2 command line emulator 2) Use a command similar to the following to check in an item: sip_cli_emulator.pl -a localhost -su <sip user> -sp <sip password> -l <instituation id> --item <barcode> -m checkin 3) Note the 3rd character is 0, and there is an AF field saying the item is not checked out 4) Apply this patch 5) Restart the SIP server 6) Repeat steps 2-3, note that nothing has changed 7) In the SIP config file, Add the parameter checked_in_ok="1" to the SIP account you are using. 8) Restart the SIP server 9) Repeat steps 2-3, note that this time the 4rd character is 1, and you do not recieve the item not checked out message. Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #8 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- As a sidenote, I can confirm that if the returned character 3in the SIP Checkout Response is 0 for an item that is not checked out, it breaks automation and circulation logic altogether, as any item returned should trigger a transfer if applicable. Therefore I'd like to up the severity of this bug. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Signed Off |Patch doesn't apply --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There is a conflict in ILS.pm - please rebase! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35669|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 36271 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36271&action=edit Bug 13411 - Koha's SIP server returns not ok for checking in items that are not checked out If an item is not checked out when a checkin via SIP2 is attempted, Koha's SIP server sends back an "ok" of 0, and the AF message "Item not checked out". I am not entirely sure this is good and correct behavior by the SIP2 protocol. In particular, this will cause SIP2 book sorting devices to fail on all items that are not checked out, causing them all to be put into the "special handling" been that should be reserved for things like items checked in at the wrong library and items on hold. Test Plan: 1) Apply the patch for bug 13159 so you can use the new enhanced SIP2 command line emulator 2) Use a command similar to the following to check in an item: sip_cli_emulator.pl -a localhost -su <sip user> -sp <sip password> -l <instituation id> --item <barcode> -m checkin 3) Note the 3rd character is 0, and there is an AF field saying the item is not checked out 4) Apply this patch 5) Restart the SIP server 6) Repeat steps 2-3, note that nothing has changed 7) In the SIP config file, Add the parameter checked_in_ok="1" to the SIP account you are using. 8) Restart the SIP server 9) Repeat steps 2-3, note that this time the 4rd character is 1, and you do not recieve the item not checked out message. Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- there is a small bug in the rebase on line 202: Can't locate object method "Patron" via package "ILS" at C4/SIP/ILS.pm line 202. $circ->patron( $patron = new ILS::Patron $item->{patron} ); should be: $circ->patron($patron = C4::SIP::ILS::Patron->new( $item->{patron} )); otherwise it breaks connection on checkin of checked out item -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #16 from Colin Campbell <colin.campbell@ptfs-europe.com> --- There are a few problems with these patches. First the existing behaviour is consistent with the standard ( 0 because a checkin has not succeeded) however I can see that there is probably no practical distinction between checkin of an unissued book and an issued one especially if some machines are routing returns incorrectly as a result. But we should document it as a change in behaviour so it gets reported as that in release notes (in case there are unforeseen consequences) The commit message also gives a test which does not succeed it says the message is not returned after the patch is applied, but it is (incidently I think it should still be returned as information, so the code is ok the test fails) Finally the patch adds a new parameter into the config files but there is a) no mention of it and b) it doesnt seem to be of any use in the implementation -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36310|1 |0 is obsolete| | --- Comment #20 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Comment on attachment 36310 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36310 Bug 13411 [QA Followup] - Add logging moved namespace fix to other patch of this bug. It has nothing to do with logging -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36271|0 |1 is obsolete| | --- Comment #21 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Created attachment 40952 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40952&action=edit Bug 13411 - Koha's SIP server returns not ok for checking in items that are not checked out corrected line $circ->patron( $patron = new ILS::Patron $item->{patron} ); to $circ->patron($patron = C4::SIP::ILS::Patron->new( $item->{patron})); in patch, as it breaks checkin and conforms to namespace used in file -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #40952|0 |1 is obsolete| | Attachment #40953|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42035&action=edit Bug 13411 - Koha's SIP server returns not ok for checking in items that are not checked out If an item is not checked out when a checkin via SIP2 is attempted, Koha's SIP server sends back an "ok" of 0, and the AF message "Item not checked out". I am not entirely sure this is good and correct behavior by the SIP2 protocol. In particular, this will cause SIP2 book sorting devices to fail on all items that are not checked out, causing them all to be put into the "special handling" been that should be reserved for things like items checked in at the wrong library and items on hold. Test Plan: 1) Apply the patch for bug 13159 so you can use the new enhanced SIP2 command line emulator 2) Use a command similar to the following to check in an item: sip_cli_emulator.pl -a localhost -su <sip user> -sp <sip password> -l <instituation id> --item <barcode> -m checkin 3) Note the 3rd character is 0, and there is an AF field saying the item is not checked out 4) Apply this patch 5) Restart the SIP server 6) Repeat steps 2-3, note that nothing has changed 7) In the SIP config file, Add the parameter checked_in_ok="1" to the SIP account you are using. 8) Restart the SIP server 9) Repeat steps 2-3, note that this time the 4rd character is 1, and you do not recieve the item not checked out message. Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #25 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Patch not working as advertised - in the rebasings it looks like we've lost the check of the config value to pass to checkin so the checked_in_ok variable is never passed -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42035|0 |1 is obsolete| | Attachment #42036|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 42081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42081&action=edit Bug 13411 - Koha's SIP server returns not ok for checking in items that are not checked out If an item is not checked out when a checkin via SIP2 is attempted, Koha's SIP server sends back an "ok" of 0, and the AF message "Item not checked out". I am not entirely sure this is good and correct behavior by the SIP2 protocol. In particular, this will cause SIP2 book sorting devices to fail on all items that are not checked out, causing them all to be put into the "special handling" been that should be reserved for things like items checked in at the wrong library and items on hold. Test Plan: 1) Apply the patch for bug 13159 so you can use the new enhanced SIP2 command line emulator 2) Use a command similar to the following to check in an item: sip_cli_emulator.pl -a localhost -su <sip user> -sp <sip password> -l <instituation id> --item <barcode> -m checkin 3) Note the 3rd character is 0, and there is an AF field saying the item is not checked out 4) Apply this patch 5) Restart the SIP server 6) Repeat steps 2-3, note that nothing has changed 7) In the SIP config file, Add the parameter checked_in_ok="1" to the SIP account you are using. 8) Restart the SIP server 9) Repeat steps 2-3, note that this time the 4rd character is 1, and you do not recieve the item not checked out message. Signed-off-by: Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle.m.hall@gmail.com --- Comment #28 from Kyle M Hall <kyle.m.hall@gmail.com> --- (In reply to Colin Campbell from comment #25)

Patch not working as advertised - in the rebasings it looks like we've lost the check of the config value to pass to checkin so the checked_in_ok variable is never passed

Thanks for catching that! I've re-rebased the patch to correct that omission! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #29 from Colin Campbell <colin.campbell@ptfs-europe.com> --- having applied the patch against current master server terminates when processing an issue transaction -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 --- Comment #31 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Restested and working (??) Message suppressed and ok set to 1 In the test plan step 9 it talks of 4th character but should be 3rd as in step 3 Although discharge is now ok and no message sent the alert flag is being returned as 'Y' which would indicate a condition requiring special action. should this not be set to N in this case? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |ASSIGNED --- Comment #33 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Kyle M Hall from comment #32)

...

In the test plan step 9 it talks of 4th character but should be 3rd as in step 3

Sorry about that! I will revise the test plan.

Setting the status accordingly. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 --- Comment #35 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 43591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43591&action=edit Bug 13411 [QA Followup] - Add logging -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Kyle M Hall <kyle.m.hall@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 --- Comment #37 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #36)

(In reply to Kyle M Hall from comment #34)

...

9) Repeat steps 2-3, note that this time the 3rd character is 1, and you do not recieve the item not checked out message.

Why don't we want to display the message?

Because some SIP2 sorters will behave badly if we send the message. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #43591|0 |1 is obsolete| | --- Comment #39 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 45028 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45028&action=edit [SIGNED-OFF] Bug 13411 [QA Followup] - Add logging Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13411 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic@tamil.fr --- Comment #41 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.6. -- You are receiving this mail because: You are watching all bug changes.