https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- *** Bug 10959 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Liz Rea from comment #2)

Is this work in progress or are other solutions to this acceptable.

If you have thoughts or plans I'd love to hear them! As far as I'm aware, we haven't put pen to paper yet :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18731 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- And please help make bug 18731 into master ASAP! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 [Bug 18731] Add routes for acquisition orders -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24366 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24366 [Bug 24366] Merging biblioitems should happen in Koha::Biblio->to_api -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Time to finish this as all dependencies are in master \o/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24419 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24419 [Bug 24419] Add Koha::Suggestion->suggestor accessor -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24435 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435 [Bug 24435] Add Koha::Biblio->items_count -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24448 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24448 [Bug 24448] Add Koha::Biblio->subscriptions_count -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 97546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97546&action=edit Bug 20212: Add more embeddable objects to orders -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I submit an unfinished implementation that renders both the original table, and the new one (generated through the API). The aim is to get people to review it, and suggest changes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Nicolas Legrand <nicolas.legrand@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.legrand@bulac.fr -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24462 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462 [Bug 24462] Adjust K::A::Invoice API mapping to voted RFC -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97547|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 97630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97630&action=edit [WIP] Bug 20212: Use the API to render orders -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24464 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24464 [Bug 24464] Add K::A::Basket->creator -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97630|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 97634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=97634&action=edit [WIP] Bug 20212: Use the API to render orders -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Hayley Mapley <hayleymapley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24454 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24454 [Bug 24454] currency formatting from JS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24467 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467 [Bug 24467] *_count methods should be avoided -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24467 | Depends on| |24467 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24467 [Bug 24467] *_count methods should be avoided -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #97635|0 |1 is obsolete| | Attachment #97745|0 |1 is obsolete| | --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 98226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98226&action=edit Bug 20212: Use the API to render orders -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98226|0 |1 is obsolete| | --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 98230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98230&action=edit [WIP] Bug 20212: Use the API to render orders -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #98230|0 |1 is obsolete| | --- Comment #20 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 98241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=98241&action=edit [WIP] Bug 20212: Use the API to render orders -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24561 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561 [Bug 24561] Add embedded column filter feature to datatables api wrapper -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Bug 20212 depends on bug 24419, which changed state. Bug 24419 Summary: Add Koha::Suggestion->suggester accessor https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24419 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Bug 20212 depends on bug 24435, which changed state. Bug 24435 Summary: Add Koha::Biblio->items_count https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24435 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Bug 20212 depends on bug 24457, which changed state. Bug 24457 Summary: K::A::Basket->to_api is not passing the parameters to the parent class implementation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24457 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Bug 20212 depends on bug 24528, which changed state. Bug 24528 Summary: Add a syntax for specifying counts on x-koha-embed https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24528 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Bug 20212 depends on bug 24440, which changed state. Bug 24440 Summary: Add ->current_item_level_holds to Koha::Acquisition::Order https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24440 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24561 CC| |agustinmoyano@theke.io Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24561 [Bug 24561] Add embedded column order by and filter features to datatables api wrapper -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #22 from Agustín Moyano <agustinmoyano@theke.io> --- Created attachment 99725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99725&action=edit Bug 20212: Use the API to render orders -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune@bulac.fr -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Acquisitions |and plumbing | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Bug 20212 depends on bug 24554, which changed state. Bug 24554 Summary: Only embed relations from Koha::Biblio in to_api https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24554 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Bug 20212 depends on bug 24462, which changed state. Bug 24462 Summary: Adjust K::A::Invoice API mapping to voted RFC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24462 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100142|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #26 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 100476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100476&action=edit Bug 20212: Add more embeddable objects to orders -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #28 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 100478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100478&action=edit Bug 20212: Use API to render orders datatable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100475|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100477|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #30 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 100552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100552&action=edit Bug 20212: Add missing entries on schema files This patch adds the missing koha_object(s)_class methods to the related schema files. It also adds a 'bilbioitem' relationship to the Biblio class as required for being able to prefetch that table information. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #32 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 100554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100554&action=edit Bug 20212: Allow filtering orders on ISBN This patch adapts the code from the list() sub so it manipulates the query parameters and the embed header so: - the biblioitem relationship is prefetch - any queries on biblio.isbn are correctly translated into search on the biblioitems table. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100552|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100554|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #34 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 100600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100600&action=edit Bug 20212: Add missing entries on schema files This patch adds the missing koha_object(s)_class methods to the related schema files. It also adds a 'bilbioitem' relationship to the Biblio class as required for being able to prefetch that table information. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #36 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 100602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100602&action=edit Bug 20212: Allow filtering orders on biblioitems fields This patch adapts the code from the list() sub so it manipulates the query parameters and the embed header so: - the biblioitem relationship is prefetch - any queries on biblio.isbn and biblio.ean are correctly translated into search on the biblioitems table. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100603|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #39 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 100606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100606&action=edit Bug 20212: Clean parcel.pl Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100605|0 |1 is obsolete| | --- Comment #41 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 100643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100643&action=edit Bug 20212: Use API to render orders datatable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24455 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24455 [Bug 24455] Date formatting from JS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24918 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24918 [Bug 24918] Wrong attribute mappings in Koha::Acquisition::Basket -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100600|0 |1 is obsolete| | --- Comment #44 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 101320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101320&action=edit Bug 20212: Add missing entries on schema files This patch adds the missing koha_object(s)_class methods to the related schema files. It also adds a 'bilbioitem' relationship to the Biblio class as required for being able to prefetch that table information. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24965 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24965 [Bug 24965] Koha::Object->to_api should handle undef counts -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100601|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100643|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #46 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 103684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103684&action=edit Bug 20212: Add more embeddable objects to orders -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #48 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 103686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103686&action=edit Bug 20212: Clean parcel.pl Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #50 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 103688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103688&action=edit Bug 20212: Add missing entries on schema files This patch adds the missing koha_object(s)_class methods to the related schema files. It also adds a 'bilbioitem' relationship to the Biblio class as required for being able to prefetch that table information. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24965 |25297 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24965 [Bug 24965] Koha::Object->to_api should handle undef counts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25297 [Bug 25297] Consistent return value in K::A::Order->current_item_level_holds -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Peggy Thrasher <p.thrasher@dover.nh.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher@dover.nh.gov -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103684|0 |1 is obsolete| | --- Comment #51 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 109861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109861&action=edit Bug 20212: Add more embeddable objects to orders This patch adds options to embed more related objects based on the needs by parcel.tt. For filtering by biblioitems fields (ISBN and EAN) I had to make the 'list' method a modified version of the objects->search helper. I thought of doing it in a more generic way but I didn't find any other use cases and it would certainly make an already complex piece of code even more complex. So this is quite similar, but at some steps the biblio.<biblioitem field> gets translated into the proper relation names, and the same happens for prefetching. A new parameter is also added: only_active. It makes the controller use Koha::Acquisition::Orders->filter_by_active, avoiding the need to build complex queries in the UI. The same handling is done when the order_id parameter is passed (outside the q= parameters). In this case using Koha::Acquisition::Orders->filter_by_id_including_transfers This is all respecting the C4::Acquisitions::SearchOrders behaviour. TL;DR: This patch adapts the code from the list() sub so it manipulates the query parameters and the embed header so: - the biblioitem relationship is prefetch - any queries on biblio.isbn and biblio.ean are correctly translated into search on the biblioitems table. - Adds an only_active parameter to the /acquisitions/orders route to easily request only the active orders. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103687|0 |1 is obsolete| | --- Comment #53 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 109863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109863&action=edit Bug 20212: Use API to render orders datatable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109863|0 |1 is obsolete| | --- Comment #55 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 109866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109866&action=edit Bug 20212: Use API to render orders datatable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109862|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109866|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109861|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #57 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 109868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109868&action=edit Bug 20212: Clean parcel.pl Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #59 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 109870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109870&action=edit Bug 20212: Add missing relation in Biblio Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #60 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 109936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109936&action=edit Bug 20212: Remove warning if no basket group If any row contains no basket group, the browser console will show a datatables warning about basket.basket_group.name not existing. This patch gets rid of it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #62 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 110229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110229&action=edit Plack error when trying to receive w/ library data -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109936|0 |1 is obsolete| | --- Comment #63 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 110234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110234&action=edit Bug 20212: Remove warning if no basket group If any row contains no basket group, the browser console will show a datatables warning about basket.basket_group.name not existing. This patch gets rid of it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109869|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110478|0 |1 is obsolete| | --- Comment #65 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 110482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110482&action=edit Bug 20212: Use API to render orders datatable This patch makes the pending orders datatable render using the API instead of hte old controller script. It implements native server-side pagination thanks to the API and the datatables wrapper. On polishing it, we found that data can contain many null values, and it got dirtier in the process. This code with all the checks that are done on the data is the result of testing this dev with real-life production databases, huge ones with thousands of orderlines. To test: 1. You should compare the behaviour between this table, and the original one in master. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Agustín Moyano <agustinmoyano@theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8179 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 [Bug 8179] Receiving multiple order lines at once -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #67 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Generally this looks like it's going in the right direction to me. I do wonder if we could preload the first page of results using the template to give the appearance of better performance on initial page load whilst still getting the benefit of serverside processing for the heavy lifting. (As discussed on Slack, see https://datatables.net/examples/server_side/defer_loading.html for possibilities) However.. I'm not sure the API's is returning the same results as expected... attaching before and after shots for the table with the exact same database. The ajax version appears to have considerably more results and many of them seem to contain malformed 'null' data? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #69 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111569&action=edit Screenshot of table before patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #71 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Hmm, I think you're right, it highlights bad data in my test set.. That's probably a good thing. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #73 from Tomás Cohen Arazi <tomascohen@gmail.com> --- The last patch applies the lessons learned from the libraries page work. Escaping things, as generic as possible. Handle nulls more gracefully. Hope you enjoy testing this! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109867|0 |1 is obsolete| | --- Comment #74 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 112521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112521&action=edit Bug 20212: Add more embeddable objects to orders This patch adds options to embed more related objects based on the needs by parcel.tt. For filtering by biblioitems fields (ISBN and EAN) I had to make the 'list' method a modified version of the objects->search helper. I thought of doing it in a more generic way but I didn't find any other use cases and it would certainly make an already complex piece of code even more complex. So this is quite similar, but at some steps the biblio.<biblioitem field> gets translated into the proper relation names, and the same happens for prefetching. A new parameter is also added: only_active. It makes the controller use Koha::Acquisition::Orders->filter_by_active, avoiding the need to build complex queries in the UI. The same handling is done when the order_id parameter is passed (outside the q= parameters). In this case using Koha::Acquisition::Orders->filter_by_id_including_transfers This is all respecting the C4::Acquisitions::SearchOrders behaviour. TL;DR: This patch adapts the code from the list() sub so it manipulates the query parameters and the embed header so: - the biblioitem relationship is prefetch - any queries on biblio.isbn and biblio.ean are correctly translated into search on the biblioitems table. - Adds an only_active parameter to the /acquisitions/orders route to easily request only the active orders. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109870|0 |1 is obsolete| | --- Comment #76 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 112523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112523&action=edit Bug 20212: Add missing relation in Biblio Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112524|0 |1 is obsolete| | --- Comment #78 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 112686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112686&action=edit Bug 20212: Use API to render orders datatable This patch makes the pending orders datatable render using the API instead of hte old controller script. It implements native server-side pagination thanks to the API and the datatables wrapper. On polishing it, we found that data can contain many null values, and it got dirtier in the process. This code with all the checks that are done on the data is the result of testing this dev with real-life production databases, huge ones with thousands of orderlines. To test: 1. You should compare the behaviour between this table, and the original one in master. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112521|0 |1 is obsolete| | --- Comment #80 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 112698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112698&action=edit Bug 20212: Add more embeddable objects to orders This patch adds options to embed more related objects based on the needs by parcel.tt. For filtering by biblioitems fields (ISBN and EAN) I had to make the 'list' method a modified version of the objects->search helper. I thought of doing it in a more generic way but I didn't find any other use cases and it would certainly make an already complex piece of code even more complex. So this is quite similar, but at some steps the biblio.<biblioitem field> gets translated into the proper relation names, and the same happens for prefetching. A new parameter is also added: only_active. It makes the controller use Koha::Acquisition::Orders->filter_by_active, avoiding the need to build complex queries in the UI. The same handling is done when the order_id parameter is passed (outside the q= parameters). In this case using Koha::Acquisition::Orders->filter_by_id_including_transfers This is all respecting the C4::Acquisitions::SearchOrders behaviour. TL;DR: This patch adapts the code from the list() sub so it manipulates the query parameters and the embed header so: - the biblioitem relationship is prefetch - any queries on biblio.isbn and biblio.ean are correctly translated into search on the biblioitems table. - Adds an only_active parameter to the /acquisitions/orders route to easily request only the active orders. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112523|0 |1 is obsolete| | --- Comment #82 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 112700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112700&action=edit Bug 20212: Add missing relation in Biblio Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112698|0 |1 is obsolete| | --- Comment #84 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 112703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112703&action=edit Bug 20212: Add more embeddable objects to orders This patch adds options to embed more related objects based on the needs by parcel.tt. For filtering by biblioitems fields (ISBN and EAN) I had to make the 'list' method a modified version of the objects->search helper. I thought of doing it in a more generic way but I didn't find any other use cases and it would certainly make an already complex piece of code even more complex. So this is quite similar, but at some steps the biblio.<biblioitem field> gets translated into the proper relation names, and the same happens for prefetching. A new parameter is also added: only_active. It makes the controller use Koha::Acquisition::Orders->filter_by_active, avoiding the need to build complex queries in the UI. The same handling is done when the order_id parameter is passed (outside the q= parameters). In this case using Koha::Acquisition::Orders->filter_by_id_including_transfers This is all respecting the C4::Acquisitions::SearchOrders behaviour. TL;DR: This patch adapts the code from the list() sub so it manipulates the query parameters and the embed header so: - the biblioitem relationship is prefetch - any queries on biblio.isbn and biblio.ean are correctly translated into search on the biblioitems table. - Adds an only_active parameter to the /acquisitions/orders route to easily request only the active orders. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112700|0 |1 is obsolete| | --- Comment #86 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 112705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112705&action=edit Bug 20212: Add missing relation in Biblio Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #88 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Thanks, Andrew. It's been a very nice testing session, and the things you found were really helpful to make this solid! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Slowness in Receiving in |Slowness in receiving in |Acquisitions |acquisitions -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #91 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 112868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112868&action=edit Bug 20212: (QA follow-up) Remember current filter This patch restores the original behaviour: if you jump into receiving an order, and then go back to receiving, you want the page to remember your filters. This feature was overlooked. On fixing it, I wrapped some JS code in a function for reusing it and simplified it a bit as well. To test: 1. Enter a search term in either of the search fields 2. Add a note, receive or do another action => SUCCESS: The search term is kept 3. Apply this patch set 4. Repeat 2 => SUCCESS: The search term is kept Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #93 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 112882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=112882&action=edit Bug 20212: Controller changes regression tests This patchset did a copy and paste of the objects->search helper inside the controller, to handle a very special case that wasn't worth generalizing: the fact that the biblio object (that this patchset makes embeddable) is actually built from two tables, and we want to filter by fields in both tables. This requires us to translate: - Any filter reference to fields in biblioitems we allow to search on, through an allow list. - For filtering to work, we need to tweak the stashed 'embed' object so the prefetch is done correctly This patchset also adds a new query parameter: only_active. It is used to only request active orders (see the spec for more details). This patch adds tests for: - Filtering by a column in bilbioitems (this implies correctly prefetching the bilbio => biblioitems relation, and translating the filtering parameter. - Using the only_active query parameter to retrieve only active orders To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => SUCCESS: Tests pass! 3. Verify the tests check for the explained behaviours. => SUCCESS: They do! 4. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #96 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Tomás Cohen Arazi from comment #95)

(In reply to Katrin Fischer from comment #94)

...

There still appears to be some regression :(

- The filters on the datatable are no longer kept

Is that a thing in master?? I don't recall seeing code related to that.

I tested and yes, it worked in my tests. I had also noted it in comment#89 "or the table search".

...

- and the column filters have vanished altogether

Do we miss them?

They allow filtering on aspects that cannot be searched otherwise - I believe they would be missed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #98 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm sure we can restore the column filters as a followup.. I was hoping to see this in the queue for this release. Getting stuck this close to the deadline is plain disheartening :( -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #100 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Andrew Fuerste-Henry from comment #99)

...

They allow filtering on aspects that cannot be searched otherwise - I believe they would be missed.

Testing this, it seems that on current code the main search box above the pending orders table is capable of searching every column in that table except the fund.

Good catch! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #102 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 113278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113278&action=edit Bug 20212: (QA follow-up) Resurrect column filtering This patch adds per-column filtering to the order receiving table. The order cost column proved difficult to filter, because of the syntax DBIC requires for comparing replacement_cost * quantity, and passing that all the way down from the API request to DBIC itself. I'm still looking for options. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112703|0 |1 is obsolete| | --- Comment #105 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 114607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114607&action=edit Bug 20212: Add more embeddable objects to orders This patch adds options to embed more related objects based on the needs by parcel.tt. For filtering by biblioitems fields (ISBN and EAN) I had to make the 'list' method a modified version of the objects->search helper. I thought of doing it in a more generic way but I didn't find any other use cases and it would certainly make an already complex piece of code even more complex. So this is quite similar, but at some steps the biblio.<biblioitem field> gets translated into the proper relation names, and the same happens for prefetching. A new parameter is also added: only_active. It makes the controller use Koha::Acquisition::Orders->filter_by_active, avoiding the need to build complex queries in the UI. The same handling is done when the order_id parameter is passed (outside the q= parameters). In this case using Koha::Acquisition::Orders->filter_by_id_including_transfers This is all respecting the C4::Acquisitions::SearchOrders behaviour. TL;DR: This patch adapts the code from the list() sub so it manipulates the query parameters and the embed header so: - the biblioitem relationship is prefetch - any queries on biblio.isbn and biblio.ean are correctly translated into search on the biblioitems table. - Adds an only_active parameter to the /acquisitions/orders route to easily request only the active orders. Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112705|0 |1 is obsolete| | --- Comment #107 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 114609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114609&action=edit Bug 20212: Add missing relation in Biblio Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112868|0 |1 is obsolete| | --- Comment #109 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 114611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114611&action=edit Bug 20212: (QA follow-up) Remember current filter This patch restores the original behaviour: if you jump into receiving an order, and then go back to receiving, you want the page to remember your filters. This feature was overlooked. On fixing it, I wrapped some JS code in a function for reusing it and simplified it a bit as well. To test: 1. Enter a search term in either of the search fields 2. Add a note, receive or do another action => SUCCESS: The search term is kept 3. Apply this patch set 4. Repeat 2 => SUCCESS: The search term is kept Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #112987|0 |1 is obsolete| | --- Comment #111 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 114613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114613&action=edit Bug 20212: (QA follow-up) Restore table filter sticky Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113279|0 |1 is obsolete| | --- Comment #113 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 114615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114615&action=edit Bug 20212: Make all biblioitems.* fields searchable Prior to this bug, only a few bilbio fields were actually searchable through the orders API. This patch adds all of them to the mapping, so other pages can take advantage of them. My first approach was to add things as needed. But this is trivial to make complete. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #115 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 114617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114617&action=edit Bug 20212: (QA follow-up) Spelling typo fix Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This development changes release notes| |how the orders table on | |receiving in acquisitions | |is rendered. | |Before this | |patches all active orders | |data was fetched from the | |database, along with all | |the related data (patrons, | |biblio). This lead to | |significant delays because | |all orders matching the | |filtering criteria were | |loaded, even when only 20 | |rows are displayed on the | |UI. | |With this patch, the | |table is rendering using | |server-side pagination, | |provided by the REST API. | |This means | |(1) only the | |information to be rendered | |is fetched (faster drawing | |(2) the page doesn't reload | |anymore when a new filter | |is added: it just refreshes | |the table, very fastly. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #117 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- 1. We need a delay between the different AJAX request when filtering the table, otherwise we face weird behaviour and lag (server and browser) 2. Prior to this patch, the "pending orders" table contained orders with status (orderstatus) set to "ordered" or "partial". Now we see them all. See 'pending' and 'ordered' flag of SearchOrders 3. Not blocker but worth noting, we lost the column filter on "Order cost" 4. I don't understand how works the column filters. It's the first view where we introduce it. It would have been interesting to have it on a simpler view (cities?) to understand how it is working. There is this code: 793 // column filter events handling 794 $(".column-filter").each(function () { 795 $(this).on( 'keyup change', function () { It's like we are not using the DT standard way of using column filtering. 5. Code to build the URI is c/p in 794 $(".column-filter").each(function () { and 809 $("#filterform").on("submit", function(e) { 6. In the schema: +__PACKAGE__->has_many( + "biblioitem", + "Koha::Schema::Result::Biblioitem", + { "foreign.biblionumber" => "self.biblionumber" }, + { cascade_copy => 0, cascade_delete => 0 }, +); Why has_many? Why cascade_delete => 0? 7. Not blocker for now, but I think we need some JS functions to display variables coming from the REST API. For instance this code appears a lot: if ( data != null ) { return data.escapeHtml().format_price(); } else { return ""; } or if ( data == null ) { return ""; } else { return data; } 8. In the "render" you have if ( type != 'display' ) { Why are you testing that? The different values are sorting, filtering and display. According to the doc https://datatables.net/reference/option/columns.render 9. There are several places where strings are not escaped At least 2 examples: + return "<a href=\"/cgi-bin/koha/acqui/basketgroup.pl?op=add&booksellerid=" + + row.basket.vendor_id + "&basketgroupid=" + + row.basket.basket_group_id + "\">" + + row.basket.basket_group.name + " (" + row.basket.basket_group_id + ")</a>"; + return "<a href=\"/cgi-bin/koha/acqui/basket.pl?basketno=" + row.basket.basket_id + "\">" + data + " (" + row.basket.basket_id + ")</a>"; Side notes (and my opinion), I don't think we are going into the right direction. The JS code we are adding in our template is not robust, hard to read, and so hard to maintain. Also we will have to rewrite things we have done in TT, like display of patron's name for instance (patron-title.inc). I really would like to see some efforts in improving the readability of the code we have already before adding more. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #119 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- For the status question... I believe new orders should only show if they are standing orders. I haven't tracked if there was a change, but we used to only show ordered and partial - must have changed with standing orders or for them. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #121 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Katrin Fischer from comment #119)

For the status question... I believe new orders should only show if they are standing orders. I haven't tracked if there was a change, but we used to only show ordered and partial - must have changed with standing orders or for them.

Katrina, thanks for that explanation. I've just submitted a follow-up on bug 25670 capturing this behavior, which was actually clear in SearchOrders. I added regression tests as well. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #123 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #117)

1. We need a delay between the different AJAX request when filtering the table, otherwise we face weird behaviour and lag (server and browser)

I didn't manage to reproduce the problem.

2. Prior to this patch, the "pending orders" table contained orders with status (orderstatus) set to "ordered" or "partial". Now we see them all. See 'pending' and 'ordered' flag of SearchOrders

This got fixed on the corresponding bug.

9. There are several places where strings are not escaped

Fixed them all with the follow-up.

Side notes (and my opinion), I don't think we are going into the right direction. The JS code we are adding in our template is not robust, hard to read, and so hard to maintain.

I believe we need to pick a JS framework, and start using it. In the meantime, we should do our best in terms of code reliability and maintainability, as we do. I'd add, that with the complexity this table has, it will look bad no matter what. It contains many layers of nested data, that are now (with the API use) readable, intuitively organized and fully covered by tests. As opposed to the lengthy and hard to maintain .pl files.

Also we will have to rewrite things we have done in TT, like display of patron's name for instance (patron-title.inc). I really would like to see some efforts in improving the readability of the code we have already before adding more.

Yeah, I would love the same. There are many good templating tools for using out there, to pair with the new APIs. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #125 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Tests are failing on fresh DB: t/db_dependent/api/v1/acquisitions_orders.t .. # Failed test 'Only one order is active' # at t/db_dependent/api/v1/acquisitions_orders.t line 130. # got: '0' # expected: '1' And this one if there are orders in the DB: # Failed test 'has value for JSON Pointer "/43/order_id"' # at t/db_dependent/api/v1/acquisitions_orders.t line 76. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #127 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 114953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114953&action=edit Bug 20212: Remove clone We don't need it here. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20212 --- Comment #129 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 114956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114956&action=edit Bug 20212: Use functions to escape variables -- You are receiving this mail because: You are watching all bug changes.