[Bug 10715] New: MARC21 007 Plugin Editor doesn't load position 01
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10715 Bug ID: 10715 Summary: MARC21 007 Plugin Editor doesn't load position 01 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Currently, position 01 isn't loaded into the plugin editor for the 007 field in MARC21. This is because the template expects 1 character but the perl script is trying to pass in 4 characters. I can see no reason for this and when I do a git blame, it looks like this might be an accidental holdover from a past implementation of the plugin editor. If we switch the perl script to pass 1 character instead of 4, the plugin editor works as it should and I see no undesirable behaviours. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10715 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10715 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 20282 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20282&action=edit Bug 10715 - MARC21 007 Plugin Editor doesn't load position 01 This patch changes the MARC21 007 plugin editor so that it uses 1 character instead of 4 characters for position 01. TEST PLAN: 1) Create new record/edit an existing record 2) Using the tag editor for the 007 field, choose "Videorecording" 3) Click OK 4) Change the second character in the 007 from "c" to "d" 5) Open the tag editor again 6) Note that position 01 will still say "c - Videocartridge" rather than "d - Videodisc". 7) Exit tag editor 8) Apply patch 9) Reload the page (Shift + Refresh is always useful) 10) Open the tag editor again 11) Note that position 01 will now say "d - Videodisc" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10715 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10715 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10715 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20282|0 |1 is obsolete| | --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 20334 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20334&action=edit Bug 10715 - MARC21 007 Plugin Editor doesn't load position 01 This patch changes the MARC21 007 plugin editor so that it uses 1 character instead of 4 characters for position 01. TEST PLAN: 1) Create new record/edit an existing record 2) Using the tag editor for the 007 field, choose "Videorecording" 3) Click OK 4) Change the second character in the 007 from "c" to "d" 5) Open the tag editor again 6) Note that position 01 will still say "c - Videocartridge" rather than "d - Videodisc". 7) Exit tag editor 8) Apply patch 9) Reload the page (Shift + Refresh is always useful) 10) Open the tag editor again 11) Note that position 01 will now say "d - Videodisc" Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10715 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10715 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20334|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 20399 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20399&action=edit Bug 10715 - MARC21 007 Plugin Editor doesn't load position 01 This patch changes the MARC21 007 plugin editor so that it uses 1 character instead of 4 characters for position 01. TEST PLAN: 1) Create new record/edit an existing record 2) Using the tag editor for the 007 field, choose "Videorecording" 3) Click OK 4) Change the second character in the 007 from "c" to "d" 5) Open the tag editor again 6) Note that position 01 will still say "c - Videocartridge" rather than "d - Videodisc". 7) Exit tag editor 8) Apply patch 9) Reload the page (Shift + Refresh is always useful) 10) Open the tag editor again 11) Note that position 01 will now say "d - Videodisc" Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10715 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, David! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10715 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- been pushed to 3.12.x, will be in 3.12.5. Thanks David! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10715 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.11 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10715 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz --- Comment #7 from Chris Hall <chrish@catalyst.net.nz> --- Pushed to 3.8.x, will be in 3.8.19 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org