[Bug 32138] New: OIDC client uses backwards default mapping
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32138 Bug ID: 32138 Summary: OIDC client uses backwards default mapping Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org CC: dpavlin@rot13.org The OAuth2 client has a good default mapping, but the OIDC client has the first name and last name mappings backwards. Must be a mistake from an earlier iteration. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32138 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32138 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31378 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 [Bug 31378] Add a generic OAuth2/OIDC client implementation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32138 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32138 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 143451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143451&action=edit Bug 32138: Fix OIDC default mapping This patch fixes the OIDC default mapping to have the Koha fields on the left (ie key) and the OIDC standard claim fields on the right (ie value). 1. Apply the patch 2. Go to http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl?op=add_form 3. Choose "OIDC" for "Protocol" 4. Click "Add default OIDC mapping" 5. Note the following is displayed: { "email": "email", "firstname": "given_name", "surname": "family_name" } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32138 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32138 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143451|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32138 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32138 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 143528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143528&action=edit Bug 32138: Fix OIDC default mapping This patch fixes the OIDC default mapping to have the Koha fields on the left (ie key) and the OIDC standard claim fields on the right (ie value). 1. Apply the patch 2. Go to http://localhost:8081/cgi-bin/koha/admin/identity_providers.pl?op=add_form 3. Choose "OIDC" for "Protocol" 4. Click "Add default OIDC mapping" 5. Note the following is displayed: { "email": "email", "firstname": "given_name", "surname": "family_name" } Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32138 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |22.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32138 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32138 Bug 32138 depends on bug 31378, which changed state. Bug 31378 Summary: Add a generic OAuth2/OIDC client implementation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31378 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org