[Bug 32726] New: Authority search result display and relator terms in 22.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32726 Bug ID: 32726 Summary: Authority search result display and relator terms in 22.05 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs@lists.koha-community.org Reporter: marius.mandrescu@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: dpavlin@rot13.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32726 --- Comment #1 from Marius <marius.mandrescu@inlibro.com> --- Created attachment 145667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145667&action=edit Bug 32726: Authority search result display and relator term This pacht displays the relator term in Authority search results in summary column. 1. Go to authorities-home.pl 2. Do a search by personal names (Take one that has no relator term). 3. Edit the authority. 4. Add a Relator term.(100$e) 5. Check in Authority search results the relator term does not appear in summary. 6. Apply patch. 7. Repeat step 5. Now you should be able to see the telator term in summary. Current status: NEW -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32726 --- Comment #2 from Marius <marius.mandrescu@inlibro.com> --- Created attachment 145757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145757&action=edit Subject: [PATCH] Bug 32726: Authority search result display and relator term This pacht displays the relator term in Authority search results in summary column. 1. Go to authorities-home.pl 2. Do a search by personal names (Take one that has no relator term). 3. Edit the authority. 4. Add a Relator term.(100$e) 5. Check in Authority search results the relator term does not appear in summary. 6. Apply patch. 7. Repeat step 5. Now you should be able to see the telator term in summary. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32726 Blou <philippe.blouin@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11083 Assignee|koha-bugs@lists.koha-commun |marius.mandrescu@inlibro.co |ity.org |m CC| |caroline.cyr-la-rose@inlibr | |o.com, | |marius.mandrescu@inlibro.co | |m, | |philippe.blouin@inlibro.com Component|Authentication |MARC Authority data support Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff --- Comment #3 from Blou <philippe.blouin@inlibro.com> --- Seems to be a correction for a display issue caused by Bug 11083. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32726 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- Should there be two patches with similar titles and contents? Maybe this should be squashed - not sure of the protocol here... (Can confirm it works, so happy to sign off.) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32726 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to David Nind from comment #4)
Should there be two patches with similar titles and contents?
Maybe this should be squashed - not sure of the protocol here...
(Can confirm it works, so happy to sign off.)
Same author. One should squash the two patches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32726 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Blou from comment #3)
Seems to be a correction for a display issue caused by Bug 11083.
I think not. Looks like en enhancement. And this is strange : In perl : heading => $field->as_string(), relator => ( $field->subfield( 'e' ) // undef ), In TT : [% authorize.heading | html %] [% authorize.relator | html %] "authorize.heading" should already contain subfield $e no ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32726 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11083 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083 [Bug 11083] Authority search result display in staff interface should be XSLT driven -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32726 Bug 32726 depends on bug 11083, which changed state. Bug 11083 Summary: Authority search result display in staff interface should be XSLT driven https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32726 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11083 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32726 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |phil@chetcolibrary.org --- Comment #7 from Phil Ringnalda <phil@chetcolibrary.org> --- No, with more context authorize.heading doesn't contain $e, because in $subfields_to_report = $handler->get_auth_heading_subfields_to_report($tag); if ($subfields_to_report) { push @authorized, { heading => $field->as_string($subfields_to_report), hemain => ( $field->subfield( substr($subfields_to_report, 0, 1) ) // undef ), field => $tag, }; } else { push @authorized, { heading => $field->as_string(), hemain => ( $field->subfield( 'a' ) // undef ), field => $tag, }; } $subfields_to_report will be true for 100/110/111 and will not include the relator subfield (which is $e for 100/110, but $j for 111), because it is not what people tend to think it is. In an authority record, the relator describes the relationship between the name and the work in a name-title heading, like "$aBlum, Leon,$d1872-1950,$edefendant$tLeon Blum devant la Cour supreme, Riom.$lHebrew" as explained in https://www.loc.gov/marc/authority/adx00.html Having a 100/110 with a $e but no $t or a 111 with a $j but no $t is wrong. That doesn't necessarily mean that Koha shouldn't show it (particularly because it autocreated authority records that way for years), but not with this patch: blindly adding $e to every heading whether it's defined as relator, defined as something other than relator (it's a repeatable "subordinate unit" subfield for meeting names), or undefined, is not the right solution. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32726 Bug 32726 depends on bug 11083, which changed state. Bug 11083 Summary: Authority search result display in staff interface should be XSLT driven https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |Needs documenting Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32726 Bug 32726 depends on bug 11083, which changed state. Bug 11083 Summary: Authority search result display in staff interface should be XSLT driven https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11083 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32726 Shi Yao Wang <shi-yao.wang@inLibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shi-yao.wang@inLibro.com --- Comment #8 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- (In reply to Phil Ringnalda from comment #7)
No, with more context authorize.heading doesn't contain $e, because in
$subfields_to_report = $handler->get_auth_heading_subfields_to_report($tag);
if ($subfields_to_report) { push @authorized, { heading => $field->as_string($subfields_to_report), hemain => ( $field->subfield( substr($subfields_to_report, 0, 1) ) // undef ), field => $tag, }; } else { push @authorized, { heading => $field->as_string(), hemain => ( $field->subfield( 'a' ) // undef ), field => $tag, }; }
$subfields_to_report will be true for 100/110/111 and will not include the relator subfield (which is $e for 100/110, but $j for 111), because it is not what people tend to think it is. In an authority record, the relator describes the relationship between the name and the work in a name-title heading, like "$aBlum, Leon,$d1872-1950,$edefendant$tLeon Blum devant la Cour supreme, Riom.$lHebrew" as explained in https://www.loc.gov/marc/authority/adx00.html
Having a 100/110 with a $e but no $t or a 111 with a $j but no $t is wrong. That doesn't necessarily mean that Koha shouldn't show it (particularly because it autocreated authority records that way for years), but not with this patch: blindly adding $e to every heading whether it's defined as relator, defined as something other than relator (it's a repeatable "subordinate unit" subfield for meeting names), or undefined, is not the right solution.
What would be an ideal solution for this bug? Only add the relator $e for 100/110 and $j for 111? Are there more relator fields other than those? Is hardcoding for every possible relator a good solution? (I would think it's not) I'm not familiar enough with marc. Suggestions? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32726 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |heather_hernandez@nps.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32726 --- Comment #9 from Phil Ringnalda <phil@chetcolibrary.org> --- The ideal solution would be to invent time travel, use it to go back to the MARC Advisory Committee meeting where defining a relator in name authorities only for use in name-title authorities was approved, and convince them that it was a terrible idea which would never be used correctly, only incorrectly. Second best solution would be to implement the FIXME in https://git.koha-community.org/Koha-community/Koha/src/commit/5a188651e48451... and move the definition of which subfields belong in bib records and which belong in authority records from a hardcoded set affecting everyone to a configuration file where individual libraries can choose to do things in a non-interoperable way. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32726 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145667|0 |1 is obsolete| | --- Comment #10 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 179881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179881&action=edit Bug 32726: Authority search result display and relator term This pacht displays the relator term in Authority search results in summary column. 1. Go to authorities-home.pl 2. Do a search by personal names (Take one that has no relator term). 3. Edit the authority. 4. Add a Relator term.(100$e) 5. Check in Authority search results the relator term does not appear in summary. 6. Apply patch. 7. Repeat step 5. Now you should be able to see the telator term in summary. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32726 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145757|0 |1 is obsolete| | --- Comment #11 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 179882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=179882&action=edit Subject: [PATCH] Bug 32726: Authority search result display and relator term This pacht displays the relator term in Authority search results in summary column. 1. Go to authorities-home.pl 2. Do a search by personal names (Take one that has no relator term). 3. Edit the authority. 4. Add a Relator term.(100$e) 5. Check in Authority search results the relator term does not appear in summary. 6. Apply patch. 7. Repeat step 5. Now you should be able to see the telator term in summary. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32726 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think the "in 22.05" in the description could be removed? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32726 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|marius.mandrescu@inlibro.co | |m | Assignee|marius.mandrescu@inlibro.co |hammat.wele@inlibro.com |m | Summary|Authority search result |Add relator terms to |display and relator terms |authority search results |in 22.05 |display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32726 Miranda Nero <mnero@oslri.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mnero@oslri.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32726 --- Comment #13 from Blou <philippe.blouin@inlibro.com> --- We're not in the business of ideal solution, frankly. We're trying for practical solutions, because the ideal ones do not move ahead and we're already over two years later. So what is a practical alternative ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32726 --- Comment #14 from Phil Ringnalda <phil@chetcolibrary.org> --- There's one, "Second best solution," in comment 9, and another, add relators to display but not by adding subfield e to every heading no matter what subfield e is for that field, in comment 7. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32726 --- Comment #15 from Blou <philippe.blouin@inlibro.com> --- (In reply to Phil Ringnalda from comment #14)
There's one, "Second best solution," in comment 9, and another, add relators to display but not by adding subfield e to every heading no matter what subfield e is for that field, in comment 7.
Well, comment 9 is a whole new functionnality. We're not going through the process of trying to get an external config file approved. Nor create a new pref ui for it. Comment 7 is rather vague. Clear in what not to do, but that doesn't enlighten our dev as to what to do. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org