[Bug 17554] New: Move GetBorrowersWithEmail to Koha::Patron
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Bug ID: 17554 Summary: Move GetBorrowersWithEmail to Koha::Patron Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart@bugs.koha-community.org Reporter: jonathan.druart@bugs.koha-community.org QA Contact: testopia@bugs.koha-community.org C4::Members::GetBorrowersWithEmail can be easily replaced with Koha::Patrons->search({ email => $email }); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16846 [Bug 16846] Move patron related code to Koha::Patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57207&action=edit Bug 17554: Koha::Patrons - Remove GetBorrowersWithEmail C4::Members::GetBorrowersWithEmail can be easily replaced with Koha::Patrons->search({ email => $email }); Test plan: Confirm that you are still able to use Persona for login http://translate.koha-community.org/manual/master/en/html-desktop/#mozillape... For QA: Note that this is also use for the PKI authentication But as the code is the same I don't think it's needed to test both. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57207|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 57208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57208&action=edit Bug 17554: Koha::Patrons - Remove GetBorrowersWithEmail C4::Members::GetBorrowersWithEmail can be easily replaced with Koha::Patrons->search({ email => $email }); Test plan: Confirm that you are still able to use Persona for login http://translate.koha-community.org/manual/master/en/html-desktop/#mozillape... For QA: Note that this is also use for the PKI authentication But as the code is the same I don't think it's needed to test both. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57208|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58184&action=edit Bug 17554: Koha::Patrons - Remove GetBorrowersWithEmail C4::Members::GetBorrowersWithEmail can be easily replaced with Koha::Patrons->search({ email => $email }); Test plan: Confirm that you are still able to use PKI authentication -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17486 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486 [Bug 17486] Remove 'Mozilla Persona' as an authentication method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58184|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 58486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58486&action=edit Bug 17554: Koha::Patrons - Remove GetBorrowersWithEmail C4::Members::GetBorrowersWithEmail can be easily replaced with Koha::Patrons->search({ email => $email }); Test plan: Confirm that you are still able to use PKI authentication -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Bug 17554 depends on bug 17486, which changed state. Bug 17486 Summary: Remove 'Mozilla Persona' as an authentication method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17486 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Alternative test plan: read the changes and confirm that they make sense. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18144 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17829 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17829 [Bug 17829] Move GetMember to Koha::Patron -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Looks like a solid change to me, but I can't get it to apply :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58486|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 62956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62956&action=edit Bug 17554: Koha::Patrons - Remove GetBorrowersWithEmail C4::Members::GetBorrowersWithEmail can be easily replaced with Koha::Patrons->search({ email => $email }); Test plan: Confirm that you are still able to use PKI authentication -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62956|0 |1 is obsolete| | --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 64660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64660&action=edit Bug 17554: Koha::Patrons - Remove GetBorrowersWithEmail C4::Members::GetBorrowersWithEmail can be easily replaced with Koha::Patrons->search({ email => $email }); Test plan: Confirm that you are still able to use PKI authentication Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 64661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64661&action=edit Bug 17554: (followup) Shibboleth check should use ->find too There was a remaining use of C4::Members::GetBorrowersWithEmail in Auth.pm. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Simple patch, pretty trivial. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m Status|Pushed to Master |RESOLVED --- Comment #12 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17554 --- Comment #13 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 17.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org