[Bug 13375] New: Syspref search highlight styling broken in Chrome
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13375 Bug ID: 13375 Summary: Syspref search highlight styling broken in Chrome Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org To reproduce: - Do a syspref search, for example 'facet'. => FAIL: Some highlighted occurences of 'facet' have styling problems, check the attached screenshots. Note: Firefox seems to render it properly, this is just in Chrome. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13375 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 34075 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34075&action=edit Before the patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13375 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 34076 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34076&action=edit After the patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13375 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13375 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 34077 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34077&action=edit Bug 13375: Syspref search highlight styling broken in Chrome This patch encloses the the syspref description/values mix into a <span>. It doesn't introduce any regression on other browsers (like Firefox) and has the side effect to make Chrome render the highlighted words on syspref searches well. To test: - Search for 'facet' on the sysprefs => FAIL: verify it has styling problems in Chrome - Apply the patch, reload => SUCCESS: styling is correct - Sign off :-D Regards -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13375 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34077|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 34092 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34092&action=edit Bug 13375 [Alternate] Syspref search highlight styling broken in Chrome This patch encloses the the syspref description/values mix in a <div>. It doesn't introduce any regression on other browsers (like Firefox) and has the side effect to make Chrome render the highlighted words on syspref searches well. This alternate patch uses a <div> instead of a <span> because it will sometimes contain block-level elements. Follow the same plan: To test: - Search for 'facet' on the sysprefs => FAIL: verify it has styling problems in Chrome - Apply the patch, reload => SUCCESS: styling is correct -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13375 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13375 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34092|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 34093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34093&action=edit [SIGNED OFF] Bug 13375: Syspref search highlight styling broken in Chrome This patch encloses the the syspref description/values mix in a <div>. It doesn't introduce any regression on other browsers (like Firefox) and has the side effect to make Chrome render the highlighted words on syspref searches well. This alternate patch uses a <div> instead of a <span> because it will sometimes contain block-level elements. Follow the same plan: To test: - Search for 'facet' on the sysprefs => FAIL: verify it has styling problems in Chrome - Apply the patch, reload => SUCCESS: styling is correct Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13375 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13375 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34093|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34144&action=edit [PASSED QA] Bug 13375: Syspref search highlight styling broken in Chrome This patch encloses the the syspref description/values mix in a <div>. It doesn't introduce any regression on other browsers (like Firefox) and has the side effect to make Chrome render the highlighted words on syspref searches well. This alternate patch uses a <div> instead of a <span> because it will sometimes contain block-level elements. Follow the same plan: To test: - Search for 'facet' on the sysprefs => FAIL: verify it has styling problems in Chrome - Apply the patch, reload => SUCCESS: styling is correct Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13375 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13375 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |3.18 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org