[Bug 7043] New: masthead_search id used twice in template
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7043 Bug #: 7043 Summary: masthead_search id used twice in template Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: OPAC AssignedTo: oleonard@myacpl.org ReportedBy: nengard@gmail.com QAContact: koha-bugs@lists.koha-community.org masthead_search is the ID of two selected on the OPAC - IDs should be unique. <select name="idx" id="masthead_search" class="left" style="max-width: 10em; width: 10em;"> <select name="limit" id="masthead_search" class="left" style="max-width: 10em; width: 10em;"> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7043 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-10-17 14:07:41 UTC --- If someone is already in there... it would be nice if the style could be moved into the CSS files, so that width can be changed easier. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7043 --- Comment #2 from Nicole C. Engard <nengard@gmail.com> 2011-10-17 14:09:45 UTC --- I was going to edit the ID bit, but don't know much about moving things to the CSS so I'll leave this one to Owen to make it just right :) Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7043 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7043 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> 2011-10-17 15:54:18 UTC --- Created attachment 5933 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5933 Proposed fix Changing ID of library selector and moving inline styles to the CSS. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7043 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7043 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #5933|0 |1 is obsolete| | --- Comment #4 from Nicole C. Engard <nengard@gmail.com> 2011-10-17 15:57:40 UTC --- Created attachment 5934 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5934 [SIGNED-OFF] Fix for Bug 7043 - masthead_search id used twice in template Changing ID of library selector, and moving inline styles to the CSS as requested by kf in the bug comments. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7043 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7043 Ian Walls <ian.walls@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ian.walls@bywatersolutions. | |com Patch Status|Signed Off |Passed QA --- Comment #5 from Ian Walls <ian.walls@bywatersolutions.com> 2011-10-17 16:09:23 UTC --- Simple template only change, improves compliance with standards. No string changes. Marking as Passed QA. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7043 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #6 from Chris Cormack <chris@bigballofwax.co.nz> 2011-10-18 03:08:01 UTC --- Pushed to master, please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7043 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> 2011-11-27 21:47:35 UTC --- Checked on current HEAD. OpacAddMastheadLibraryPulldown has to be turned on to see select_library id in the source code. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org