[Bug 40156] New: Advanced editor should not create empty fields and subfields
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40156 Bug ID: 40156 Summary: Advanced editor should not create empty fields and subfields Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs@lists.koha-community.org Reporter: januszop@gmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Currently, advanced bibliographic records editor creates empty subfields (or even empty fields) when no content is placed after ‡<code> (or, in case of control fields, after <tag>). To reproduce: 1. Enable EnableAdvancedCatalogingEditor. 2. Open a record in the advanced editor, create empty subfield and empty fields, i.e.: 007 500 _ _ ‡a 246 3 1 ‡aAdditional title :‡b 3. Save the record. Go to bibliographic record Normal view and in modal "MARC preview" notice that the fields / subfields you entered as empty exist in the record with no data. This is wrong. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40156 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40156 --- Comment #1 from Janusz Kaczmarek <januszop@gmail.com> --- Created attachment 183301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183301&action=edit Bug 40156: Advanced editor should not create empty fields and subfields Currently, advanced bibliographic records editor creates empty subfields (or even empty fields) when no content is placed after ‡<code> (or, in case of control fields, after <tag>). Test plan: ========== 1. Enable EnableAdvancedCatalogingEditor (have StripWhitespaceChars set to "Don't strip" - the default setting). 2. Open a record in the advanced editor, create empty subfield and empty fields, e.g.: 007 500 _ _ ‡a 246 3 1 ‡aAdditional title :‡b 3. Save the record. Go to bibliographic record Normal view and in modal "MARC preview" notice that the fields / subfields you entered as empty exist in the record with no data. This is wrong. 4. Apply the patch ; restart_all. 5. Repeat p. 2 and 3. Note that empty fields/subfields have not been created. Sponsored-by: Ignatianum University in Cracow -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40156 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Assignee|koha-bugs@lists.koha-commun |januszop@gmail.com |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40156 Wojciech <wojciech.baran@ignatianum.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183301|0 |1 is obsolete| | --- Comment #2 from Wojciech <wojciech.baran@ignatianum.edu.pl> --- Created attachment 183309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183309&action=edit Bug 40156: Advanced editor should not create empty fields and subfields Currently, advanced bibliographic records editor creates empty subfields (or even empty fields) when no content is placed after ‡<code> (or, in case of control fields, after <tag>). Test plan: ========== 1. Enable EnableAdvancedCatalogingEditor (have StripWhitespaceChars set to "Don't strip" - the default setting). 2. Open a record in the advanced editor, create empty subfield and empty fields, e.g.: 007 500 _ _ ‡a 246 3 1 ‡aAdditional title :‡b 3. Save the record. Go to bibliographic record Normal view and in modal "MARC preview" notice that the fields / subfields you entered as empty exist in the record with no data. This is wrong. 4. Apply the patch ; restart_all. 5. Repeat p. 2 and 3. Note that empty fields/subfields have not been created. Sponsored-by: Ignatianum University in Cracow Signed-off-by: Wojciech Baran <wojciech.baran@ignatianum.edu.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40156 Wojciech <wojciech.baran@ignatianum.edu.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wojciech.baran@ignatianum.e | |du.pl Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40156 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40156 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #183309|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 184977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184977&action=edit Bug 40156: Advanced editor should not create empty fields and subfields Currently, advanced bibliographic records editor creates empty subfields (or even empty fields) when no content is placed after ‡<code> (or, in case of control fields, after <tag>). Test plan: ========== 1. Enable EnableAdvancedCatalogingEditor (have StripWhitespaceChars set to "Don't strip" - the default setting). 2. Open a record in the advanced editor, create empty subfield and empty fields, e.g.: 007 500 _ _ ‡a 246 3 1 ‡aAdditional title :‡b 3. Save the record. Go to bibliographic record Normal view and in modal "MARC preview" notice that the fields / subfields you entered as empty exist in the record with no data. This is wrong. 4. Apply the patch ; restart_all. 5. Repeat p. 2 and 3. Note that empty fields/subfields have not been created. Sponsored-by: Ignatianum University in Cracow Signed-off-by: Wojciech Baran <wojciech.baran@ignatianum.edu.pl> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40156 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40156 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40156 --- Comment #4 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40156 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40156 --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40156 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable CC| |fridolin.somers@biblibre.co | |m Version(s)|25.11.00,25.05.03 |25.11.00,25.05.03,24.11.09 released in| | --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40156 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org