https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32298 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |matt.blenkinsop@ptfs-europe |ity.org |.com CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32298 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32298 Hammat wele <hammat.wele@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144111|0 |1 is obsolete| | --- Comment #2 from Hammat wele <hammat.wele@inlibro.com> --- Created attachment 144118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144118&action=edit Bug_32298 - Page section added to cataloguing search Div added to "Records found in this catalog", page section class added to "Records found in the reservoir". Level two heading changed and horizontal line removed as it is now superfluous Test plan: 1) Apply patch from bug 32298 2) Navigate to Cataloging 3) Enter a search into the search field and run the search 4) Verify that the white page section identifier is now visible around both sections Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32298 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32298 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Matt, congrats on your first patch! :) Some small stuff: * The commit message always needs to start with: Bug XXXX: - this helps with our tools and also gives some consistency in the commit message. You can find information on how to write good commit messages in the wiki: https://wiki.koha-community.org/wiki/Commit_messages. If you run the qa test tools on your patches, they will also alert you of issues like this. on ktd in the shell: qa -v 2 * Not a problem, but maybe you'd want to change the first bit to use a formatted name: mattblenkinsop <matt.blenkinsop@ptfs-europe.com>. This should come from GIT_USER_NAME= in the .env of ktd. I have Katrin Fischer there and it works with the blank and without quotes. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32298 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144150|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 144151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144151&action=edit Bug 32298: Page section added to cataloguing search Added div to "Records found in this catalog". Added page-section class to "Records found in the reservoir". Corrected level two heading and removed horizontal line as it is now superfluous. Test plan: 1) Apply patch from bug 32298 2) Navigate to Cataloging 3) Enter a search into the search field and run the search 4) Verify that the white page section identifier is now visible around both sections Mentored-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Sponsored-by: PTFS Europe Signed-off-by: Hammat Wele <hammat.wele@inlibro.com> Signed-off-by: Katrin <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32298 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Interesting, I am missing my last name. This was the first patch I signed from the new laptop, will have to go check. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32298 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.