[Bug 21781] New: message_transport_type should allow fallbacks
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Bug ID: 21781 Summary: message_transport_type should allow fallbacks Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: martin.renvoize@ptfs-europe.com QA Contact: testopia@bugs.koha-community.org Bug 21241 adds the ability for a fallback from email to sms when a patron email address isn't found on the suggestions notices. This shouldn't be limited to suggestions, but be a more comprehensive piece of work to capture other hard coded message transports. opac/svc/checkout_notes opac/opac-issue-note.pl opac/opac-memberentry.pl opac/opac-shareshelf.pl circ/pendingreserves.pl circ/article-request-slip.pl C4/Reserves.pm C4/Acquisition.pm misc/cronjobs/automatic_renewals.pl misc/cronjobs/membership_expiry.pl misc/cronjobs/stockrotation.pl Koha/ArticleRequests.pm Koha/Patron/Password/Recovery.pm Koha/Account.pm All of the above have a message_transport_type hard coded to some degree.. some may be better served left as is.. but many would benefit from a fallback. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alexbuckley@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21241 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21241 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 [Bug 21241] Set suggestion notices message_transport_type to sms if syspref is enabled and patron has an smsalertnumber but no email address -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Bug 21781 depends on bug 21241, which changed state. Bug 21241 Summary: Set suggestion notices message_transport_type to sms if syspref is enabled and patron has an smsalertnumber but no email address https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21241 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=5501 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22744 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 --- Comment #1 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 103525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103525&action=edit Bug 21781: Fallback to SMS if no email address where email address hardcoded Extend use of FallbackToSMSIfNoEmail syspref to fallback to SMS if no patron email address outside of it's current usage sending suggestion notices. Test plan for C4/Acquisitions.pm: 1. Input a value into SMSSendDriver syspref 2. Create a patron with sms (under Member messaging preferences) and no email address 3. In Acquistions module make currency, active budget, fund, vendor 4. Create a basket 5. Add to basket. Click to add 'From a new (empty) record' 6. Under 'Patrons' header add a user and search for your patron (added in #1) 7. Submit new order 8. Receive the order: 'Close this basket' 'Receive shipment' Submit invoice page Select 'Receive' link on right hand side of page Tick checkbox to add 1 quantity of item and Save 9. Revisit your patrons page and in the 'Notices' tab you'll see a 'Order received' notice with type of 'email' 11. Apply patch and restart plack 12. Repeat steps 4-9 and observe the 'Order received' notice has a type of SMS Test plan for amendment to circ/pendingreserves.pl (patch has been applied in 'Test plan for C4/Acquidsitions.pm): 1. Set 'FallbackToSMSIfNoEmail' syspref to 'Disable' 2. Set CanMarkHoldsToPullAsLost syspref to 'Allow to mark items as lost and notify the patron' 3. Using the patron from test plan for C4/Acquisitions.pm (i.e. sms alert number and no email) place a hold on an item currently available 4. Visit Circulation > Holds to pull 5. Select 'Mark lost and notify patron' 6. Return to patron page look in 'Notices' tab and observe 'Hold has been cancelled' notice has type of 'email' 7. Change 'FallbackToSMSIfNoEmail' to 'Enable' and repeat steps 3,4,5,6 and observe the new 'Hold has been cancelled' notice has type 'sms' Test plan for amendment to misc/cronjobs/automatic_renewals.pl (patch has been applied already): 1. Set 'FallbackToSMSIfNoEmail' syspref to 'Disable' 2. Enable automatic renewals in Administration > Circulation and fine rules 3. Checkout an item to our patron and set due date in the past 4. cd into misc/cronjobs 5. Jump into koha-shell and run automatic_renewals.pl cronjob sudo koha-shell <instancename> ./automatic_renewals.pl --confirm --send-notices 6. Observe in patron records 'Notices' tab there is a 'Auto renewals' notice with type 'email' 7. Set 'FallbackToSMSIfNoEmail' syspref to 'Enable' and repeat steps 3,4,5,6 and observe the new 'Auto renewals' notice is type 'sms' Test plan for amendment to misc/cronjobs/membership_expiry.pl (patch has been applied already): 1. Set 'FallbackToSMSIfNoEmail' syspref to 'Disable' 2. Set 'MembershipExpiryDaysNotice' to '1' 3. Edit our patrons record setting 'Expiry date' to 1 day in future 4. cd to misc/cronjobs directory 5. Jump into koha-shell and run membership_expiry.pl cronjob: sudo koha-shell <instancename> ./membership_expiry.pl -c 6. Visit the patron record's 'Notices' tab and observe 'Account expiration' notice with type 'email' 7. Change 'FallbackToSMSIfNoEmail' syspref to 'Enable' 8. Reset patrons epxiration date to 1 day in future 9. Repeat step 4,5,6 and observe new 'Account expiration' notice is type 'sms' Test plan for opac/opac-shareshelf.pl (patch has been applied already): 1. Set 'FallbackToSMSIfNoEmail' syspref to 'Disable' 2. Set 'OpacAllowSharingPrivateLists' syspref to 'Allow' 3. Ensure OPACBaseURL is set 4. In OPAC log in as the patron with set smsalertnumber and no email 5. Create a private list, select 'Share' link, input email address and submit 6. Back in staff client make a new patron record 7. Return to OPAC and login as patron from step #5 8. Query database: select content from message_queue where letter_code='SHARE_INVITE'; 9. Click on the link in the message_queue notice 10. OPAC loads 11. Query database again: select to_address, message_transport_type from message_queue where letter_code='SHARE_ACCEPT'; 12. Observe there is no 'Share on list <listname> accepted' notice 13. Set 'FallbackToSMSIfNoEmail' to 'Enable' and repeat steps 4,5,7,8, 9,10,11,12 and observe there is a 'Share on list <listname> accepted' notice with to_address = smsalertnumber and message_transport_type is 'sms' 14. Set 'FallbackToSMSIfNoEmail' to 'disable' and edit the patron with smsalertnumber set and no email setting an email address and repeat steps 4,5,7,8,9,10,11,12 and observe there is a 'Share on list <listname> accepted' notice with the to_address of the email you set and message_transport_type of 'email' Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103525|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 103526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103526&action=edit Bug 21781: Fallback to SMS if no email address where email address hardcoded Extend use of FallbackToSMSIfNoEmail syspref to fallback to SMS if no patron email address outside of it's current usage sending suggestion notices. Test plan for C4/Acquisition.pm: 1. Input a value into SMSSendDriver syspref 2. Create a patron with sms (under Member messaging preferences) and no email address 3. In Acquistions module make currency, active budget, fund, vendor 4. Create a basket 5. Add to basket. Click to add 'From a new (empty) record' 6. Under 'Patrons' header add a user and search for your patron (added in #1) 7. Submit new order 8. Receive the order: 'Close this basket' 'Receive shipment' Submit invoice page Select 'Receive' link on right hand side of page Tick checkbox to add 1 quantity of item and Save 9. Revisit your patrons page and in the 'Notices' tab you'll see a 'Order received' notice with type of 'email' 11. Apply patch and restart plack 12. Repeat steps 4-9 and observe the 'Order received' notice has a type of SMS Test plan for amendment to circ/pendingreserves.pl (patch has been applied in 'Test plan for C4/Acquisition.pm): 1. Set 'FallbackToSMSIfNoEmail' syspref to 'Disable' 2. Set CanMarkHoldsToPullAsLost syspref to 'Allow to mark items as lost and notify the patron' 3. Using the patron from test plan for C4/Acquisitions.pm (i.e. sms alert number and no email) place a hold on an item currently available 4. Visit Circulation > Holds to pull 5. Select 'Mark lost and notify patron' 6. Return to patron page look in 'Notices' tab and observe 'Hold has been cancelled' notice has type of 'email' 7. Change 'FallbackToSMSIfNoEmail' to 'Enable' and repeat steps 3,4,5,6 and observe the new 'Hold has been cancelled' notice has type 'sms' Test plan for amendment to misc/cronjobs/automatic_renewals.pl (patch has been applied already): 1. Set 'FallbackToSMSIfNoEmail' syspref to 'Disable' 2. Enable automatic renewals in Administration > Circulation and fine rules 3. Checkout an item to our patron and set due date in the past 4. cd into misc/cronjobs 5. Jump into koha-shell and run automatic_renewals.pl cronjob sudo koha-shell <instancename> ./automatic_renewals.pl --confirm --send-notices 6. Observe in patron records 'Notices' tab there is a 'Auto renewals' notice with type 'email' 7. Set 'FallbackToSMSIfNoEmail' syspref to 'Enable' and repeat steps 3,4,5,6 and observe the new 'Auto renewals' notice is type 'sms' Test plan for amendment to misc/cronjobs/membership_expiry.pl (patch has been applied already): 1. Set 'FallbackToSMSIfNoEmail' syspref to 'Disable' 2. Set 'MembershipExpiryDaysNotice' to '1' 3. Edit our patrons record setting 'Expiry date' to 1 day in future 4. cd to misc/cronjobs directory 5. Jump into koha-shell and run membership_expiry.pl cronjob: sudo koha-shell <instancename> ./membership_expiry.pl -c 6. Visit the patron record's 'Notices' tab and observe 'Account expiration' notice with type 'email' 7. Change 'FallbackToSMSIfNoEmail' syspref to 'Enable' 8. Reset patrons epxiration date to 1 day in future 9. Repeat step 4,5,6 and observe new 'Account expiration' notice is type 'sms' Test plan for opac/opac-shareshelf.pl (patch has been applied already): 1. Set 'FallbackToSMSIfNoEmail' syspref to 'Disable' 2. Set 'OpacAllowSharingPrivateLists' syspref to 'Allow' 3. Ensure OPACBaseURL is set 4. In OPAC log in as the patron with set smsalertnumber and no email 5. Create a private list, select 'Share' link, input email address and submit 6. Back in staff client make a new patron record 7. Return to OPAC and login as patron from step #5 8. Query database: select content from message_queue where letter_code='SHARE_INVITE'; 9. Click on the link in the message_queue notice 10. OPAC loads 11. Query database again: select to_address, message_transport_type from message_queue where letter_code='SHARE_ACCEPT'; 12. Observe there is no 'Share on list <listname> accepted' notice 13. Set 'FallbackToSMSIfNoEmail' to 'Enable' and repeat steps 4,5,7,8, 9,10,11,12 and observe there is a 'Share on list <listname> accepted' notice with to_address = smsalertnumber and message_transport_type is 'sms' 14. Set 'FallbackToSMSIfNoEmail' to 'disable' and edit the patron with smsalertnumber set and no email setting an email address and repeat steps 4,5,7,8,9,10,11,12 and observe there is a 'Share on list <listname> accepted' notice with the to_address of the email you set and message_transport_type of 'email' Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi all, I've attached a patch which extends the use of FallbackToSMSIfNoEmail syspref to the following files which Martin noted: * opac/opac-shareshelf.pl * misc/cronjobs/membership_expiry.pl * misc/cronjobs/automatic_renewals.pl * circ/pendingreserves.pl * C4/Acquisition.pm I've included an individual test plan for each of these files to test the changes. The individual test plans are sequential though, so you can start testing 'Test plan for C4/Acquisition.pm' where you apply the patch and then you keep it applied through all the other test plans. The following files I have not included for the following rationale, very happy to discuss if you disagree :) * opac/svc/checkout_notes -> Sends 'CHECKOUT_NOTE' notice to library inbound email address if AllowCheckoutNotes * opac/opac-issue-note.pl -> ditto * opac/opac-memberentry.pl -> Sends 'OPAC_REG_VERIFY' notice to entered email address, defining sms address should be on separate bug report * opac/opac-shareshelf.pl -> One of 2 hardcoded message_transport_types I have made. Regarding unchanged one this is unchanged as 'SHARE_INVITE' notice sent to inputted sharee email address. Defining sharee sms number should be different bug report * circ/article-request-slip.pl -> Hardcoded message_transport_type of 'print' on master * C4/Reserves.pm -> Sends 'HOLDPLACED' notice to library inbound email address if 'emailLibrarianWhenHoldIsPlaced' syspref is enabled * misc/cronjobs/stockrotation.pl -> Sends 'SR_SLIP' stock rotation report notice to library inbound email address or KohaAdminEmailAddress * Koha/ArticleRequests.pm -> No longer contains notice being queued * Koha/Patron/Password/Recovery.pm -> Hardcoded message_transport_type for 'PASSWORD_RESET' is requiring email from OpacResetPassword syspref * Koha/Account.pm -> Requires email to be hardcoded as only run if UseEmailReceipts is enabled Thanks, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Extended notice release notes| |message_transport_type | |fallback functionality | |implemented by | |FallbackToSMSIfNoEmail | |system preference to: | |cronjobs (membership | |expiry, automatic renewal), | |opac-shareshelf.pl (sending | |of SHARE_ACCEPT notice when | |list share accepted), | |circ/pendingreserves.pl | |(sending | |'CANCEL_HOLD_ON_LOST' | |notice when reserved item | |marked lost in Holds to | |pull), C4/Acquisition.pm | |(sending | |'ACQ_NOTIF_ON_RECEIV' | |notice to notify order user | |of order receival) Status|NEW |Needs Signoff Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz --- Comment #4 from Alex Buckley <alexbuckley@catalyst.net.nz> --- *** Bug 21776 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103526|0 |1 is obsolete| | --- Comment #5 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 105328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105328&action=edit Bug 21781: Fallback to SMS if no email address where email address hardcoded Extend use of FallbackToSMSIfNoEmail syspref to fallback to SMS if no patron email address outside of it's current usage sending suggestion notices. Test plan for C4/Acquisition.pm: 1. Input a value into SMSSendDriver syspref 2. Create a patron with sms (under Member messaging preferences) and no email address 3. In Acquistions module make currency, active budget, fund, vendor 4. Create a basket 5. Add to basket. Click to add 'From a new (empty) record' 6. Under 'Patrons' header add a user and search for your patron (added in #1) 7. Submit new order 8. Receive the order: 'Close this basket' 'Receive shipment' Submit invoice page Select 'Receive' link on right hand side of page Tick checkbox to add 1 quantity of item and Save 9. Revisit your patrons page and in the 'Notices' tab you'll see a 'Order received' notice with type of 'email' 11. Apply patch and restart plack 12. Repeat steps 4-9 and observe the 'Order received' notice has a type of SMS Test plan for amendment to circ/pendingreserves.pl (patch has been applied in 'Test plan for C4/Acquisition.pm): 1. Set 'FallbackToSMSIfNoEmail' syspref to 'Disable' 2. Set CanMarkHoldsToPullAsLost syspref to 'Allow to mark items as lost and notify the patron' 3. Using the patron from test plan for C4/Acquisitions.pm (i.e. sms alert number and no email) place a hold on an item currently available 4. Visit Circulation > Holds to pull 5. Select 'Mark lost and notify patron' 6. Return to patron page look in 'Notices' tab and observe 'Hold has been cancelled' notice has type of 'email' 7. Change 'FallbackToSMSIfNoEmail' to 'Enable' and repeat steps 3,4,5,6 and observe the new 'Hold has been cancelled' notice has type 'sms' Test plan for amendment to misc/cronjobs/automatic_renewals.pl (patch has been applied already): 1. Set 'FallbackToSMSIfNoEmail' syspref to 'Disable' 2. Enable automatic renewals in Administration > Circulation and fine rules 3. Checkout an item to our patron and set due date in the past 4. cd into misc/cronjobs 5. Jump into koha-shell and run automatic_renewals.pl cronjob sudo koha-shell <instancename> ./automatic_renewals.pl --confirm --send-notices 6. Observe in patron records 'Notices' tab there is a 'Auto renewals' notice with type 'email' 7. Set 'FallbackToSMSIfNoEmail' syspref to 'Enable' and repeat steps 3,4,5,6 and observe the new 'Auto renewals' notice is type 'sms' Test plan for amendment to misc/cronjobs/membership_expiry.pl (patch has been applied already): 1. Set 'FallbackToSMSIfNoEmail' syspref to 'Disable' 2. Set 'MembershipExpiryDaysNotice' to '1' 3. Edit our patrons record setting 'Expiry date' to 1 day in future 4. cd to misc/cronjobs directory 5. Jump into koha-shell and run membership_expiry.pl cronjob: sudo koha-shell <instancename> ./membership_expiry.pl -c 6. Visit the patron record's 'Notices' tab and observe 'Account expiration' notice with type 'email' 7. Change 'FallbackToSMSIfNoEmail' syspref to 'Enable' 8. Reset patrons epxiration date to 1 day in future 9. Repeat step 4,5,6 and observe new 'Account expiration' notice is type 'sms' Test plan for opac/opac-shareshelf.pl (patch has been applied already): 1. Set 'FallbackToSMSIfNoEmail' syspref to 'Disable' 2. Set 'OpacAllowSharingPrivateLists' syspref to 'Allow' 3. Ensure OPACBaseURL is set 4. In OPAC log in as the patron with set smsalertnumber and no email 5. Create a private list, select 'Share' link, input email address and submit 6. Back in staff client make a new patron record 7. Return to OPAC and login as patron from step #5 8. Query database: select content from message_queue where letter_code='SHARE_INVITE'; 9. Click on the link in the message_queue notice 10. OPAC loads 11. Query database again: select to_address, message_transport_type from message_queue where letter_code='SHARE_ACCEPT'; 12. Observe there is no 'Share on list <listname> accepted' notice 13. Set 'FallbackToSMSIfNoEmail' to 'Enable' and repeat steps 4,5,7,8, 9,10,11,12 and observe there is a 'Share on list <listname> accepted' notice with to_address = smsalertnumber and message_transport_type is 'sms' 14. Set 'FallbackToSMSIfNoEmail' to 'disable' and edit the patron with smsalertnumber set and no email setting an email address and repeat steps 4,5,7,8,9,10,11,12 and observe there is a 'Share on list <listname> accepted' notice with the to_address of the email you set and message_transport_type of 'email' Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 --- Comment #6 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Rebased against master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105328|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 --- Comment #7 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 109559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109559&action=edit Bug 21781: Fallback to SMS if no email address where email address hardcoded Extend use of FallbackToSMSIfNoEmail syspref to fallback to SMS if no patron email address outside of it's current usage sending suggestion notices. Test plan for C4/Acquisition.pm: 1. Input a value into SMSSendDriver syspref 2. Create a patron with sms (under Member messaging preferences) and no email address 3. In Acquistions module make currency, active budget, fund, vendor 4. Create a basket 5. Add to basket. Click to add 'From a new (empty) record' 6. Under 'Patrons' header add a user and search for your patron (added in #1) 7. Submit new order 8. Receive the order: 'Close this basket' 'Receive shipment' Submit invoice page Select 'Receive' link on right hand side of page Tick checkbox to add 1 quantity of item and Save 9. Revisit your patrons page and in the 'Notices' tab you'll see a 'Order received' notice with type of 'email' 11. Apply patch and restart plack 12. Repeat steps 4-9 and observe the 'Order received' notice has a type of SMS Test plan for amendment to circ/pendingreserves.pl (patch has been applied in 'Test plan for C4/Acquisition.pm): 1. Set 'FallbackToSMSIfNoEmail' syspref to 'Disable' 2. Set CanMarkHoldsToPullAsLost syspref to 'Allow to mark items as lost and notify the patron' 3. Using the patron from test plan for C4/Acquisitions.pm (i.e. sms alert number and no email) place a hold on an item currently available 4. Visit Circulation > Holds to pull 5. Select 'Mark lost and notify patron' 6. Return to patron page look in 'Notices' tab and observe 'Hold has been cancelled' notice has type of 'email' 7. Change 'FallbackToSMSIfNoEmail' to 'Enable' and repeat steps 3,4,5,6 and observe the new 'Hold has been cancelled' notice has type 'sms' Test plan for amendment to misc/cronjobs/automatic_renewals.pl (patch has been applied already): 1. Set 'FallbackToSMSIfNoEmail' syspref to 'Disable' 2. Enable automatic renewals in Administration > Circulation and fine rules 3. Checkout an item to our patron and set due date in the past 4. cd into misc/cronjobs 5. Jump into koha-shell and run automatic_renewals.pl cronjob sudo koha-shell <instancename> ./automatic_renewals.pl --confirm --send-notices 6. Observe in patron records 'Notices' tab there is a 'Auto renewals' notice with type 'email' 7. Set 'FallbackToSMSIfNoEmail' syspref to 'Enable' and repeat steps 3,4,5,6 and observe the new 'Auto renewals' notice is type 'sms' Test plan for amendment to misc/cronjobs/membership_expiry.pl (patch has been applied already): 1. Set 'FallbackToSMSIfNoEmail' syspref to 'Disable' 2. Set 'MembershipExpiryDaysNotice' to '1' 3. Edit our patrons record setting 'Expiry date' to 1 day in future 4. cd to misc/cronjobs directory 5. Jump into koha-shell and run membership_expiry.pl cronjob: sudo koha-shell <instancename> ./membership_expiry.pl -c 6. Visit the patron record's 'Notices' tab and observe 'Account expiration' notice with type 'email' 7. Change 'FallbackToSMSIfNoEmail' syspref to 'Enable' 8. Reset patrons epxiration date to 1 day in future 9. Repeat step 4,5,6 and observe new 'Account expiration' notice is type 'sms' Test plan for opac/opac-shareshelf.pl (patch has been applied already): 1. Set 'FallbackToSMSIfNoEmail' syspref to 'Disable' 2. Set 'OpacAllowSharingPrivateLists' syspref to 'Allow' 3. Ensure OPACBaseURL is set 4. In OPAC log in as the patron with set smsalertnumber and no email 5. Create a private list, select 'Share' link, input email address and submit 6. Back in staff client make a new patron record 7. Return to OPAC and login as patron from step #5 8. Query database: select content from message_queue where letter_code='SHARE_INVITE'; 9. Click on the link in the message_queue notice 10. OPAC loads 11. Query database again: select to_address, message_transport_type from message_queue where letter_code='SHARE_ACCEPT'; 12. Observe there is no 'Share on list <listname> accepted' notice 13. Set 'FallbackToSMSIfNoEmail' to 'Enable' and repeat steps 4,5,7,8, 9,10,11,12 and observe there is a 'Share on list <listname> accepted' notice with to_address = smsalertnumber and message_transport_type is 'sms' 14. Set 'FallbackToSMSIfNoEmail' to 'disable' and edit the patron with smsalertnumber set and no email setting an email address and repeat steps 4,5,7,8,9,10,11,12 and observe there is a 'Share on list <listname> accepted' notice with the to_address of the email you set and message_transport_type of 'email' Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 --- Comment #8 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Rebased against master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 --- Comment #9 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Patches still apply cleanly on master. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- This may need updating for the new `queue_message` method added with bug 15986. I like the idea of a migration to using 'queue_message' for all message queuing operations and thus centralising the fallback system for message transport types. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |andrew@bywatersolutions.com --- Comment #11 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I got a couple of small merge errors here. I managed to apply the patches, but something in pendingreseves is still mad. I get this error when I try to go to Holds to Pull as part of your Test plan for amendment to circ/pendingreserves.pl: Could not compile /kohadevbox/koha/circ/pendingreserves.pl: Global symbol "$admin_email_address" requires explicit package name (did you forget to declare "my $admin_email_address"?) at /kohadevbox/koha/circ/pendingreserves.pl line 95. BEGIN not safe after errors--compilation aborted at /kohadevbox/koha/circ/pendingreserves.pl line 315. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 --- Comment #12 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Also running into issues with auto-renew notices, probably due to changes made in bug 18532. That added messaging preferences for auto-renew notices. Might that mean we should remove them from this bug? Since now patrons/libraries are more explicitly choosing how they want auto-renews sent? With the patch applied right now, I have FallbackToSMSIfNoEmail turned off, my patron has an SMS number but no email address, and their messaging prefs say to send auto-renew as an email only. When I run the cron, my patron gets an SMS. So that's not right. For what it's worth, the acq and membership expiry notices worked as described. I didn't test the list share. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109559|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 124868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124868&action=edit Bug 21781 - message_transport_type should allow fallbacks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alexbuckley@catalyst.net.nz |kyle@bywatersolutions.com CC| |kyle@bywatersolutions.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124868|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 124869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124869&action=edit Bug 21781 - message_transport_type should allow fallbacks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff CC| |wizzyrea@gmail.com --- Comment #15 from Liz Rea <wizzyrea@gmail.com> --- has anyone tested the latest patches here? setting this to needs signoff so we can make sure the patches still don't apply. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Patch doesn't apply --- Comment #16 from David Nind <david@davidnind.com> --- (In reply to Liz Rea from comment #15)
has anyone tested the latest patches here? setting this to needs signoff so we can make sure the patches still don't apply.
The patch no longer applies 8-(... git bz apply 21781 Bug 21781 - message_transport_type should allow fallbacks 124869 - Bug 21781 - message_transport_type should allow fallbacks Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 21781 - message_transport_type should allow fallbacks Using index info to reconstruct a base tree... M C4/Acquisition.pm M C4/Suggestions.pm M Koha/Patron.pm M circ/pendingreserves.pl M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref M misc/cronjobs/membership_expiry.pl M opac/opac-shareshelf.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-shareshelf.pl Auto-merging misc/cronjobs/membership_expiry.pl CONFLICT (content): Merge conflict in misc/cronjobs/membership_expiry.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref Auto-merging circ/pendingreserves.pl Auto-merging Koha/Patron.pm Auto-merging C4/Suggestions.pm Auto-merging C4/Acquisition.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 21781 - message_transport_type should allow fallbacks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #124869|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168199&action=edit Bug 21781 - message_transport_type should allow fallbacks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168200&action=edit Bug 21781: Apply message_transport_type fallbacks to more locations Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 168201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168201&action=edit Bug 21781: (follow-up) Use SMS templates We shouldn't only be changing the message transport type for the enqueue function but also for the call to GetPreparedLetter.. otherwise we'll just be putting what may be an innapropriately formatted for email notice into an SMS message. This patch updates all the occurences touched by the patchset to use the SMS notice template when we're falling back to SMS for transport medium. We also drop the fallback for the expiry notice, as a bug has since introduced functionality to send to both email and sms for that notice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168199|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle@bywatersolutions.com |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37214 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37214 [Bug 37214] We should migrate to Koha::Patron->queue_notice wherever possible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I still think the long term goal should be to further improve Koha::Patron->queue_notice and then use that wherever we can.. but this is an OK intermediate step in my opinion. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 --- Comment #21 from Lucas Gass <lucas@bywatersolutions.com> --- Martin, do you think it would be a good idea to have some tests to cover these changes? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #22 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Looks like a pretty minor merge conflict in opac/opac-shareshelf.pl is causing this to not apply cleanly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168200|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178677&action=edit Bug 21781: Apply message_transport_type fallbacks to more locations Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168201|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 178678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=178678&action=edit Bug 21781: (follow-up) Use SMS templates We shouldn't only be changing the message transport type for the enqueue function but also for the call to GetPreparedLetter.. otherwise we'll just be putting what may be an innapropriately formatted for email notice into an SMS message. This patch updates all the occurences touched by the patchset to use the SMS notice template when we're falling back to SMS for transport medium. We also drop the fallback for the expiry notice, as a bug has since introduced functionality to send to both email and sms for that notice. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 --- Comment #25 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Rebased to apply.. but this certainly needs some thorough testing.. The rebase encouraged/required I update Koha::Patron->queue_notice to handle the SMS fallback preference.. but this will undoubtedly affect more locations than the original patchset now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 --- Comment #26 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- For reference, queue_notice is used in: * Koha::CurbsidePickup * Koha::REST::V1::TwoFactorAuth * misc/cronjobs/membership_expiry.pl * misc/cronjobs/holds/holds_reminder.pl * members/two_factor_auth.pl The `membership_expiry.pl` script being migrated to using queue_notice was the trigger at rebase time to implement the fallback handling within that method. We could certainly clean up more here as I suggested many moons ago. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178677|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186665&action=edit Bug 21781: Apply message_transport_type fallbacks to more locations Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #178678|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Created attachment 186666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186666&action=edit Bug 21781: (follow-up) Use SMS templates We shouldn't only be changing the message transport type for the enqueue function but also for the call to GetPreparedLetter.. otherwise we'll just be putting what may be an innapropriately formatted for email notice into an SMS message. This patch updates all the occurences touched by the patchset to use the SMS notice template when we're falling back to SMS for transport medium. We also drop the fallback for the expiry notice, as a bug has since introduced functionality to send to both email and sms for that notice. Signed-off-by: Martin Renvoize <martin.renvoize@openfifth.co.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 --- Comment #29 from Martin Renvoize (ashimema) <martin.renvoize@openfifth.co.uk> --- Rebased -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21781 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Extended notice |Extended notice release notes|message_transport_type |message_transport_type |fallback functionality |fallback functionality |implemented by |implemented by |FallbackToSMSIfNoEmail |FallbackToSMSIfNoEmail |system preference to: |system preference to: |cronjobs (membership |- cronjobs (membership |expiry, automatic renewal), |expiry, automatic renewal), |opac-shareshelf.pl (sending | |of SHARE_ACCEPT notice when |- opac-shareshelf.pl |list share accepted), |(sending of SHARE_ACCEPT |circ/pendingreserves.pl |notice when list share |(sending |accepted), |'CANCEL_HOLD_ON_LOST' |- circ/pendingreserves.pl |notice when reserved item |(sending |marked lost in Holds to |'CANCEL_HOLD_ON_LOST' |pull), C4/Acquisition.pm |notice when reserved item |(sending |marked lost in Holds to |'ACQ_NOTIF_ON_RECEIV' |pull), |notice to notify order user |- C4/Acquisition.pm |of order receival) |(sending | |'ACQ_NOTIF_ON_RECEIV' | |notice to notify users of | |receipt) Status|Needs Signoff |Failed QA --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 1) QA checks - failing 2 minor fails noted by the QA tests: Your branch is up to date with 'origin/main'. testing 2 commit(s) (applied to 1534574 '574 Bug 39745: Fix wrong system prefe') Processing files [RUNNING] C4/Acquisition.pm [RUNNING] C4/Suggestions.pm [RUNNING] Koha/Patron.pm [RUNNING] circ/pendingreserves.pl [RUNNING] koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref [RUNNING] opac/opac-shareshelf.pl [FAIL] koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref [PASS] opac/opac-shareshelf.pl [PASS] circ/pendingreserves.pl [PASS] C4/Acquisition.pm [FAIL] Koha/Patron.pm [PASS] C4/Suggestions.pm Result: [PASS] C4/Acquisition.pm [PASS] C4/Suggestions.pm [FAIL] Koha/Patron.pm FAIL tidiness File is not tidy, please run `perl misc/devel/tidy.pl Koha/Patron.pm` [PASS] circ/pendingreserves.pl [FAIL] koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref FAIL new_line_at_the_end_of_file Missing new line at the end of file, make sure your editor correctly reads .editorconfig ('insert_final_newline = true'). See bug 40541. [PASS] opac/opac-shareshelf.pl 2) Code review (blocker for QA) - Missing unit tests. 3) Testing a) General notes (question) Since SMS messages are usually not free, I wonder if this should allow to specify which notices the fallback should be applied to automatically. A library might want to opt out for some, but not for all notices to be sent by SMS. We might also break the use case of the library who first implemented the pref... as we would change the behavior with no option to change it back. So it would be nice to have some feedback. (@Alex Buckley?) b) Missing SMS notice template? (question) What is supposed to happen when there is no SMS template set up for the notice, will it not be sent? (which would be way to opt out of the fallback) c) System preference phrasing (suggestions/questions) We currently have: [Enable|Disable] sending notices by SMS if patron has no email address. I wonder if this might be a little clearer: [Send|Don't send] notices by SMS if patron has no email address. It also makes it sound like the fallback will always be applied for all notices to patrons. But there are some notices missing from the list given in the release note. I feel like we should be clear about what is covered, at least for documentation Some notices that came to mind: - advance notices - overdue notices - hold/booking/recall pick-up notice - hold cancellation notice - article request notices If we made this opt-in by notice/area, the option list could also serve as documentation. The second patch says: "We also drop the fallback for the expiry notice, as a bug has since introduced functionality to send to both email and sms for that notice.", but it's still listed in release note. Also wondering: if it includes an automatic fallback, should that not also be under the pref? -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org