[Bug 35755] New: Upgrade Business::ISBN to at least 3.008 minimum version
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 Bug ID: 35755 Summary: Upgrade Business::ISBN to at least 3.008 minimum version Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org As Lucas notes at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729#c2 we should upgrade Business::ISBN to handle ISBN-13 with a prefix of 979 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35729 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13167, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14287, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21821 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Packaging |and plumbing | Keywords| |dependency CC| |mtj@kohaaloha.com --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Can someone from the packaging team look at this one? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- I have a library that needs needs an updated Business::ISBN for a Koha plugin they use, so I'm going to download libbusiness-isbn-perl from https://packages.ubuntu.com/mantic/libbusiness-isbn-perl and install it. It would be good to have the Debian version in the Koha apt repo though. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Actually looks like the download link for mantic is busted so I'll use the one for noble. I'll also need the latest libbusiness-isbn-data-perl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35729 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35729 [Bug 35729] Amazon images don't work for ISBNs starting with 979 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 --- Comment #4 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 169492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169492&action=edit Bug 35755: Update cpanfile for Business::ISBN 3.008 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |mtj@kohaaloha.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|mtj@kohaaloha.com |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169492|0 |1 is obsolete| | --- Comment #5 from David Cook <dcook@prosentient.com.au> --- Created attachment 169535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169535&action=edit Bug 35755: Update cpanfile for Business::ISBN 3.008 Signed-off-by: David Cook <dcook@prosentient.com.au> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- Trying to move this one along. FYI the one library I have on Business::ISBN 3.008 is doing fine. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169535|0 |1 is obsolete| | --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 169556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=169556&action=edit Bug 35755: Update cpanfile for Business::ISBN 3.008 Signed-off-by: David Cook <dcook@prosentient.com.au> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- FTR: ## Bad * bullseye: 3.006 * bookworm: 3.006 * focal: 3.004 * jammy: 3.006 ## Good * trixie: 3.0009 * noble: 3.009 * mantic (23.10): 3.008 ## Conclusion Needs to be packaged for `bullseye`, `bookworm`, `focal` and `jammy`. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |tomascohen@gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Mason.. are you OK to get this packaged up -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Should we go 3.0009? (mantic is EOL in a couple months anyway). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 --- Comment #11 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Tomás Cohen Arazi from comment #10)
Should we go 3.0009? (mantic is EOL in a couple months anyway).
I don't see why not. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Waiting for feedback from Packaging Manager. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- See: https://wiki.koha-community.org/wiki/Release_management#Dependency_changes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 --- Comment #14 from Mason James <mtj@kohaaloha.com> --- (In reply to Lucas Gass from comment #11)
(In reply to Tomás Cohen Arazi from comment #10)
Should we go 3.0009? (mantic is EOL in a couple months anyway).
I don't see why not.
i've added Business::ISBN 3.0009 to the koha-staging/KTD images lets wait until jenkins test pass, and then add to koha prod apt repo -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Mason James from comment #14)
(In reply to Lucas Gass from comment #11)
(In reply to Tomás Cohen Arazi from comment #10)
Should we go 3.0009? (mantic is EOL in a couple months anyway).
I don't see why not.
i've added Business::ISBN 3.0009 to the koha-staging/KTD images
lets wait until jenkins test pass, and then add to koha prod apt repo
Jenkins is looking much greener now - are we ready to move on with this? Who goes first? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 --- Comment #16 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 170232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170232&action=edit Bug 35755: Update cpanfile for Business::ISBN 3.009 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #169556|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 --- Comment #17 from Lucas Gass <lucas@bywatersolutions.com> --- I suspect we should require 3.009? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Lucas Gass from comment #17)
I suspect we should require 3.009?
Can you explain what else is needed? It looks like we do: -requires 'Business::ISBN', '2.05'; +requires 'Business::ISBN', '3.009'; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 --- Comment #19 from Mason James <mtj@kohaaloha.com> --- (In reply to Katrin Fischer from comment #18)
(In reply to Lucas Gass from comment #17)
I suspect we should require 3.009?
Can you explain what else is needed? It looks like we do:
-requires 'Business::ISBN', '2.05'; +requires 'Business::ISBN', '3.009';
yep, thats all that is needed :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 --- Comment #20 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35755 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED --- Comment #21 from Lucas Gass <lucas@bywatersolutions.com> --- Enhancement will not be backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org