[Bug 25761] New: Implementation of too_many_overdue has unintended side-effects
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Bug ID: 25761 Summary: Implementation of too_many_overdue has unintended side-effects Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: colin.campbell@ptfs-europe.com Bug 24449 implemented the too_many_overdue SIP flag ( position 6 of the patron status flags ). This has had unintended consequences as many library use SIP2 for validation to eresource vendors ( Overdrive, Hoopla, etc ), but do not want overdue checkouts to block the use of these resources. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24449 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24449 [Bug 24449] SIP2 - too_many_overdue flag is not implemented -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Implementation of |Implementation of |too_many_overdue has |too_many_overdue has |unintended side-effects |unintended consequences -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 105889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105889&action=edit Bug 25761: Implementation of too_many_overdue has unintended consequences Bug 24449 implemented the too_many_overdue SIP flag ( position 6 of the patron status flags ). This has had unintended consequences as many library use SIP2 for validation to eresource vendors ( Overdrive, Hoopla, etc ), but do not want overdue checkouts to block the use of these resources. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Find a patron with overdue items 4) Run a SIP2 patron information request 5) Note the "too many overdue" flag is set 6) Set the new SIP config option "disable_too_many_overdue" for the account you used for testing 7) Restart the SIP server 8) Run the same patron information request 9) Notice the "too many overdue" flag is no longer set! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Christopher Brannon <cbrannon@cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon@cdalibrary.org --- Comment #2 from Christopher Brannon <cbrannon@cdalibrary.org> --- Thank you for making it an option. Our library WANTS sip users blocked when they have overdues. Especially now that we don't charge fines. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #105889|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109747&action=edit Bug 25761: Implementation of too_many_overdue has unintended consequences Bug 24449 implemented the too_many_overdue SIP flag ( position 6 of the patron status flags ). This has had unintended consequences as many library use SIP2 for validation to eresource vendors ( Overdrive, Hoopla, etc ), but do not want overdue checkouts to block the use of these resources. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Find a patron with overdue items 4) Run a SIP2 patron information request 5) Note the "too many overdue" flag is set 6) Set the new SIP config option "disable_too_many_overdue" for the account you used for testing 7) Restart the SIP server 8) Run the same patron information request 9) Notice the "too many overdue" flag is no longer set! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- With patch applied, changing the flag in the SIP config file has no impact on response. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109747|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 109786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109786&action=edit Bug 25761: Implementation of too_many_overdue has unintended consequences Bug 24449 implemented the too_many_overdue SIP flag ( position 6 of the patron status flags ). This has had unintended consequences as many library use SIP2 for validation to eresource vendors ( Overdrive, Hoopla, etc ), but do not want overdue checkouts to block the use of these resources. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Find a patron with overdue items 4) Run a SIP2 patron information request 5) Note the "too many overdue" flag is set 6) Set the new SIP config option "disable_too_many_overdue" for the account you used for testing 7) Restart the SIP server 8) Run the same patron information request 9) Notice the "too many overdue" flag is no longer set! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- For consistency with bug 25541, I wonder if we ought to name the flag 'overdues_block_circ' or something along those lines? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- As an aside, debian/templates/SIPconfig.xml is getting really out of sync these days.. I think there's a bug open to bring it back in sync.. but we should probably be catching cases where we add new config options and ensuring we add them to those templates too ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #8 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Hi, not enough experience with SIP so I have two questions
5) Note the "too many overdue" flag is set
READ: 24 00120201112 201630AEEdna Acosta|AA23529001000463|BLY|CQN|AFGreetings from Koha. |AOCPL|
Which one is it? I couldn't in the spec where is the patron status field.
6) Set the new SIP config option "disable_too_many_overdue" for the account you used for testing
Where does one do that? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Victor Grousset/tuxayo from comment #8)
Hi, not enough experience with SIP so I have two questions
5) Note the "too many overdue" flag is set
READ: 24 00120201112 201630AEEdna Acosta|AA23529001000463|BLY|CQN|AFGreetings from Koha. |AOCPL|
Which one is it? I couldn't in the spec where is the patron status field.
It is the 6th character of the patron status flags, the 8th character of the entire message. 24 00120201112 201630AEEdna ^ This one. Y means patron has too many overdues, blank means they don't.
6) Set the new SIP config option "disable_too_many_overdue" for the account you used for testing
Where does one do that?
Find your SIPconfig.xml, usually in /etc/koha/sites/<instance>/SIPconfig.xml, then add as you can see here at the bottom of the page for the SIP account you want to use for testing: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109786&action=diff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #109786|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 113595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113595&action=edit Bug 25761: Implementation of too_many_overdue has unintended consequences Bug 24449 implemented the too_many_overdue SIP flag ( position 6 of the patron status flags ). This has had unintended consequences as many library use SIP2 for validation to eresource vendors ( Overdrive, Hoopla, etc ), but do not want overdue checkouts to block the use of these resources. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Find a patron with overdue items 4) Run a SIP2 patron information request 5) Note the "too many overdue" flag is set 6) Set the new SIP config option "disable_too_many_overdue" for the account you used for testing 7) Restart the SIP server 8) Run the same patron information request 9) Notice the "too many overdue" flag is no longer set! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 --- Comment #11 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 113596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113596&action=edit Bug 25761: (QA follow-up) Consistent flag names This follow-up updates the config flag to be consistent with bug 24449 and updates the debian template file to match too. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 --- Comment #12 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Martin Renvoize from comment #11)
Created attachment 113596 [details] [review] Bug 25761: (QA follow-up) Consistent flag names
This follow-up updates the config flag to be consistent with bug 24449 and updates the debian template file to match too.
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Thanks for the followup Martin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113596|0 |1 is obsolete| | --- Comment #13 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 113598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113598&action=edit Bug 25761: (QA follow-up) Consistent flag names This follow-up updates the config flag to be consistent with bug 24449 and updates the debian template file to match too. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This bugfix allows the release notes| |circulation rules that | |prevent checkouts if a user | |has reached a maximum | |number of overdue to be | |overridden at the SIP login | |level. | | | |This is especially | |useful for ebook lending | |services where you may want | |this block to be disabled. | | | |***New SIP config | |option***: | |`overdues_block_checkout` | |defaults to `1` -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 --- Comment #14 from Victor Grousset/tuxayo <victor@tuxayo.net> --- (In reply to Kyle M Hall from comment #9)
It is the 6th character of the patron status flags, the 8th character of the entire message.
READ: 24 00120201113 154013AEEdna Acosta|AA23529001000463|BLY|CQN|AFGreetings from Koha. |AOCPL| overdue item + OverduesBlockCirc == "Block" + add disable_too_many_overdue="0" to account koha + patches + restart_all READ: 24Y 00120201113 163742AEEdna Acosta|AA23529001000463|BLY|CQN|AFGreetings from Koha. -- Patron has overdues|AOCPL| Somehow I get the charge privileges denied flag, is that expected? And I don't get the disable_too_many_overdue flag. Is the right config file this one? /etc/koha/sites/kohadev/SIPconfig.xml (in koha-testing-docker) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 --- Comment #15 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Victor Grousset/tuxayo from comment #14)
(In reply to Kyle M Hall from comment #9)
It is the 6th character of the patron status flags, the 8th character of the entire message.
READ: 24 00120201113 154013AEEdna Acosta|AA23529001000463|BLY|CQN|AFGreetings from Koha. |AOCPL|
overdue item + OverduesBlockCirc == "Block" + add disable_too_many_overdue="0" to account koha + patches + restart_all
READ: 24Y 00120201113 163742AEEdna Acosta|AA23529001000463|BLY|CQN|AFGreetings from Koha. -- Patron has overdues|AOCPL|
Somehow I get the charge privileges denied flag, is that expected? And I don't get the disable_too_many_overdue flag.
Is the right config file this one? /etc/koha/sites/kohadev/SIPconfig.xml (in koha-testing-docker)
Sorry Victor, I should have made that clearer. My followup changes "disable_too_many_overdues" to "overdues_block_circ" to make it more consistent with some other configs we've introduced. When enabled (the default) having too many overdues (according to the circulation rules) should set that return flag to 'Y' as your seeing.. if you disable it by passing in that config Param with '0' then you should not see the 'Y'. You are looking at the right file, but only if that after having run make to refresh it from the templates in the source directories. Hope that helps -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113595|0 |1 is obsolete| | --- Comment #16 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 113630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113630&action=edit Bug 25761: Implementation of too_many_overdue has unintended consequences Bug 24449 implemented the too_many_overdue SIP flag ( position 6 of the patron status flags ). This has had unintended consequences as many library use SIP2 for validation to eresource vendors ( Overdrive, Hoopla, etc ), but do not want overdue checkouts to block the use of these resources. Test Plan: 1) Apply this patch 2) Restart all the things! 3) Find a patron with overdue items 4) Run a SIP2 patron information request 5) Note the "too many overdue" flag is set 6) Set the new SIP config option "disable_too_many_overdue" for the account you used for testing 7) Restart the SIP server 8) Run the same patron information request 9) Notice the "too many overdue" flag is no longer set! Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113598|0 |1 is obsolete| | --- Comment #17 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 113631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113631&action=edit Bug 25761: (QA follow-up) Consistent flag names This follow-up updates the config flag to be consistent with bug 24449 and updates the debian template file to match too. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #18 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
having too many overdues (according to the circulation rules)
Ok!!!! Wait which setting of the circulation rules? I can't find it. Anyway, I managed to get the expected result with OverduesBlockCirc Thanks I learned useful stuff about SIP and the config files :) BTW why do we have lpl-sc-beacock user in the config file if it's not in the sample data? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 --- Comment #19 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Victor Grousset/tuxayo from comment #18)
having too many overdues (according to the circulation rules)
Ok!!!!
Wait which setting of the circulation rules? I can't find it.
Anyway, I managed to get the expected result with OverduesBlockCirc
Thanks I learned useful stuff about SIP and the config files :)
BTW why do we have lpl-sc-beacock user in the config file if it's not in the sample data?
Oops, indeed, it's OverduesBlockCirc syspref, my mistake. No idea about the user in the config.. likely a legacy thing. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 --- Comment #20 from Victor Grousset/tuxayo <victor@tuxayo.net> ---
No idea about the user in the config.. likely a legacy thing.
Shall I do a followup and swap it with the koha user? or maybe with koha_sip (login term1) As we add config to lpl-sc-beacock, it might as well match an account of sample data. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 --- Comment #21 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25761 --- Comment #22 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Merge conflicts for 20.05.x, please rebase if needed -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org