[Bug 22138] New: members/paycollect.pl has not been updated to have the new tab names
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22138 Bug ID: 22138 Summary: members/paycollect.pl has not been updated to have the new tab names Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org Target Milestone: --- Under the new Accounting tab (was "Fines") the tabs have also been renamed - 'Account' became 'Transactions', and 'Pay fines' became 'Make a payment'. These tab headings need to be updated on members/paycollect.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22138 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22138 Jasmine Amohia <jasmineamohia.student@wegc.school.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22138 --- Comment #1 from Jasmine Amohia <jasmineamohia.student@wegc.school.nz> --- Created attachment 84033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84033&action=edit Bug 22138: updated tab names on members/paycollect.pl Test plan: 1. Give patron outstanding fees 2. Search patron and select 'Make payment' 3. Select either 'Pay' or 'Write off' 4. Confirm that first tab title remains as 'Transactions' 5. Confirm that current tab title remains as 'Make a payment' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22138 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84033|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 84045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84045&action=edit Bug 22138: updated tab names on members/paycollect.pl Test plan: 1. Give patron outstanding fees 2. Search patron and select 'Make payment' 3. Select either 'Pay' or 'Write off' 4. Confirm that first tab title remains as 'Transactions' 5. Confirm that current tab title remains as 'Make a payment' Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22138 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Status|Needs Signoff |Signed Off --- Comment #3 from David Nind <david@davidnind.com> --- Nice work Jasmine! This works as intended, and I've signed it off. For future test plans it might help if they are a little bit more detailed (this makes it easier and quicker for sign off and QA), for example: 1. Search for a patron (Patrons > Search > Select a patron) 2. Add an invoice for a patron (Accounting > Create manual invoice) 3. Before applying the patch check that when you click on the Pay and Write off buttons (under Accounting > Make a payment) the tab titles change to the old terms used 'Account' and 'Pay fines' 4. After applying the patch click on the Pay and Write off buttons again 5. Confirm that first tab title is now 'Transactions' 6. Confirm that second tab title is now 'Make a payment' I was able to figure it out, so no worries. Keep up the good work! David -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jasmineamohia.student@wegc. |ity.org |school.nz CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22138 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84045|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 84080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84080&action=edit Bug 22138: updated tab names on members/paycollect.pl Test plan: 1. Give patron outstanding fees 2. Search patron and select 'Make payment' 3. Select either 'Pay' or 'Write off' 4. Confirm that first tab title remains as 'Transactions' 5. Confirm that current tab title remains as 'Make a payment' Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22138 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Good catch! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22138 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22138 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22138 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.11.x for 18.11.03 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22138 Jesse Maseto <jesse@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse@bywatersolutions.com --- Comment #8 from Jesse Maseto <jesse@bywatersolutions.com> --- Merge conflict with 18.05.x. Please rebase if needed in 18.05.x. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org