[Bug 18597] New: Quick add form does not transfer patron attributes values when switching forms /saving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597 Bug ID: 18597 Summary: Quick add form does not transfer patron attributes values when switching forms/saving Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate 1 - Have some patron attributes (with/without auth values set) 2 - Add them to QuickAddFields (patron_attr2 for example) 3 - view quick add form and set some values 4 - Switch to full form, values not transferred 5 - Swithc to quick add, view values, save 6 - Values are not saved :-( -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 63443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63443&action=edit Bug 18597 - Quick add form does not transfer patron attributes values when switching forms/saving The function that switches between quick add/fulll form assumes labels are followed by values - patron_attr don't follow this pattern. This patch just moves the hidden input field To test: 1 - Have some patron attributes (with/without auth values set) 2 - Add them to QuickAddFields (patron_attr2 for example) 3 - view quick add form and set some values 4 - Switch to full form, values not transferred 5 - Switch to quick add, view values, save 6 - Values are not saved :-( 7 - Apply patch 8 - Repeat 3 - 5 9 - Values are transferred and saved :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |3534 Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Severity|enhancement |normal Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3534 [Bug 3534] Patron quick add form -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63443|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 63448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63448&action=edit [SIGNED-OFF] Bug 18597 - Quick add form does not transfer patron attributes values when switching forms/saving The function that switches between quick add/fulll form assumes labels are followed by values - patron_attr don't follow this pattern. This patch just moves the hidden input field To test: 1 - Have some patron attributes (with/without auth values set) 2 - Add them to QuickAddFields (patron_attr2 for example) 3 - view quick add form and set some values 4 - Switch to full form, values not transferred 5 - Switch to quick add, view values, save 6 - Values are not saved :-( 7 - Apply patch 8 - Repeat 3 - 5 9 - Values are transferred and saved :-) Signed-off-by: Peggy Thrasher <p.thrasher@dover.nh.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sven.halm@shalm.de --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- *** Bug 18612 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I do not manage to see the patron attributes on the quick add form. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #4)
I do not manage to see the patron attributes on the quick add form.
Ha, we have to guess the id of the attribute in DB. That's very badly implemented. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63448|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 63543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63543&action=edit Bug 18597 - Quick add form does not transfer patron attributes values when switching forms/saving The function that switches between quick add/fulll form assumes labels are followed by values - patron_attr don't follow this pattern. This patch just moves the hidden input field To test: 1 - Have some patron attributes (with/without auth values set) 2 - Add them to QuickAddFields (patron_attr2 for example) 3 - view quick add form and set some values 4 - Switch to full form, values not transferred 5 - Switch to quick add, view values, save 6 - Values are not saved :-( 7 - Apply patch 8 - Repeat 3 - 5 9 - Values are transferred and saved :-) Signed-off-by: Peggy Thrasher <p.thrasher@dover.nh.gov> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 17.05, thanks Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|Pushed to Master |Pushed to Stable --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This patch has been pushed to 16.11.x and will be in 16.11.08. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18597 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #9 from Mason James <mtj@kohaaloha.com> --- Blocked by new feature, skipping for 16.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org