[Bug 7596] New: System preferences editor JavaScript contains untranslatable English string
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7596 Bug #: 7596 Summary: System preferences editor JavaScript contains untranslatable English string Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration AssignedTo: oleonard@myacpl.org ReportedBy: oleonard@myacpl.org QAContact: koha.sekjal@gmail.com CC: gmcharlt@gmail.com It looks like this is just one which was missed in an earlier sweep: msg += '<strong>Saved preference '+modified_pref+'</strong>\n'; -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7596 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> 2012-02-24 20:51:51 UTC --- A larger problem is another js file used by preferences.pl: ajax.js. There are many instances where English strings are passed to the onscreen message handler: if ( error.type == 'auth' ) { humanMsg.displayMsg( _( 'You need to log in again, your session has timed out' ) ); } These messages should be moved to the template. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7596 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED QA Contact|koha.sekjal@gmail.com | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7596 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7596 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 16056 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16056&action=edit Bug 7596 - System prefs editor JS contains untranslatable English string There is one stray instance of an untranslatable string in preferences.js. This patch replaces it with a variable which is now defined in the preferences template. To test, open the system preferences editor and change any setting. You should see the usual "Saved preference <preference name>" message. To test that error strings are now translatable, run "perl translate update <lang>" from misc/translator, then check if the affected strings shows up in the po file. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7596 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7596 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16056|0 |1 is obsolete| | --- Comment #3 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 16106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16106&action=edit Bug 7596 - System prefs editor JS contains untranslatable English string There is one stray instance of an untranslatable string in preferences.js. This patch replaces it with a variable which is now defined in the preferences template. To test, open the system preferences editor and change any setting. You should see the usual "Saved preference <preference name>" message. To test that error strings are now translatable, run "perl translate update <lang>" from misc/translator, then check if the affected strings shows up in the po file. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Tested both, all ok. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7596 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |String patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: String appears in the po file after translate update. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7596 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #16106|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 16163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16163&action=edit Bug 7596 - System prefs editor JS contains untranslatable English string There is one stray instance of an untranslatable string in preferences.js. This patch replaces it with a variable which is now defined in the preferences template. To test, open the system preferences editor and change any setting. You should see the usual "Saved preference <preference name>" message. To test that error strings are now translatable, run "perl translate update <lang>" from misc/translator, then check if the affected strings shows up in the po file. Signed-off-by: Liz Rea <liz@catalyst.net.nz> Tested both, all ok. Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7596 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7596 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.10.x and 3.8.x will be in 3.10.4 and 3.8.11 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org