[Bug 10784] New: SMS-related code needs improvements
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10784 Bug ID: 10784 Summary: SMS-related code needs improvements Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: magnus@enger.priv.no QA Contact: testopia@bugs.koha-community.org Some more or less random findings: sms/sms_listen.pl has hardcoded strings in it, in Turkish (according to Google translate): http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=sms/sms_listen.pl;... This comment from an earlier commit sounds ominous: "SMS - widespread cleanup and moving code away from Cyprus/Turkey-specific implementation. Much more needed." http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=9c8a1e29f8f25890... To bring this in line with other functionality in Koha it would probably be a good idea to make the notices editable, in the same way that other notices are. C4::SMS references two sysprefs, SMSSendUsername and SMSSendPassword, but when I search for these in 3.12.x and current master I get no results. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10784 Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.rokseth@kul.oslo.k | |ommune.no --- Comment #1 from Benjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no> --- Adding to Magnus' findings: all scripts under sms/ seems to concern some Turkish SMS reply service, probably renew or reserve by SMS. However, they should hardly be part of Koha main branch. At least this should be a module under C4::SMS/Koha::SMS. Also it might be in order to be able to pass various parameters to the chosen SMS::Send driver from setting 'SMSSendDriver'. Now the various drivers need to hardcode settings such as url, username, password, etc. I don't know what would be best practice, but maybe a setting such as 'SMSSendOptions' where options could be separated with '|' e.g. 'url=http://smsservice.com|username=john|password=smith' The drivers available at cpan: http://search.cpan.org/search?query=sms%3A%3Asend&mode=all uses a long range of options, url,user,username,password,ssl,apikey,login,method, etc. It would be impossible to include all in C4::SMS, but a generic option hash passed to the driver would work, as per the Send::SMS doc: Params with a leading underscore are "private" driver-specific options and will be passed through to the driver unchanged. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10784 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@biblibre.co | |m --- Comment #2 from Jonathan Druart <jonathan.druart@biblibre.com> --- See http://git.biblibre.com/biblibre/kohac/commits/sanop/ft/MT10141 too. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10784 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #3 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Jonathan Druart from comment #2)
See http://git.biblibre.com/biblibre/kohac/commits/sanop/ft/MT10141 too.
This has been submitted in bug 13029 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10784 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13029 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10784 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14820 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org