[Bug 22454] New: Add Koha::Item::hidden_in_opac method
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 Bug ID: 22454 Summary: Add Koha::Item::hidden_in_opac method Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- We need such a method to determine if an item needs to be hidden in OPAC. It should take the OpacHiddenItems hashref as (optional) parameter. The case for 'exceptions' is left out on purpose. This should be just calculated by the calling party. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 86061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86061&action=edit Bug 22454: Unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 86062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86062&action=edit Bug 22454: Add Koha::Item::hidden_in_opac method This patch adds a hidden_in_opac method that does the same calculation done in GetHiddenItemnumbers, but for a single item, and doesn't get the OpacHiddenItems syspref, but expects them to be passed as parameters (to avoid multiple reads). To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => SUCCESS: Tests pass! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22455 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22455 [Bug 22455] Add Koha::Biblio::hidden_in_opac method -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de, | |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 --- Comment #3 from Michal Denar <black23@gmail.com> --- Created attachment 86501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86501&action=edit Bug 22454: Add Koha::Item::hidden_in_opac method This patch adds a hidden_in_opac method that does the same calculation done in GetHiddenItemnumbers, but for a single item, and doesn't get the OpacHiddenItems syspref, but expects them to be passed as parameters (to avoid multiple reads). To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => SUCCESS: Tests pass! Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86062|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86061|0 |1 is obsolete| | Attachment #86501|0 |1 is obsolete| | --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86509&action=edit Bug 22454: Unit tests Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 --- Comment #5 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 86510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86510&action=edit Bug 22454: Add Koha::Item::hidden_in_opac method This patch adds a hidden_in_opac method that does the same calculation done in GetHiddenItemnumbers, but for a single item, and doesn't get the OpacHiddenItems syspref, but expects them to be passed as parameters (to avoid multiple reads). To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => SUCCESS: Tests pass! Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22749 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22749 [Bug 22749] Koha::Item->hidden_in_opac should consider hidelostitems syspref -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org