[Bug 23150] New: GDPR breaks patron self modification on OPAC
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Bug ID: 23150 Summary: GDPR breaks patron self modification on OPAC Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: andrew@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org Target Milestone: --- To Test: - Set GDPR_Policy to either Enforced or Permissive - Set PatronSelfRegistrationBorrowerMandatoryField to empty - Set OPACPatronDetails to Allow - Log into the OPAC - Go to opac-memberentry.pl, change something, submit modification request - Request is refused with message "You have not filled out all required fields. Please fill in all missing fields and resubmit." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20819 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20819 [Bug 20819] GDPR: Add a consent field for processing personal data in account menu and self-registration -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 --- Comment #1 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 90817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90817&action=edit Bug 23150: Do not consider gdpr_proc_consent a mandatory field It introduced a regression in the patron's self modification feature. Patron's details are no longer modificable, the screen displays "You have not filled out all required fields. Please fill in all missing fields and resubmit." Test plan: - Set GDPR_Policy to either Enforced or Permissive - Set PatronSelfRegistrationBorrowerMandatoryField to empty - Set OPACPatronDetails to Allow - Log into the OPAC - Accept the GDPR screen - Go to opac-memberentry.pl, change something, submit modification request -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart@bugs.koha-c | |ommunity.org Severity|normal |major CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |m.de.rooy@rijksmuseum.nl Version|18.11 |master --- Comment #2 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Not sure about this fix, I'd like Marcel review :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 --- Comment #3 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Andrew from comment #0)
- Request is refused with message "You have not filled out all required fields. Please fill in all missing fields and resubmit."
I am not sure if I understand. You only need to tick the GDPR consent field, and you can save the record? Note that if you do not agree with the GDPR policy, we do not want you to proceed and create an account. So the title GDPR breaks self registration, is completely unclear to me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #2)
Not sure about this fix, I'd like Marcel review :)
At least for mode Enforced, we should treat it as mandatory. But I think for Permissive it should better be handled as mandatory too. But that is more arbitrary. This change actually breaks GDPR ;) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 --- Comment #5 from Andrew <andrew@bywatersolutions.com> --- This is actually an issue on patron self *modification* rather than registration. If GDPR_policy is set to enforced or permissive, patron self modification will always give a "missing required field" error, even if the patron has already accepted the GDPR terms. There is nothing GDPR-related on the self-modification page, so there is nothing in the patron can do to move past this error and nothing indicating what the error is referring to. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Andrew from comment #5)
This is actually an issue on patron self *modification* rather than registration.
If GDPR_policy is set to enforced or permissive, patron self modification will always give a "missing required field" error, even if the patron has already accepted the GDPR terms. There is nothing GDPR-related on the self-modification page, so there is nothing in the patron can do to move past this error and nothing indicating what the error is referring to.
Ahh. Bad reader ;) Probably this fix then still needs a little tweak. Looking now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 --- Comment #7 from Andrew <andrew@bywatersolutions.com> --- I sort of anticipated confusion because I pointed at opac-memberentry.pl, which is confusingly both self reg and self mod :P -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90817|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 90846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90846&action=edit Bug 23150: Do not consider gdpr_proc_consent a mandatory field It introduced a regression in the patron's self modification feature. Patron's details are no longer modificable, the screen displays "You have not filled out all required fields. Please fill in all missing fields and resubmit." Test plan: - Set GDPR_Policy to either Enforced or Permissive - Set PatronSelfRegistrationBorrowerMandatoryField to empty - Set OPACPatronDetails to Allow - Log into the OPAC - Accept the GDPR screen - Go to opac-memberentry.pl, change something, submit modification request Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 90847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90847&action=edit Bug 23150: (follow-up) Make gdpr_proc_consent mandatory for create When updating (patron modification), the field should not be required. Test plan: Check patron modification on opac. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Andrew from comment #7)
I sort of anticipated confusion because I pointed at opac-memberentry.pl, which is confusingly both self reg and self mod :P
Fixed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Summary|GDPR breaks patron self |GDPR feature breaks patron |modification on OPAC |self modification on OPAC --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- GDPR is a bit painful, but still changing the title slightly :) The law is not to blame here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com QA Contact|testopia@bugs.koha-communit |nick@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90846|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 90889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90889&action=edit Bug 23150: Do not consider gdpr_proc_consent a mandatory field It introduced a regression in the patron's self modification feature. Patron's details are no longer modificable, the screen displays "You have not filled out all required fields. Please fill in all missing fields and resubmit." Test plan: - Set GDPR_Policy to either Enforced or Permissive - Set PatronSelfRegistrationBorrowerMandatoryField to empty - Set OPACPatronDetails to Allow - Log into the OPAC - Accept the GDPR screen - Go to opac-memberentry.pl, change something, submit modification request Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90847|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 90890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90890&action=edit Bug 23150: (follow-up) Make gdpr_proc_consent mandatory for create When updating (patron modification), the field should not be required. Test plan: Check patron modification on opac. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 --- Comment #14 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- As the GDPR feature is in Koha down to at least 18.11... can we have this backported? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.02 released in| | Status|Pushed to master |Pushed to stable --- Comment #16 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 19.05.x for 19.05.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am not sure, but this appears seems to be ok in 18.11: my @fields = split( /\|/, $BorrowerMandatoryField ); push @fields, 'gdpr_proc_consent' if C4::Context->preference('GDPR_Policy') && $action eq 'create'; foreach (@fields) { -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23150 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- not sure = please double check :) -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org