[Bug 18537] New: Update Ukrainian installer sample files for 17.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Bug ID: 18537 Summary: Update Ukrainian installer sample files for 17.05 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: dubyk@ukr.net QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Created attachment 63100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63100&action=edit Update Ukrainian installer sample files for 17.05 Update and translate sample SQL file of the Ukrainian installer. To test: - Start with an empty database - Install uk-UA - Run the web installer in uk-UA/Ukrainian - Verify all files load without any problems. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Serhij Dubyk <dubyk@ukr.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dubyk@ukr.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Status|NEW |Needs Signoff --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Don't forget to switch to "needs sign-off"! :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 --- Comment #2 from Serhij Dubyk <dubyk@ukr.net> --- (In reply to Katrin Fischer from comment #1)
Don't forget to switch to "needs sign-off"! :) Thanks, Katrin!
-- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 --- Comment #3 from Serhij Dubyk <dubyk@ukr.net> --- Updated Ukrainian installation sql-files can be seen alive on demonstration installations (http://koha.org.ua/wiki/index.php?title=%D0%94%D0%B5%D0%BC%D0%BE%D0%BD%D1%81...) of Ukrainian users group of Koha. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63100|0 |1 is obsolete| | --- Comment #4 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 63770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63770&action=edit Update Ukrainian installer sample files for 17.05 Update and translate sample SQL file of the Ukrainian installer. To test: - Start with an empty database - Install uk-UA - Run the web installer in uk-UA/Ukrainian - Verify all files load without any problems. Signed-off-by: Serhij Dubyk {Сергій Дубик} <serhijdubyk@gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=18537 Followed test plan and the patch works with all files loading without problems Signed-off-by: Alex Buckley <alexbuckley@catalyst.net.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 --- Comment #5 from Serhij Dubyk <dubyk@ukr.net> --- Revised all changes. Thanks for corrections! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dubyk@ukr.net |ity.org | CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- There is something wrong happening when I apply the patch: error: patch failed: installer/data/mysql/uk-UA/authorised_values/authorised_values_[IND_852].sql:1 error: installer/data/mysql/uk-UA/authorised_values/authorised_values_[IND_852].sql: patch does not apply error: Did you hand edit your patch? It does not apply to blobs recorded in its index. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com Attachment #63100|1 |0 is obsolete| | --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 63100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63100 Update Ukrainian installer sample files for 17.05 Attempting resurrection and corrections properly, thought the old one may apply cleanly and work from there. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63100|0 |1 is obsolete| | --- Comment #8 from M. Tompsett <mtompset@hotmail.com> --- Comment on attachment 63100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63100 Update Ukrainian installer sample files for 17.05 Both apply for me. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 --- Comment #9 from M. Tompsett <mtompset@hotmail.com> --- (In reply to M. Tompsett from comment #8)
Comment on attachment 63100 [details] [review] Update Ukrainian installer sample files for 17.05
Both apply for me.
AH! onboarding reorganized everything. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Serhij Dubyk <dubyk@ukr.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #63770|0 |1 is obsolete| | --- Comment #10 from Serhij Dubyk <dubyk@ukr.net> --- Created attachment 65179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65179&action=edit Update Ukrainian installer sample files for 17.05 Added changes from Alex Buckley and prepared new patch for the master. Update and translate sample SQL file of the Ukrainian installer. To test: - Start with an empty database - Install uk-UA - Run the web installer in uk-UA/Ukrainian - Verify all files load without any problems. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Serhij Dubyk <dubyk@ukr.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #11 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Hi Serhij, The patch still does not apply: Using index info to reconstruct a base tree... .git/rebase-apply/patch:2662: trailing whitespace. ('rubbkk', 'Таблиці ББК для краєзнавчих каталогів бібліотек', 1, 'generic'), .git/rebase-apply/patch:4067: trailing whitespace. error: patch failed: installer/data/mysql/uk-UA/authorised_values/authorised_values_[IND_852].sql:1 error: installer/data/mysql/uk-UA/authorised_values/authorised_values_[IND_852].sql: patch does not apply .git/rebase-apply/patch:936: new blank line at EOF. + .git/rebase-apply/patch:2401: new blank line at EOF. + .git/rebase-apply/patch:2481: new blank line at EOF. + error: Did you hand edit your patch? It does not apply to blobs recorded in its index. Patch failed at 0001 Update and translate sample SQL file of the Ukrainian installer. Could you double check please? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Serhij Dubyk <dubyk@ukr.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65179|0 |1 is obsolete| | --- Comment #12 from Serhij Dubyk <dubyk@ukr.net> --- Created attachment 66382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66382&action=edit new patch I tried to remove the trailing whitespace everywhere. Perhaps there is still some problem in the patch preparation itself. I did the following: git clone git://git.koha-community.org/koha.git kohaclone git checkout -b my_master origin/master git fetch git rebase origin/master replace folder kohaclone/installer/data/mysql/uk-UA with new content from https://www.dropbox.com/sh/nybt54x8yhh7frq/AACfsG32sJnBgNh1CdivXDjYa?dl=0%27 (folder SQL_Koha_17_05.01/uk-UA or uk-UA_SQL_Koha_17_05.01.zip) git commit -a git log git format-patch origin/master attach 0001-Bug-18537-Update-Ukr~ler-sample-files-fo.patch to Bugzilla Do I need to execute a command "git rm file" for all deleted or renamed files? I hope that there will be no problems with this version of the patch. To test: - Start with an empty database - Install uk-UA - Run the web installer in uk-UA/Ukrainian - Verify all files load without any problems. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66382|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 66512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66512&action=edit Bug 18537 - Update Ukrainian installer sample files for 17.05 Update and translate sample SQL files of the Ukrainian installer. To test: - Start with an empty database - Install uk-UA - Run the web installer in uk-UA/Ukrainian - Verify all files load without any problems. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 --- Comment #14 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have tested the web installer with MARC21 and UNIMARC, installing all sample files each time. There were no SQL errors. I would suggest to bring the Ukrainian installer more in line with the en installer long term, as this might help with new features like the onboarding tool and with updating in the future. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 --- Comment #15 from Serhij Dubyk <dubyk@ukr.net> --- Thank you for testing! This patch got a lot of changes in Ukrainian sql-files in a few years. I tried to make all the latest changes from the English set of sql-files (as well as other languages). The structure of the directories and filenames and sql-sets is as close as possible to the English collection. I tried to spread all the marc-dependent changes to the relevant folders (this applies to system variables, relatorterms, sample marc data, z39-50 servers, matching_rules). Keep in line match was not very successful, since I tried to make sql-files easy to read. This is especially true for marc structures. Separately was written perl script for such formatting. Future changes in Ukrainian sql-files I hope to do with small correction patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Serhij, it's alright, I was thinking about the separate files for different authorised values for example. As a rule we ask contributors to also update the different installers, when new categories or sample notices are added. If the files are named the same and the structure matches this is a lot easier to do. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I still get the same error from git. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I got not problems - it applies cleanly. I have tested on a standard kohadevbox and just now tried it against master in my super old git dev installation. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #66512|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 66634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66634&action=edit Bug 18537 - Update Ukrainian installer sample files for 17.05 Update and translate sample SQL files of the Ukrainian installer. To test: - Start with an empty database - Install uk-UA - Run the web installer in uk-UA/Ukrainian - Verify all files load without any problems. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #21 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.05.x, will be in 17.05.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Stable |RESOLVED --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Obviously not for 16.11.x :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18537 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19973 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19973 [Bug 19973] SQL syntax error in uk-UA/mandatory/sample_notices.sq -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org