[Bug 23562] New: Only one authorities search in header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23562 Bug ID: 23562 Summary: Only one authorities search in header Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs@lists.koha-community.org Reporter: fridolin.somers@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com In authorities module, header contains 4 authorities search, from "main heading $a" to "entire record". This is more a search option than really different searches. I propose to merge them into only one with a select for where to search. This allow to always keep current search options. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23562 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |fridolin.somers@biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23562 --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 92648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92648&action=edit Screenshot See result -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23562 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23562 --- Comment #2 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 92649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92649&action=edit Bug 23562: Only one authorities search in header In authorities module, header contains 4 authorities search, from "main heading $a" to "entire record". This is more a search option than really different searches. I propose to merge them into only one with a select for where to search. This allow to always keep current search options. This patch also adds title arguemnt on comboboxes to say what the represent. Also changes submit button text with "Search" like in many places. Since there is a new combobox, a CSS rule need to be added to have an input text of 20em instead of 30em. Test plan : 1) Go to Authorities module 2) Choose a value different from fist in all comboboxes of header 3) Enter a text in input 4) Click on submit 5) Check that all values and text are kept 6) Perform search with each value of "Where" combobox and check results are OK -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23562 --- Comment #3 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Created attachment 92650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92650&action=edit Bug 23562: Compiled CSS -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23562 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- I think this patch makes perfectly logical sense but is a step backwards in terms of usability. The tabs allow for a more compact form, whereas with this patch the browser window needs to be fairly wide to accommodate it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23562 --- Comment #5 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- (In reply to Owen Leonard from comment #4)
I think this patch makes perfectly logical sense but is a step backwards in terms of usability. The tabs allow for a more compact form, whereas with this patch the browser window needs to be fairly wide to accommodate it.
OK. Do you think it will be better if we add the hiding/show of some options, like in patron search (the little [+]) ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23562 Marjorie Barry-Vila <marjorie.barry-vila@collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila@collect | |o.ca -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23562 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92650|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23562 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92649|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 100339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100339&action=edit Bug 23562: Only one authorities search in header In authorities module, header contains 4 authorities search, from "main heading $a" to "entire record". This is more a search option than really different searches. I propose to merge them into only one with a select for where to search. This allow to always keep current search options. This patch also adds title arguemnt on comboboxes to say what the represent. Also changes submit button text with "Search" like in many places. Since there is a new combobox, a CSS rule need to be added to have an input text of 20em instead of 30em. Test plan : 1) Go to Authorities module 2) Choose a value different from fist in all comboboxes of header 3) Enter a text in input 4) Click on submit 5) Check that all values and text are kept 6) Perform search with each value of "Where" combobox and check results are OK Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23562 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize@ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice little enhancement, Signing off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23562 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Fridolin SOMERS from comment #5)
(In reply to Owen Leonard from comment #4)
I think this patch makes perfectly logical sense but is a step backwards in terms of usability. The tabs allow for a more compact form, whereas with this patch the browser window needs to be fairly wide to accommodate it.
OK. Do you think it will be better if we add the hiding/show of some options, like in patron search (the little [+]) ?
Hmm, I see both sides of this.. I wonder if the 'sort order' could be removed.. it's not so much to do with the search itself but the results and as such feels to me like it doesn't entirely belong here anyway. That would help reduce the width of the field search element somewhat... I sort of like the [+] option as an alternative too, but though I'd throw this idea into the mix. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23562 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Owen Leonard <oleonard@myacpl.org> --- I also played around with some structural template changes that could be applied more globally. This is one area where we need better responsive layouts. I think this patch can move forward without a "solution," but I did notice one other thing while I was tinkering: Now that we're not using tabs to switch between searches we really should add the other tabs which are generally found there: Check out, Check in, Renew, Search the catalog. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23562 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good call Owen.. I did wonder about the inconsistency in the lack of tabs. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org