http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13184 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13184 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Blocks|10860 | Depends on| |10860 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13184 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33094|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@quecheelibrary.org> --- Created attachment 33113 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33113&action=edit [SIGNED OFF] Bug 13184 - Circulation template problems if OnSiteCheckouts is off but OnSiteCheckoutsForce is on Checks in the circulation template for on-site checkouts preferences did not take into account the possibility that someone might have accidentally turned OnSiteCheckouts off but left OnSiteCheckoutsForce turned on. This patch amends the template logic so that it works correctly for various combinations of settings. To test, apply the patch and test the following combinations of circumstances. Testing using both a patron who is blocked (expired, restricted, etc) and a patron who is not blocked, test with... 1. OnSiteCheckouts is on, OnSiteCheckoutsForce is on 2. OnSiteCheckouts is off, OnSiteCheckoutsForce is on 3. OnSiteCheckouts is off, OnSiteCheckoutsForce is off 4. OnSiteCheckouts is on, OnSiteCheckoutsForce is off Confirm that the checkout form is shown or not shown correctly according to the preferences you have set. Confirm that the "Only on-site checkouts are allowed" message is only shown in case #1. Note: This patch includes whitespace changes, so please diff accordingly. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13184 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33113|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33114&action=edit [PASSED QA] Bug 13184 - Circulation template problems if OnSiteCheckouts is off but OnSiteCheckoutsForce is on Checks in the circulation template for on-site checkouts preferences did not take into account the possibility that someone might have accidentally turned OnSiteCheckouts off but left OnSiteCheckoutsForce turned on. This patch amends the template logic so that it works correctly for various combinations of settings. To test, apply the patch and test the following combinations of circumstances. Testing using both a patron who is blocked (expired, restricted, etc) and a patron who is not blocked, test with... 1. OnSiteCheckouts is on, OnSiteCheckoutsForce is on 2. OnSiteCheckouts is off, OnSiteCheckoutsForce is on 3. OnSiteCheckouts is off, OnSiteCheckoutsForce is off 4. OnSiteCheckouts is on, OnSiteCheckoutsForce is off Confirm that the checkout form is shown or not shown correctly according to the preferences you have set. Confirm that the "Only on-site checkouts are allowed" message is only shown in case #1. Note: This patch includes whitespace changes, so please diff accordingly. Signed-off-by: Nick Clemens <nick@quecheelibrary.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Tested on top of 10860 and 13179. Works as described, adding more checks in the templates. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13184 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.