http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9226 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |fridolyn.somers@biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS <fridolyn.somers@biblibre.com> --- Created attachment 13905 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13905&action=edit Proposed patch Proposed patch : Bug comes from the fact that the inputs of branch selection at creation and input of branch filtering have the same name. So $branchfilter gets a value when it souldn't. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9226 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #13905|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 14273 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14273&action=edit [SIGNED-OFF] Bug 9226: Wrong branch filter after suggestion creation Signed-off-by: Owen Leonard <oleonard@myacpl.org> Before the patch, upon submitting a new suggestion in the staff client I was redirected to a view which was not filtered by branch. After the patch I was redirected to a view which was filtered by my logged-in branch. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9226 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #14273|0 |1 is obsolete| | --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 15336 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15336&action=edit Bug 9226: Wrong branch filter after suggestion creation Signed-off-by: Owen Leonard <oleonard@myacpl.org> Before the patch, upon submitting a new suggestion in the staff client I was redirected to a view which was not filtered by branch. After the patch I was redirected to a view which was filtered by my logged-in branch. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9226 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Looks good to me. The patch makes a small improvement. This is outside the scope of your report: But if I clear the filter, I am still surprised that it filters by my branch. Clear actually means here something as Default. Two links: Clear and Default would be even more nice :) Organize by-combo should also keep its value and not go back to Status when the display is e.g. Library. Passed QA -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9226 Jared Camins-Esakov <jcamins@cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes.