http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12214 --- Comment #1 from paxed <pasi.kallinen@pttk.fi> --- Created attachment 28044 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28044&action=edit Fix DB erros not showing to the user When a user runs a report containing an SQL error, no error is shown to the user. To test: 1) Run a report with known good SQL. 2) No error is shown. 3) Run a report with bad SQL (eg. a typo in field name) 4) No error is shown. 5) Apply patch 6) Repeat 1-4. For the bad SQL report, the database error should be shown. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12214 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12214 --- Comment #3 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 28116 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28116&action=edit Bug 12214: display SQL errors in reports to users When a user runs a report containing an SQL error, no error is shown to the user. This patch fixes this. To test: 1) Run a report with known good SQL. 2) No error is shown. 3) Run a report with bad SQL (eg. a typo in field name) 4) No error is shown. 5) Apply patch 6) Repeat 1-4. For the bad SQL report, the database error should be shown. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12214 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle@bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle@bywatersolutions.com> --- When a report has an error in the query, the page does not display the "Edit" or "Run report" links that are shown for successful reports. While I see no reason have the "Run report" link here. I think having the "Edit" link would be very important! -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12214 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28115|0 |1 is obsolete| | Attachment #28116|0 |1 is obsolete| | Attachment #28117|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28132 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28132&action=edit [PASSED QA] Bug 12214: add regression test for reporting error when running report with SQL error To test: [1] Run prove -v t/db_dependent/Reports_Guided.t. Last test should fail. [2] Apply the main patch. [3] Run step 1 again. This time, all tests should pass. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12214 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28134 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28134&action=edit [PASSED QA] Bug 12214: (follow-up) correct POD of C4::Reports::Guided::execute_query() Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12214 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28135|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28136 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28136&action=edit [PASSED QA] Bug 12214 [QA Followup] - Clean up reports-toolbar.inc, show Edit link when SQL has errors Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.