[Bug 36461] New: Advanced editor should disable RequireJS timeout with waitSeconds: 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36461 Bug ID: 36461 Summary: Advanced editor should disable RequireJS timeout with waitSeconds: 0 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: phil@chetcolibrary.org Reporter: phil@chetcolibrary.org QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl We currently set waitSeconds: 30 for RequireJS in the advanced editor, which as bug 35799 says just causes loading of the editor to hang forever if loading any required part (which practially speaking means loading svc/cataloguing/framework) takes more than 30 seconds. As jrburke says in https://github.com/requirejs/requirejs/issues/787 waitSeconds exists to show developers why things aren't working when they try to require something that 404s, and to allow error handling in old versions of IE. But since we aren't doing any error handling, we'd be better off setting it to 0, which disables the timeout, and just letting things load no matter how long they take. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36461 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36461 --- Comment #1 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 164099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164099&action=edit Bug 36461: Advanced editor should disable RequireJS timeout with waitSeconds: 0 We aren't actually doing any error handling with the RequireJS waitSeconds config, just leaving the advanced editor hanging on loading if it times out, so instead we should disable it. Test plan: 1. Set the preference EnableAdvancedCatalogingEditor to Enable 2. Load the Cataloging module home page in Firefox and open Firefox's Web Developer Tools, and in the Network tab change from "No Throttling" to "Regular 2G" 3. In the Cataloging page, click Advanced editor, and watch it attempt to load for 30 seconds, followed by a setTimout error in the devtools console, and then wait as long as you can stand for anything but the "Loading, please wait..." to happen in the web page. Nothing ever will. 4. Apply the patch, restart, set EnableAdvancedCatalogingEditor back to Enable, turn throttling on, load the Advanced editor again, and note that even though it will take a minute or more to load through the throttling, the editor does actually load. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36461 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36461 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164099|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 164125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164125&action=edit Bug 36461: Advanced editor should disable RequireJS timeout with waitSeconds: 0 We aren't actually doing any error handling with the RequireJS waitSeconds config, just leaving the advanced editor hanging on loading if it times out, so instead we should disable it. Test plan: 1. Set the preference EnableAdvancedCatalogingEditor to Enable 2. Load the Cataloging module home page in Firefox and open Firefox's Web Developer Tools, and in the Network tab change from "No Throttling" to "Regular 2G" 3. In the Cataloging page, click Advanced editor, and watch it attempt to load for 30 seconds, followed by a setTimout error in the devtools console, and then wait as long as you can stand for anything but the "Loading, please wait..." to happen in the web page. Nothing ever will. 4. Apply the patch, restart, set EnableAdvancedCatalogingEditor back to Enable, turn throttling on, load the Advanced editor again, and note that even though it will take a minute or more to load through the throttling, the editor does actually load. Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36461 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Signed Off |Passed QA --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Trivial update - we aren't handling the error, so waiting will appear the same, but it may succeed now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36461 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36461 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36461 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.06 released in| | Status|Pushed to main |Pushed to stable --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36461 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|24.05.00,23.11.06 |24.05.00,23.11.06,23.05.12 released in| | CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 23.05.x for upcoming 23.05.12 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36461 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Pushed to oldoldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36461 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldoldstable |Needs documenting CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #7 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11 unless requested -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org