[Bug 8514] New: Display of patron results changed display order
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8514 Priority: P5 - low Change sponsored?: --- Bug ID: 8514 CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Assignee: koha-bugs@lists.koha-community.org Summary: Display of patron results changed display order Severity: normal Classification: Unclassified OS: All Reporter: colin.campbell@ptfs-europe.com Hardware: All Status: NEW Version: master Component: Patrons Product: Koha As part of the patch associated with bug 6303 the display of patrons returned by a seach has changed from surname, firstname to firstname surname. As that change is not flagged in the commit message or associated bug I assume this was inadvertant. Libraries seeing the newer display are seeing it as a regression -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8514 --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- NB See also bug 8427 a problem with sorting the results that may be obscured by this one -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8514 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com --- Comment #2 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 11170 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11170&action=edit Proposed Patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8514 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #11170|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 11171 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11171&action=edit [SIGNED-OFF] Bug 8514 Restore Patron Name Display Order Bug 6303 introduced an include file governing patron name display unfortunately that changed patron display in search result lists and on the circ screen header. This adds a parameter restroring the original surname, firstname order, whose absence was perceived as a loss of functionality Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8514 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8514 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |mtj@kohaaloha.com --- Comment #4 from Mason James <mtj@kohaaloha.com> --- (In reply to comment #3)
Created attachment 11171 [details] [SIGNED-OFF] Bug 8514 Restore Patron Name Display Order
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
patch looks good, passing QA mason@xen1:~/git/head$ koha-qa.pl * 53b4f14 Bug 8514 Restore Patron Name Display Order koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt - perlcritic-progressive tests... OK - perl -c syntax tests... OK - xt/tt_valid.t tests... OK - xt/author/valid-template.t tests... OK -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8514 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.8.x, will be in 3.8.4 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8514 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion CC| |paul.poulain@biblibre.com --- Comment #6 from Paul Poulain <paul.poulain@biblibre.com> --- QA comment: IIRC, we introduced patron-title to be sure we have a consistent display of the patron everywhere. This patch reintroduces the possibility of having the display inconsistent. I think it is to let the librarian being able to sort the table by surname, isn't it ? However, I think it's worth being discussed. 3 option: * we reintroduce the possibility to be inconsistent * we switch to surname firstname everywhere * we keep firstname surname (and discard this patch) Any other option or anything I misunderstood welcomed ! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8514 --- Comment #7 from Colin Campbell <colin.campbell@ptfs-europe.com> --- I think a single consistent format everywhere is not desirable. In the real world our names appear in different formats depending on the context. In lists (e.g. a phonebook) inverted is the norm in singular uses (e.g. addressing a letter, introductions) uninverted form. Forcing all formats to follow one or the other is seen by users as unnatural and disrupting to the work flow. The removal of inverted form from search result lists seriously disrupts the usefulness of those lists for large institutions. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8514 --- Comment #8 from Chris Cormack <chris@bigballofwax.co.nz> --- I think I agree with Colin here, you do often want things displayed in different ways depending on context. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8514 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8514 Paul Poulain <paul.poulain@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master Version|master |rel_3_8 --- Comment #9 from Paul Poulain <paul.poulain@biblibre.com> --- Patch pushed to master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8514 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org