[Bug 12774] New: Enabling phone notices ( talking tech ) without having DUEDGST and PREDUEDGST breaks advance notices!
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12774 Bug ID: 12774 Summary: Enabling phone notices ( talking tech ) without having DUEDGST and PREDUEDGST breaks advance notices! Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Notices Assignee: koha-bugs@lists.koha-community.org Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12774 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- If talking tech is enabled, and a patron has selected phone notices for predue and/or due notices, advance_notices will die when coming upon a patron with phone notices selected. The TT script for advance notices does not use a letter and thus no letter exists for it by default. When advance_notices comes upone this, it sees the phone transport, tries to get the notices for the phone transport, and dies. Resolutions: 1) Strip 'phone' from the list of transports in advance_notices.pl 2) Change the die at line 376 to a warn or carp. There is no reason not to allow the script to continue sending notices. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12774 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |kyle@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12774 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I suspect this could be a duplicate of bug 12730 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12774 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12774 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 34481 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34481&action=edit Bug 12774 - Enabling phone notices ( talking tech ) without having DUEDGST and PREDUEDGST breaks advance notices! If talking tech is enabled, and a patron has selected phone notices for predue and/or due notices, advance_notices will die when coming upon a patron with phone notices selected. The TT script for advance notices does not use a letter and thus no letter exists for it by default. When advance_notices comes upone this, it sees the phone transport, tries to get the notices for the phone transport, and dies. Test Plan: 1) Enable TalkingTech 2) Set one or more patrons to recieve advance notices via phone 3) Set one or more patrons so they should recieve an advance notice today 4) Run advance_notices.pl, note that it dies 5) Apply this patch 6) Run advance_notices.pl, note that it now warns instead of dying -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12774 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12922 CC| |jonathan.druart@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12774 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #4 from Jonathan Druart <jonathan.druart@biblibre.com> --- Kyle, I prefer the patch proposed on bug 12922. It does the same thing but at one other place. *** This bug has been marked as a duplicate of bug 12922 *** -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org