[Bug 13539] New: Table patroncards not used?
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 Bug ID: 13539 Summary: Table patroncards not used? Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger@foundations.edu Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org It appears that creating patroncard batches and printing those is not adding data to the patroncards table, but the creator_batches table is used for storing the information. Looking and searching the code I couldn't find where data is inserted in the patroncards table - is it possible the table is no longer in use? Maybe since the rewrite of the label creators? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 --- Comment #1 from Chris Nighswonger <cnighswonger@foundations.edu> --- <chris_n> hmm... that table appears to be vestigial <chris_n> mysql> SELECT count(*) FROM patroncards; <chris_n> +----------+ <chris_n> | count(*) | <chris_n> +----------+ <chris_n> | 5 | <chris_n> +----------+ <chris_n> 1 row in set (0.00 sec) <chris_n> but the timestamps are from 2008 <chris_n> and grep shows no code referencing that table And so this table may safetly be removed, IMHO. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Table patroncards not used? |Table patroncards not used -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger@foundations.ed |katrin.fischer@bsz-bw.de |u | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 35351 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35351&action=edit Bug 13539 - Remove unused table patroncards It appears that the table patroncards hasn't been used since the database updates for the rewritten label modules ('3.01.00.107'). It's time to remove them from the database. As the patron card batches were needed for printing and the data has not been accessible in a long time, it seems safe to delete it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I'd consider the batch data kind of temporary as it's only needed for printing. There is no way to clean out the old data from within Koha and it's not been accessible in the GUI apart from reports for a long time. If someone sees a reason to be more careful here, please comment :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Test plan: - Check the table exists in your database - Run the database update - Confirm the table has been deleted - Verify the table is not necessary for printing patroncards (using the feature and/or checking the codebase) - Make sure the web installer still works correctly on creating a new database, but that patroncards is no longer created -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Label/patron card printing |Database -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #35351|0 |1 is obsolete| | --- Comment #5 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 36153 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36153&action=edit Bug 13539 - Remove unused table patroncards It appears that the table patroncards hasn't been used since the database updates for the rewritten label modules ('3.01.00.107'). It's time to remove them from the database. As the patron card batches were needed for printing and the data has not been accessible in a long time, it seems safe to delete it. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Removes the tables. Seems safe to delete to me too, while testing through the patrons -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #36153|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 36158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36158&action=edit Bug 13539 - Remove unused table patroncards It appears that the table patroncards hasn't been used since the database updates for the rewritten label modules ('3.01.00.107'). It's time to remove them from the database. As the patron card batches were needed for printing and the data has not been accessible in a long time, it seems safe to delete it. Signed-off-by: Brendan Gallagher <brendan@bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 37769 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37769&action=edit Bug 13539: (RM followup) DBIx schema update Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13539 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Katrina! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org