[Bug 18078] New: Updating buttons for z39.50 Authority search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 Bug ID: 18078 Summary: Updating buttons for z39.50 Authority search Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: gmcharlt@gmail.com Reporter: aleishaamohia@hotmail.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 --- Comment #1 from Aleisha Amohia <aleishaamohia@hotmail.com> --- Created attachment 60002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60002&action=edit Bug 18078: Updating buttons for z39.50 Authority search 1) Go to Cataloguing -> New from Z39.50 2) Notice how Search button is strangely off page (have to scroll down to see it) 3) Do a search, noticing the ugly buttons from Comment 1 4) Apply patch and go back to a new search 5) Do a search again, notice no longer need to scroll to get to Search button and new, nicer buttons 6) Confirm they still work as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 Aleisha Amohia <aleishaamohia@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |aleishaamohia@hotmail.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60002|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 61172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61172&action=edit Bug 18078: Updating buttons for z39.50 Authority search 1) Go to Home > Authorities -> New from Z39.50 2) Notice how Search button is strangely off page (have to scroll down to see it) 3) Do a search, noticing the ugly buttons from Comment 1 4) Apply patch and go back to a new search 5) Do a search again, notice no longer need to scroll to get to Search button and new, nicer buttons 6) Confirm they still work as expected Sponsored-by: Catalyst IT Testplan changed to test with Authorities. Z39.50 search for authorities displays and Works as expected. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |oleonard@myacpl.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I discussed with Owen about the use of btn-primary and I think the conclusion was not to use as it is, but customise our own. I do not find the bug report where it has been discussed, so ccing Owen to refresh my mind. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 --- Comment #4 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #3)
I discussed with Owen about the use of btn-primary and I think the conclusion was not to use as it is, but customise our own. I do not find the bug report where it has been discussed, so ccing Owen to refresh my mind.
Maybe Bug 18042 ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Yes certainly, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 julien.comte@u-psud.fr changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julien.comte@u-psud.fr --- Comment #6 from julien.comte@u-psud.fr --- No need to scroll to get to search buttons. -- You are receiving this mail because: You are watching all bug changes.
From bug 18042 comment 5: "- I think we should come up with updates to the default Bootstrap button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- styles if we are going to use more than the btn-default class. Bootstrap colors aren't designed to work with Koha's, and we should avoid looking like out-of-the-box Bootstrap." -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18042 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|oleonard@myacpl.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61172|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 82990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82990&action=edit Bug 18078: Updating buttons for z39.50 Authority search This patch is an alternate proposal for updating buttons on the Z39.50 authority search popup window. It takes some aspects of the original proposal--Styling the pagination buttons with Bootstrap--and adds a new interaction for navigating to a specific page in results. To test, apply the patch and go to Authorities -> New Authority -> New from Z39.50/SRU. - Perform a search which will return multiple pages of results - At the bottom of the search results there should be a dropdown menu offering selection of page numbers. - Selecting a number from the dropdown should automatically load that page of results. - The current page number should be correctly pre-selected in the dropdown. - The "Previous" and "Next" buttons should work normally. - Perform a search which returns only a single page of results. There should be no navigation controls at the bottom of the page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Wasn't able to complete the Search. After clicking Search, this error shows: Template process failed: undef error - WHILE loop terminated (> 1000 iterations) at /home/vagrant/kohaclone/C4/Templates.pm line 122 C4::Templates::output('C4::Templates=HASH(0x9b91f38)') called at /home/vagrant/kohaclone/cataloguing/z3950_auth_search.pl line 108 eval {...} at /home/vagrant/kohaclone/cataloguing/z3950_auth_search.pl line 2 CGI::Compile::ROOT::home_vagrant_kohaclone_cataloguing_z3950_auth_search_2epl::__ANON__('CGI::Compile=HASH(0x1493b08)', undef, '/home/vagrant/kohaclone/cataloguing/z3950_auth_search.pl', '/home/vagrant/kohaclone/cataloguing', 'ARRAY(0x958c750)') called at /usr/share/perl5/CGI/Compile.pm line 139 CGI::Compile::__ANON__ at /usr/share/perl5/CGI/Emulate/PSGI.pm line 29 CGI::Emulate::PSGI::__ANON__('HASH(0x9578700)') called at /usr/share/perl5/Plack/App/WrapCGI.pm line 87 Plack::App::WrapCGI::call('Plack::App::WrapCGI=HASH(0x95806a8)', 'HASH(0x9578700)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x9578700)') called at /usr/share/perl5/Plack/App/CGIBin.pm line 50 Plack::App::CGIBin::serve_path('Plack::App::CGIBin=HASH(0x144ffd8)', 'HASH(0x9578700)', '/home/vagrant/kohaclone/cataloguing/z3950_auth_search.pl') called at /usr/share/perl5/Plack/App/File.pm line 34 Plack::App::File::call('Plack::App::CGIBin=HASH(0x144ffd8)', 'HASH(0x9578700)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x9578700)') called at /usr/share/perl5/Plack/App/URLMap.pm line 71 Plack::App::URLMap::call('Plack::App::URLMap=HASH(0x8647598)', 'HASH(0x9578700)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x9578700)') called at /home/vagrant/kohaclone/Koha/Middleware/SetEnv.pm line 104 Koha::Middleware::SetEnv::call('Koha::Middleware::SetEnv=HASH(0x94f9b98)', 'HASH(0x953e448)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x953e448)') called at /usr/share/perl5/Plack/Middleware/Static.pm line 18 Plack::Middleware::Static::call('Plack::Middleware::Static=HASH(0x95451e8)', 'HASH(0x953e448)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x953e448)') called at /usr/share/perl5/Plack/Middleware/ReverseProxy.pm line 68 Plack::Middleware::ReverseProxy::call('Plack::Middleware::ReverseProxy=HASH(0x9578808)', 'HASH(0x953e448)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x953e448)') called at /usr/share/perl5/Plack/Middleware/Lint.pm line 24 Plack::Middleware::Lint::call('Plack::Middleware::Lint=HASH(0x1251178)', 'HASH(0x953e448)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Middleware::StackTrace::try {...} at /usr/share/perl5/Try/Tiny.pm line 79 eval {...} at /usr/share/perl5/Try/Tiny.pm line 72 Plack::Middleware::StackTrace::call('Plack::Middleware::StackTrace=HASH(0x863b158)', 'HASH(0x953e448)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x953e448)') called at /usr/share/perl5/Plack/Middleware/AccessLog.pm line 24 Plack::Middleware::AccessLog::call('Plack::Middleware::AccessLog=HASH(0x144ff48)', 'HASH(0x953e448)') called at /usr/share/perl5/Plack/Component.pm line 50 Plack::Component::__ANON__('HASH(0x953e448)') called at /usr/share/perl5/Plack/Util.pm line 142 eval {...} at /usr/share/perl5/Plack/Util.pm line 142 Plack::Util::run_app('CODE(0x94e42d0)', 'HASH(0x953e448)') called at /usr/share/perl5/Starman/Server.pm line 281 Starman::Server::process_request('Starman::Server=HASH(0xe8d6a8)', 'Net::Server::Proto::UNIX=GLOB(0x8647130)') called at /usr/share/perl5/Net/Server.pm line 74 Net::Server::run_client_connection('Starman::Server=HASH(0xe8d6a8)') called at /usr/share/perl5/Net/Server/PreFork.pm line 229 eval {...} at /usr/share/perl5/Net/Server/PreFork.pm line 229 Net::Server::PreFork::run_child('Starman::Server=HASH(0xe8d6a8)') called at /usr/share/perl5/Net/Server/PreFork.pm line 187 Net::Server::PreFork::run_n_children('Starman::Server=HASH(0xe8d6a8)', 2) called at /usr/share/perl5/Net/Server/PreFork.pm line 111 Net::Server::PreFork::loop('Starman::Server=HASH(0xe8d6a8)') called at /usr/share/perl5/Net/Server.pm line 60 Net::Server::run('Starman::Server=HASH(0xe8d6a8)', 'port', 'ARRAY(0x1394040)', 'host', '*', 'proto', 'tcp', 'serialize', 'none', 'min_servers', 2, 'min_spare_servers', 1, 'max_spare_servers', 1, 'max_servers', 2, 'max_requests', 50, 'user', 'kohadev-koha', 'group', 'kohadev-koha', 'listen', 1024, 'check_for_waiting', 1, 'no_client_stdout', 1, 'background', 1, 'pid_file', '/var/run/koha/kohadev/plack.pid', 'setsid', 1, 'log_file', '/var/log/koha/kohadev/plack-error.log') called at /usr/share/perl5/Starman/Server.pm line 89 Starman::Server::run('Starman::Server=HASH(0xe8d6a8)', 'CODE(0xe8d540)', 'HASH(0xe8d228)') called at /usr/share/perl5/Plack/Handler/Starman.pm line 18 Plack::Handler::Starman::run('Plack::Handler::Starman=HASH(0xe8d558)', 'CODE(0xe8d540)') called at /usr/share/perl5/Plack/Loader/Delayed.pm line 20 Plack::Loader::Delayed::run('Plack::Loader::Delayed=HASH(0xb94bf0)', 'Plack::Handler::Starman=HASH(0xe8d558)') called at /usr/share/perl5/Plack/Runner.pm line 277 Plack::Runner::run('Plack::Runner=HASH(0xb49b38)') called at /usr/bin/starman line 38 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Aleisha Amohia from comment #9)
Wasn't able to complete the Search. After clicking Search, this error shows:
Template process failed: undef error - WHILE loop terminated (> 1000 iterations) at /home/vagrant/kohaclone/C4/Templates.pm line 122
I'm obsoleting that comment because it's really long and I think the above snippet is what's really relevant: My changed template tries to use a WHILE loop with result pages and there is a hard limit of 1000 for that kind of loop. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82990|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #61172|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- My patch is a non-starter, so I restored Aleisha's. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18078 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |FIXED --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- These buttons have also seen some updates with the staff interface redesign. It's a bit hard without a screenshot or similar, but I think main goals have been achieved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org