http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2478 Andrew.moore@liblime.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED ------- Comment #3 from Andrew.moore@liblime.com 2008-08-13 09:42 ------- I see a few problems here. The one that sticks out most is that misc/cronjobs/overdue_notices.pl doesn't work right when given no branch, or when the branch it's called with doesn't have any overdue rules. The way that it's called from circ/overdue.pl isn't quite right, either. It still has a -b flag even when no branch is passed to it. But, the underlying problem here is that we shouldn't be calling this cronjob from the web interface. Not only is it unexpected behavior, but we're also duplicating the logic of compiling a list of overdues in two places. In fact, if this were to work, the csv created wouldn't necessarily have the same list of patrons as the report on the web page. I think that the way to fix this is to extract the logic to find these overdues into a method (probably in C4::Overdues) and call that method from both the web interface and from the cronjob. They can deal with the formatting for their particular purpose. I'll look a little more closely to see if both of these overdue reports can share the same logic and attempt to extract it. ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.