[Bug 34880] New: Receive impossible if items created 'in cataloguing'
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34880 Bug ID: 34880 Summary: Receive impossible if items created 'in cataloguing' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org CC: fridolin.somers@biblibre.com, michaela.sieber@kit.edu, tomascohen@gmail.com To test: * Add a new basket as 'standing order' and with 'items created in cataloguing' * Create an order line * Receive shipment and create an invoice * Receive your order * Verify: * Quantity ordered: 1 * Quantity received: 1 (pre-filled) * No item form on the right * Confirm * Receive error: Order X: No quantity to receive set. No items will be created. * Verify no receive was processed (received orders remains empty) This means that libraries can't process orders and requires an urgent fix. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34880 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34736 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 [Bug 34736] Item checkboxes move to wrong order line in multi-receive, breaking partial receive -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34880 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I did a git bisect and it points to bug 34736. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34880 --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156036&action=edit Bug 34880: Fix order receive for standing orders -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34880 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #3 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Probable fix, but what about possible side-effects? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34880 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34880 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34880 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The attached patch fixes: * Standing order + Item created in cataloguing The attached patch breaks: * Standing order + Item created on receive Without the patch the quantity received is 0 and increased to 1 when the item form is submitted. With the patch, the quantity received is 1 and we get an error on saving the item form because it tries to increase above the 'ordered' value. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34880 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34880 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156036|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156043&action=edit Bug 34880: Fix order receive for standing orders Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34880 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 156044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156044&action=edit Bug 34880: (follow-up) Make condition more specific To test (applies to both patches): * Add a new basket as 'standing order' and with 'items created in cataloguing' * Create an order line * Receive shipment and create an invoice * Receive your order * Verify: * Quantity ordered: 1 * Quantity received: 1 (pre-filled) * No item form on the right * Confirm * Receive error: Order X: No quantity to receive set. No items will be created. * Verify no receive was processed (received orders remains empty) * Apply patch * Verify receive works as expected Other possible combinations to test: * Standing order, items on receive * Standing order, items on order (no items are created) * Standing order + order from subscription + any item setting (no items are created) * No standing order + items in cataloguing * No standing order + items on receive * No standing order + items on order * No standing oder + order from subscription + all item settings (no items are created) Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34880 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156043|0 |1 is obsolete| | --- Comment #7 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 156075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156075&action=edit Bug 34880: Fix order receive for standing orders Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34880 Biblibre Sandboxes <sandboxes@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156044|0 |1 is obsolete| | --- Comment #8 from Biblibre Sandboxes <sandboxes@biblibre.com> --- Created attachment 156076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156076&action=edit Bug 34880: (follow-up) Make condition more specific To test (applies to both patches): * Add a new basket as 'standing order' and with 'items created in cataloguing' * Create an order line * Receive shipment and create an invoice * Receive your order * Verify: * Quantity ordered: 1 * Quantity received: 1 (pre-filled) * No item form on the right * Confirm * Receive error: Order X: No quantity to receive set. No items will be created. * Verify no receive was processed (received orders remains empty) * Apply patch * Verify receive works as expected Other possible combinations to test: * Standing order, items on receive * Standing order, items on order (no items are created) * Standing order + order from subscription + any item setting (no items are created) * No standing order + items in cataloguing * No standing order + items on receive * No standing order + items on order * No standing oder + order from subscription + all item settings (no items are created) Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34880 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34880 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156075|0 |1 is obsolete| | Attachment #156076|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156085&action=edit Bug 34880: Fix order receive for standing orders Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34880 --- Comment #10 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 156086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156086&action=edit Bug 34880: (follow-up) Make condition more specific To test (applies to both patches): * Add a new basket as 'standing order' and with 'items created in cataloguing' * Create an order line * Receive shipment and create an invoice * Receive your order * Verify: * Quantity ordered: 1 * Quantity received: 1 (pre-filled) * No item form on the right * Confirm * Receive error: Order X: No quantity to receive set. No items will be created. * Verify no receive was processed (received orders remains empty) * Apply patch * Verify receive works as expected Other possible combinations to test: * Standing order, items on receive * Standing order, items on order (no items are created) * Standing order + order from subscription + any item setting (no items are created) * No standing order + items in cataloguing * No standing order + items on receive * No standing order + items on order * No standing oder + order from subscription + all item settings (no items are created) Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34880 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34880 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34880 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34880 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_23_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34880 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.11.00 |23.11.00,23.05.04 released in| | Status|Pushed to master |Pushed to stable --- Comment #12 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34880 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=35004 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34880 Bug 34880 depends on bug 34736, which changed state. Bug 34736 Summary: Item checkboxes move to wrong order line in multi-receive, breaking partial receive https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34736 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34880 Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matt.blenkinsop@ptfs-europe | |.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #13 from Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com> --- Dependency missing for 22.11.x - not backporting -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org